LibreOffice icon themes are a hardcoded in vcl. It would be great, if vcl would instead dynamically search the theme folder and populate its menu from what it finds. Code pointers: - git grep STYLE_SYMBOLS_ - http://opengrok.libreoffice.org/s?refs=STYLE_SYMBOLS_DEFAULT&project=core This would allow adding more themes without having to modify the LibreOffice itself (by dumping an properly named zip file in the right location).
Hi, I'll handle this, Jan.
If you are handling this, please assign this bug to yourself. Search for "Assigned To" on this page. Richard
Hello Jan, are you still working on this bug? Else, I would like to fix it. Tobias
Hi, you can fix, althought I would interested in code. Could you send me your final patch, many thanks and good luck!
Tobias, can you then assign yourself to this bug?
adding LibreOffice developer list as CC to unresolved EasyHacks for better visibility. see e.g. http://nabble.documentfoundation.org/minutes-of-ESC-call-td4076214.html for details
Hello, I have some quesions for this task - When should the directory be searched? Where can I add the call to scan the directory? - What is the standard directory where the icons are located? Is the value set anywhere, and how can I access it? Kind regards, Tobias
(In reply to comment #7) > Hello, I have some quesions for this task > - When should the directory be searched? Where can I add the call to scan > the directory? > - What is the standard directory where the icons are located? Is the value > set anywhere, and how can I access it? > Kind regards, > Tobias Hello Tobias, I am also interested in this problem. This is my first easy hack so I'm not experienced at all. So far I investigated the followings I hope it is useful for you: - the theme names are hard coded in the gui in optviewpage.ui see iconstyle combobox -> maybe they should be removed - the icon themes are in base dir + share folder + config + "images_" + theme name + ".zip" (e.g.: /opt/libreoffice4.0/share/config/images_crystal.zip) - I think the combobox should be populated when the options dialog is created (OfaViewTabPage maybe) Best regards, Tamás
For translation we should re-use the code from the gallery that parses .desktop files - since we have code to generate translated theme names from that [ that is if we want to translate those :-].
Hello Michael, In the first version, I will derive the name from the file name of the archive that contains the icons, i.e. images_crystal.zip --> "crystal" icon theme. I think that this is a sensible approach and should suffice for now. The implementation takes much longer than I anticipated because I have long feedback cycles. The involved headers are included everywhere, and almost everything is recompiled if I change something. But I have finished the implementation and am currently working on tests, i.e. I expect to be finished in 2-3 weeks. Tobias
I have submitted the patch (along with two preparatory commits) to gerrit. https://gerrit.libreoffice.org/7933 https://gerrit.libreoffice.org/7934 https://gerrit.libreoffice.org/7935
The changes are available on the master branch. If you find that the feature is not working as desired, please reopen the bug.
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.