Bug 67208 - Horizontal rules in old documents are broken: only links in the files
Summary: Horizontal rules in old documents are broken: only links in the files
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version: 4.1.0.0.alpha0+ Master
Hardware: Other All
: medium normal
Assignee: Not Assigned
QA Contact:
URL:
Whiteboard: EasyHack DifficultyInteresting
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-23 07:58 UTC by Cédric Bosdonnat
Modified: 2014-12-02 10:53 UTC (History)
1 user (show)

See Also:
i915 platform:
i915 features:

Attachments
a sample file containing rules. (9.27 KB, application/vnd.oasis.opendocument.text)
2013-07-23 07:59 UTC, Cédric Bosdonnat 		Details
View All

Description Cédric Bosdonnat 2013-07-23 07:58:43 UTC 
Files containing horizontal rules dating from before commit 3be15a051444d4d2f805d95e27831d5f466c1497 are broken.

The picture wasn't inserted in the file. A backup solution needs to be implemented to at least show a default rule.

An example rule in content.xml:
<draw:frame draw:style-name="fr1" draw:name="graphics1" text:anchor-type="paragraph" svg:width="5.5417in" svg:height="0.1252in" draw:z-index="0">
          <draw:image xlink:href="../../libreoffice/3.6/solver/unxlngx6.pro/installation/opt/program/../share/gallery/rulers/blurulr2.gif" xlink:type="simple" xlink:show="embed" xlink:actuate="onLoad"/>
        </draw:frame>

Fixing this would mean to check the link URL for the /gallery/rulers/ string and use a replacement in that case.


The import code to start with could be the method XMLTextFrameContext::CreateChildContext(), the case with  XML_TEXT_FRAME_GRAPHIC == nFrameType

See file xmloff/source/text/XMLTextFrameContext.cxx

See bug 60858 for the original bug report.
Comment 1 Cédric Bosdonnat 2013-07-23 07:59:22 UTC 
Created attachment 82857 [details]
a sample file containing rules.
Comment 2 Björn Michaelsen 2013-10-04 18:46:06 UTC 
adding LibreOffice developer list as CC to unresolved EasyHacks for better visibility.

see e.g. http://nabble.documentfoundation.org/minutes-of-ESC-call-td4076214.html for details
Comment 3 Björn Michaelsen 2014-12-02 10:53:08 UTC 
adding LibreOffice developer list as CC to unresolved Writer EasyHacks for better visibility.

see e.g. http://nabble.documentfoundation.org/minutes-of-ESC-call-td4076214.html for details

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.