Bug 69926 - Wrong Default notation for Galaxy icon theme
Summary: Wrong Default notation for Galaxy icon theme
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version: Inherited From OOo
Hardware: All All
: lowest trivial
Assignee: Jorendc
QA Contact:
URL:
Whiteboard: target:4.2.0
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-29 12:29 UTC by Maxim Monastirsky
Modified: 2013-10-23 10:29 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments
Screenshot (Ubuntu 13.10) (70.37 KB, image/png)
2013-09-29 12:29 UTC, Maxim Monastirsky
Details

Description Maxim Monastirsky 2013-09-29 12:29:03 UTC
Created attachment 86796 [details]
Screenshot (Ubuntu 13.10)

Steps to reproduce:
1. Make sure you have Galaxy icon theme installed.
2. Go to Tools->Options...->LibreOffice->View
3. Open Icon style drop-down box

As you can see the Galaxy theme has a '(default)' notation. The problem is that it's never the case:
- On Windows, MacOS & Gnome the default theme is 'Tango'
- On Unity it's 'Human'
- On KDE it's 'Oxygen'

Expected results: Assign the '(default)' notation correctly, or remove it completely.
Comment 1 Jorendc 2013-10-13 22:19:40 UTC
Thanks for reporting!

I can confirm this using Mac OSX 10.8.5 with LibreOffice 4.1.2.3 where the default theme is indeed Tango. Probably just a hard-coded string. Will try to hunt that down.

Kind regards,
Joren
Comment 2 Jorendc 2013-10-13 22:22:20 UTC
As I thought, just a hard-coded string: http://opengrok.libreoffice.org/xref/core/cui/uiconfig/ui/optviewpage.ui#135

I'll send a patch tomorrow. We can safely delete the word 'default' because now the default theme is marked as "Automatic(<name of default theme>)".

Kind regards,
Joren
Comment 3 Jorendc 2013-10-18 16:12:23 UTC
Patch waiting for review: https://gerrit.libreoffice.org/#/c/6321/

Kind regards,
Joren
Comment 4 Commit Notification 2013-10-23 10:25:49 UTC
Joren De Cuyper committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=99ba2fd24fcfc086353221d78ae64ffe159db3d6

Solve fdo#69926 Wrong default notation for galaxy icon theme



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.