When you open a save as dialog by default the name of the file is highlighted (which is good as it's assumed that if you're saving as you want to change the name) but the algorithm that detects the file name is wrong as it looks for the first period in the file vs. the last. Steps: Open writer Save as "this vs. that" without the quotes Save as again Observed: "This vs." is highlighted Expected "This vs. That" is highlighted (up to the . of .odt) Marking as: Minor -- doesn't prevent high quality work but can slow down workflow a bit Low -- easy work around, default of low seems accurate Probably an easy hack so marking as such
I do not reproduce it under Win7 64bit with 4.1.4.2 and 4.2.1.0.0+ Build ID: 88cd9632e081f5839cf9fddf60cbff0c099e2968 TinderBox: Win-x86@42, Branch:libreoffice-4-2, Time: 2014-01-09_22:46:56
Interesting - so for you it highlights the whole name all the way up until the .odt? If this is Linux only that would be really surprising but I suppose you never know
Created attachment 92801 [details] save dialog Win7 @Joel this is what I see anymetime I resave. the whole filename and extension as well are highlighted. post yours to show me the difference.
and for me - under Ubuntu - there is never anything selected with "File save as"
Wow looks like linux only
Created attachment 92821 [details] FileNameInUbuntu
@Cor - I don't use LibreOffice dialogs. When I turn those on nothing is selected (another bug report I suppose, or at least an enhancement request)
I can confirm this behaviour under Linux (Ubuntu) with system dialogs.
Indeed Linux only. Can't reproduce using Mac OSX. Full filename is selected
I wish to work on this bug, can someone provide with a little bit of help? :) Regards, Rachit Gupta
@Rachit - fantastic. I just want to confirm you've already built LibreOffice ? I will try to find someone to give some code pointers but if you haven't already built we'll need you to start there :) Let me know if you need assistance
Hmm =) so this could be at the intersection of what the gtk+ file selector does magically for you, and what we do. AFAIK we don't put the extension into the file-picker there but append it ourselves; of course if the user adds one that is fine; lets hope '. that' is not a filter name ;-) if you want to save as: foo.doc.doc you will not be able to enter 'foo.doc' - you have to enter it in full; Anyhow - Rachit - you'd want to git grep for the gtk file selector API: git grep -3 gtk_file_chooser will show you where that is =)
@Joel, yes i have built LO, I have already solved an EasyHack task ;) @Joel and @Michael, I think the problem is only in the systems with GTK as their Desktop Environment. My friend uses Kubuntu, and there is no highlight on the file name (as also mentioned in Comment#4).
In order to limit the confusion between ProposedEasyHack and EasyHack and to make queries much easier we are changing ProposedEasyHack to NeedsDevEval. Thank you and apologies for the noise
Rachit Gupta committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=55eb86699d7d4b2151530e9a0b3ca2e99033595b fdo#74064 The filename gets properly highlighted in the Save As dialog. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
@Rachit - thanks! Going to test it out as soon as I can get this build done
Verified :)
Thanks Joel :)
This change causes regression I just noticed. Filed Bug 76466.
Judging by the situation, perhaps this bug should have been fixed on the GTK3 side?
Kohei Yoshida committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=9dc4377c91b00585519abfd4fc1528393fe84e4a Revert "fdo#74064 The filename gets properly highlighted in the Save As dialog." The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Sorry. I have to conclude that this is not a right fix. Simply ignoring our auto extension flag for the GTK dialog has other consequences. I would still explore the avenue that perhaps this is a bug in the GTK file picker itself, not ours.
(In reply to comment #22) > Sorry. I have to conclude that this is not a right fix. Simply ignoring > our auto extension flag for the GTK dialog has other consequences. > > I would still explore the avenue that perhaps this is a bug in the GTK file > picker itself, not ours. Either that, or perhaps look into whether or not we can control selection of file name in the GTK file chooser dialog, and try to fix this there if that's the case.
No problems. If this was not the right fix, it's good that it is reverted. I'll try to work on the right fix :)
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.