Bug 80038 - Other: Trying to open incompatible file types results in a crash
Summary: Other: Trying to open incompatible file types results in a crash
Status: NEEDINFO
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Libreoffice (show other bugs)
Version: 4.3.0.0.beta2
Hardware: Other Windows (All)
: medium normal
Assignee: Not Assigned
QA Contact:
URL:
Whiteboard: BSA
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-14 23:19 UTC by Fabian Alexander Wilms
Modified: 2014-09-27 20:03 UTC (History)
2 users (show)

See Also:
i915 platform:
i915 features:


Attachments

Description Fabian Alexander Wilms 2014-06-14 23:19:18 UTC
Problem description: 
Trying to open e.g. an exe file should result in a warning message, not a crash.

Steps to reproduce:
1. Drag e.g. exe file onto LibreOffice icon

Current behavior:
LibreOffice crashes

Expected behavior:
It should show a warning mesaage, like GIMP.
Operating System: Windows 7
Version: 4.3.0.0.beta2
Comment 1 Maxim Monastirsky 2014-06-15 09:35:19 UTC
I'm not able to reproduce the crash with %WINDIR%\notepad.exe. Maybe this is reproducible only with a specific exe file?
Comment 3 Maxim Monastirsky 2014-06-15 14:04:16 UTC
(In reply to comment #2)
> I tried it with
> http://portableapps.com/redirect/
> ?a=LibreOfficePortable&t=http%3A%2F%2Fdownload.documentfoundation.
> org%2Flibreoffice%2Fportable%2F4.2.4%2FLibreOfficePortable_4.2.
> 4_MultilingualNormal.paf.exe
It doesn't crash for me, but tries to open the file for a very long time with a constant 50% CPU usage. I killed the process after ~1.5 hours with ~400MB RAM usage.

Given that any unknown file type is forced to open in Writer with the ascii filter [1], I can guess why this happens. Not only it's a big file (117MB), the filter will treat special symbols like carriage return or form feed. Even notepad.exe (176KB on my system), opens with 666 pages. Now imagine what could be the results of opening your file.

[1] http://opengrok.libreoffice.org/xref/core/filter/source/textfilterdetect/filterdetect.cxx#162
Comment 4 Caolán McNamara 2014-09-27 20:03:11 UTC
Its possible that the crash was in icu and is resolved with one or more of the three commits of

1f39f4466f334165d85d1ed8cccf33ff14f91434
3259d56baf99956ed6576919c7b0abd9203de41d
b68d4b14c0ff336318602310dd987ced737b4213


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.