Bug 84168 - change writerperfect filters to use a new base class template
Summary: change writerperfect filters to use a new base class template
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: filters and storage (show other bugs)
Version: unspecified
Hardware: Other All
: medium normal
Assignee: Not Assigned
QA Contact:
URL:
Whiteboard: EasyHack DifficultyBeginner SkillCpp ...
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-22 07:46 UTC by David Tardon
Modified: 2014-10-22 11:01 UTC (History)
0 users

See Also:
i915 platform:
i915 features:


Attachments

Description David Tardon 2014-09-22 07:46:21 UTC
Most of the import filter services in writerperfect are derived from a base class called ImportFilterBase, that implements boilerplate code common for all the filters. However, there are separate implementations of ImportFilterBase in every submodule, i.e., writerperfect/source/draw, writerperfect/source/writer (there used to be one in writerperfect/source/calc too). To avoid duplication, this class has been generalized to a template writerperfect::ImportFilter (writerperfect/inc/writerperfect/ImportFilter.hxx). The goal is to replace use of writerperfect::*::ImportFilterBase by writerperfect::ImportFilter.

Commit https://gerrit.libreoffice.org/gitweb?p=core.git;a=commit;h=a23a51af899b31bcf93781637371ffd8ef813bf5 shows a sample conversion of the filters in writerperfect/source/calc.
Comment 1 David Tardon 2014-10-22 11:01:46 UTC
writerperfect/source/impress should be adapted too


Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.