Bug 100022

Summary:

[IGT] [BXT/CHT]WARNING at drivers/gpu/drm/i915/intel_display.c:13881 intel_get_pipe_from_connector

Product:

DRI

Reporter:

Rami <ramix.ben.hassine>

Component:

DRM/Intel

Assignee:

Luis Botello <luis.botello.ortega>

Status:

CLOSED FIXED

QA Contact:

Intel GFX Bugs mailing list <intel-gfx-bugs>

Severity:

normal

Priority:

medium

CC:

bugs, intel-gfx-bugs

Version:

unspecified

Hardware:

x86-64 (AMD64)

OS:

Linux (All)

Whiteboard:

PatchMerged

i915 platform:

ALL

i915 features:

display/atomic

Attachments:

Description	Flags
dmesg	none

Description Rami 2017-03-01 16:01:24 UTC

Created attachment 130002 [details]
dmesg

when runing igt test on BXT we get thi warning

Setup:
Platform BXT-P: APL system
CPU Name : Intel(R) Genuine Processor @ 1.1 GHz (family: 6, model: 12, stepping: 9) 4 cores
QDF : Q6HE
SoC : B1
CRB : Apollo Lake DDR3L RVP1A FAB2
Reworks: R19, R20

Software 
Bios: 144_B10 APLK_B0_IFWI_X64_R_2016_06_27_0956_SPI_RVP1.bin from \\gar\ec\proj\ba\CCG\APL BIOS\External\BIOS_Release\Daily\v144_10_2016_WW27.1\IFWI\IFWI_RVP1_Release\IFWI
KSC: 1.15
Linux distribution: Ubuntu 16.04 64 bits
DMC 1.07
GuC 8.7
kernel:'drm-tip: 2017y-02m-28d-16h-27m-13s UTC integration manifest'
   commit: 5d37006b578e38562382215e8782cfced9c992ce
   author: Gerd Hoffmann <kraxel@redhat.com>
   authored_date: Tue Feb 28 16:31:58 2017 +0000
drm:libdrm-2.4.75-10-gf6499b1 from git://git.freedesktop.org/git/mesa/drm
waffle: 1.5.2-3-202-g03d5566
intel-gpu-tool:intel-gpu-tools-1.17-261-g8f3164f from https://cgit.freedesktop.org/xorg/app/intel-gpu-tools

Steps:
======
kms_cursor_legacy --run-subtest long-nonblocking-modeset-vs-cursor-atomic

Comment 1 Chris Wilson 2017-03-01 16:19:30 UTC

[  219.968336] [drm:intel_enable_pipe [i915]] enabling pipe A
[  219.968423] [drm:intel_edp_backlight_on.part.22 [i915]]
[  219.968428] ------------[ cut here ]------------
[  219.968481] WARNING: CPU: 3 PID: 2457 at drivers/gpu/drm/i915/intel_display.c:13881 intel_get_pipe_from_connector+0x62/0x90 [i915]
[  219.968483] WARN_ON(!drm_modeset_is_locked(&dev->mode_config.connection_mutex))
[  219.968485] Modules linked in: nls_iso8859_1 snd_hda_codec_hdmi snd_hda_codec_realtek snd_hda_codec_generic snd_hda_intel snd_hda_codec snd_hda_core snd_hwdep snd_pcm intel_rapl x86_pkg_temp_thermal coretemp kvm_intel snd_seq_midi snd_seq_midi_event kvm snd_rawmidi irqbypass crct10dif_pclmul crc32_pclmul ghash_clmulni_intel pcbc snd_seq snd_seq_device serio_raw snd_timer aesni_intel aes_x86_64 crypto_simd glue_helper cryptd lpc_ich snd mei_me shpchp soundcore mei rfkill_gpio mac_hid intel_pmc_ipc parport_pc ppdev lp parport ip_tables x_tables autofs4 hid_generic usbhid igb ahci i915 xhci_pci dca xhci_hcd ptp sdhci_pci sdhci libahci pps_core i2c_hid hid video
[  219.968573] CPU: 3 PID: 2457 Comm: kworker/u8:3 Tainted: G        W       4.10.0-tip-201703010159+ #2
[  219.968575] Hardware name: Intel Corp. Broxton P/NOTEBOOK, BIOS APLKRVPA.X64.0144.B10.1606270006 06/27/2016
[  219.968627] Workqueue: events_unbound intel_atomic_commit_work [i915]
[  219.968629] Call Trace:
[  219.968640]  dump_stack+0x63/0x87
[  219.968646]  __warn+0xd1/0xf0
[  219.968651]  warn_slowpath_fmt+0x4f/0x60
[  219.968657]  ? drm_printk+0x97/0xa0
[  219.968708]  intel_get_pipe_from_connector+0x62/0x90 [i915]
[  219.968756]  intel_panel_enable_backlight+0x19/0xf0 [i915]
[  219.968804]  intel_edp_backlight_on.part.22+0x33/0x40 [i915]
[  219.968852]  intel_edp_backlight_on+0x18/0x20 [i915]
[  219.968900]  intel_enable_ddi+0x94/0xc0 [i915]
[  219.968950]  intel_encoders_enable.isra.93+0x77/0x90 [i915]
[  219.969000]  haswell_crtc_enable+0x310/0x7f0 [i915]
[  219.969051]  intel_update_crtc+0x58/0x100 [i915]
[  219.969101]  skl_update_crtcs+0x218/0x240 [i915]
[  219.969153]  intel_atomic_commit_tail+0x350/0x1000 [i915]
[  219.969159]  ? vtime_account_idle+0xe/0x50
[  219.969164]  ? finish_task_switch+0x107/0x250
[  219.969214]  intel_atomic_commit_work+0x12/0x20 [i915]
[  219.969219]  process_one_work+0x153/0x3f0
[  219.969223]  worker_thread+0x12b/0x4b0
[  219.969227]  kthread+0x101/0x140
[  219.969230]  ? rescuer_thread+0x340/0x340
[  219.969233]  ? kthread_park+0x90/0x90
[  219.969237]  ? do_syscall_64+0x6e/0x180
[  219.969243]  ret_from_fork+0x2c/0x40
[  219.969246] ---[ end trace 0a8fa19387b9ad6d ]---
[  219.969295] [drm:intel_panel_enable_backlight [i915]] pipe A

Comment 2 Ville Syrjala 2017-03-08 18:53:15 UTC

Can happen on many platforms. Just saw it on VLV. Seems to be due to the lockless commit atomic is doing.

Comment 3 yann 2017-03-09 10:16:31 UTC

(In reply to Ville Syrjala from comment #2)
> Can happen on many platforms. Just saw it on VLV. Seems to be due to the
> lockless commit atomic is doing.

updating i915 platform to ALL to reflect this comment

Comment 4 Rami 2017-03-21 13:21:30 UTC

Test now pass on SKL with last setup:
setup:
=========
Platform SKL Gigabyte
CPU: Intel(R) Core(TM) i5-6600 CPU @ 3.30GHz (family 6, model 94, stepping 3)
GPU: Intel® HD Graphics 530 - Intel Corporation Sky Lake Integrated Graphics
(rev 06)
Motherboard version: H170N-WIFI-CF
Memory: 2x 4GB Kingston 9905622-055.A00G

Software
===========
Bios: F3
Linux distribution: Ubuntu 16.04 64 bits
DMC 1.26 from https://01.org/sites/default/files/downloads/intelr-graphics-linux/skldmcver126.tar_1.bz2
GUC 6.1 from https://01.org/sites/default/files/downloads/intelr-graphics-linux/sklgucver61.tar.bz2
kernel:drm-tip: 2017y-03m-15d-21h-47m-56s UTC integration manifest
  commit: d7cb114e1327b50c609ee6e67122cc0293ea515f
  author: Chris Wilson <chris@chris-wilson.co.uk>
  authored_date: Wed Mar 15 21:48:18 2017 +0000
drm:libdrm-2.4.75-14-g19c4cfc from  git://git.freedesktop.org/git/mesa/drm=
mesa:mesa-17.0.0 from git://git.freedesktop.org/git/mesa/mesa
cairo:1.15.4 from  git://anongit.freedesktop.org/cairo
xorg-server-macros:util-macros-1.19.1-2-g39f07f7 from   git://git.freedesktop.org/git/xorg/util/macros
xserver:xorg-server-1.19.0-133-g386fbbe from git://git.freedesktop.org/git/xorg/xserver
xf86-video-intel: 2.99.917-766-gbe913a3 from git://git.freedesktop.org/git/xorg/driver/xf86-video-intel
libva: libva-1.7.3.pre1-85-gefc164d
vaapi-intel-driver:1.7.3-343-gef83d40 
waffle:debian/1.5.2-3-202-g03d5566
intel-gpu-tool:intel-gpu-tools-1.17-291-g90c883c

Comment 5 Rami 2017-03-21 13:23:44 UTC

Reproduced on BXT with last setup:
Setup:
Platform BXT-P: APL system
CPU Name : Intel(R) Genuine Processor @ 1.1 GHz (family: 6, model: 12, stepping: 9) 4 cores
QDF : Q6HE
SoC : B1
CRB : Apollo Lake DDR3L RVP1A FAB2
Reworks: R19, R20

Software 
Bios: 144_B10 APLK_B0_IFWI_X64_R_2016_06_27_0956_SPI_RVP1.bin from \\gar\ec\proj\ba\CCG\APL BIOS\External\BIOS_Release\Daily\v144_10_2016_WW27.1\IFWI\IFWI_RVP1_Release\IFWI
KSC: 1.15
Linux distribution: Ubuntu 16.04 64 bits
DMC 1.07
GuC 8.7
kernel: 'drm-tip: 2017y-03m-12d-13h-00m-05s UTC integration manifest'
   commit: 2cb12884655eab41d4992b33ccb36c609c4537d3
   author: Chris Wilson <chris@chris-wilson.co.uk>
   authored_date: Sun Mar 12 13:00:53 2017 +0000
drm:libdrm-2.4.75-14-g19c4cfc from git://git.freedesktop.org/git/mesa/drm
waffle: debian/1.5.2-3-202-g03d5566
intel-gpu-tool:intel-gpu-tools-1.17-291-g90c883c from https://cgit.freedesktop.org/xorg/app/intel-gpu-tools

Comment 6 Jani Saarinen 2017-06-08 06:13:18 UTC

Imre can reproduce, but needs time to root cause.

Comment 7 Maarten Lankhorst 2017-06-08 13:19:50 UTC

Does this branch fix the issues?

https://cgit.freedesktop.org/~mlankhorst/linux/log/?h=backlight-state-fixes

Comment 8 Maarten Lankhorst 2017-06-08 13:21:36 UTC

Testcase is probably kms_cursor_legacy *nonblocking-modeset-* and kms_atomic_transitions *-nonblocking*

Comment 9 Imre Deak 2017-06-09 12:23:55 UTC

(In reply to Maarten Lankhorst from comment #7)
> Does this branch fix the issues?
> 
> https://cgit.freedesktop.org/~mlankhorst/linux/log/?h=backlight-state-fixes

(In reply to Maarten Lankhorst from comment #8)
> Testcase is probably kms_cursor_legacy *nonblocking-modeset-* and
> kms_atomic_transitions *-nonblocking*

With the 3 patches from the above branch on top of drm-tip I can't see any WARNs from any of the above testcases. Without the patches the WARN in comment#1 still triggers.

I still get the following errors both with and without patches, I assume these are a separate issue:

# intel-gpu-tools/tests/kms_cursor_legacy --run-subtest=2x-nonblocking-modeset-vs-cursor-atomic
IGT-Version: 1.18-gb087257 (x86_64) (Linux: 4.12.0-rc4+ x86_64)
(kms_cursor_legacy:1651) CRITICAL: Test assertion failure function two_screens_flip_vs_cursor, file kms_cursor_legacy.c:1018:
(kms_cursor_legacy:1651) CRITICAL: Failed assertion: get_vblank(display->drm_fd, pipe, 0) == vblank_start
(kms_cursor_legacy:1651) CRITICAL: Last errno: 9, Bad file descriptor
(kms_cursor_legacy:1651) CRITICAL: error: 18392 != 18391
Stack trace:
  #0 [__igt_fail_assert+0x101]
  #1 [two_screens_flip_vs_cursor+0x6cd]
  #2 [<unknown>+0x6cd]
Subtest 2x-nonblocking-modeset-vs-cursor-atomic failed.
**** DEBUG ****
    populating plane data: A.0, fb 72
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     src = (0, 0) 1920 x 1080 dst = (0, 0) 1920 x 1080
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     populating plane data: A.1, fb 0
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     populating plane data: A.2, fb 0
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     populating plane data: A.3, fb 91
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     src = (0, 0) 64 x 64 dst = (0, 0) 64 x 64
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     B: Setting mode 1920x1200 from DP-2
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     populating plane data: B.0, fb 90
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     src = (0, 0) 1920 x 1200 dst = (0, 0) 1920 x 1200
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     populating plane data: B.1, fb 0
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     populating plane data: B.2, fb 0
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     populating plane data: B.3, fb 91
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     src = (0, 0) 64 x 64 dst = (0, 0) 64 x 64
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     C: Setting NULL mode
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     populating plane data: C.0, fb 0
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     populating plane data: C.1, fb 0
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     populating plane data: C.2, fb 0
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     eDP-1: preparing atomic, pipe: A
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     DP-1: preparing atomic, pipe: None
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     DP-2: preparing atomic, pipe: B
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     HDMI-A-1: preparing atomic, pipe: None
(kms_cursor_legacy:1651) igt-kms-DEBUG: display: }
(kms_cursor_legacy:1651) igt-kms-DEBUG: display: commit {
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     A: Setting mode 1920x1080 from eDP-1
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     populating plane data: A.0, fb 72
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     src = (0, 0) 1920 x 1080 dst = (0, 0) 1920 x 1080
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     populating plane data: A.1, fb 0
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     populating plane data: A.2, fb 0
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     populating plane data: A.3, fb 91
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     src = (0, 0) 64 x 64 dst = (0, 0) 64 x 64
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     B: Setting mode 1920x1200 from DP-2
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     populating plane data: B.0, fb 90
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     src = (0, 0) 1920 x 1200 dst = (0, 0) 1920 x 1200
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     populating plane data: B.1, fb 0
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     populating plane data: B.2, fb 0
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     populating plane data: B.3, fb 91
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     src = (0, 0) 64 x 64 dst = (0, 0) 64 x 64
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     C: Setting NULL mode
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     populating plane data: C.0, fb 0
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     populating plane data: C.1, fb 0
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     populating plane data: C.2, fb 0
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     eDP-1: preparing atomic, pipe: A
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     DP-1: preparing atomic, pipe: None
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     DP-2: preparing atomic, pipe: B
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     HDMI-A-1: preparing atomic, pipe: None
(kms_cursor_legacy:1651) igt-kms-DEBUG: display: }
(kms_cursor_legacy:1651) igt-kms-DEBUG: display: commit {
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     A: Setting mode 1920x1080 from eDP-1
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     populating plane data: A.0, fb 72
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     populating plane data: A.1, fb 0
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     populating plane data: A.2, fb 0
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     populating plane data: A.3, fb 91
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     B: Setting mode 1920x1200 from DP-2
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     populating plane data: B.0, fb 90
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     populating plane data: B.1, fb 0
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     populating plane data: B.2, fb 0
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     populating plane data: B.3, fb 91
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     C: Setting NULL mode
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     populating plane data: C.0, fb 0
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     populating plane data: C.1, fb 0
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     populating plane data: C.2, fb 0
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     eDP-1: preparing atomic, pipe: A
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     DP-1: preparing atomic, pipe: None
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     DP-2: preparing atomic, pipe: B
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     HDMI-A-1: preparing atomic, pipe: None
(kms_cursor_legacy:1651) igt-kms-DEBUG: display: }
(kms_cursor_legacy:1651) igt-kms-DEBUG: display: A.0: plane_set_fb(72)
(kms_cursor_legacy:1651) igt-kms-DEBUG: display: DP-2: set_pipe(any)
(kms_cursor_legacy:1651) igt-kms-DEBUG: display: commit {
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     populating plane data: A.0, fb 72
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     src = (0, 0) 1920 x 1080 dst = (0, 0) 1920 x 1080
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     populating plane data: A.1, fb 0
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     populating plane data: A.2, fb 0
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     populating plane data: A.3, fb 91
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     B: Setting NULL mode
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     populating plane data: B.0, fb 90
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     populating plane data: B.1, fb 0
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     populating plane data: B.2, fb 0
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     populating plane data: B.3, fb 91
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     populating plane data: C.0, fb 0
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     populating plane data: C.1, fb 0
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     populating plane data: C.2, fb 0
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     eDP-1: preparing atomic, pipe: A
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     DP-1: preparing atomic, pipe: None
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     DP-2: preparing atomic, pipe: None
(kms_cursor_legacy:1651) igt-kms-DEBUG: display:     HDMI-A-1: preparing atomic, pipe: None
(kms_cursor_legacy:1651) igt-kms-DEBUG: display: }
(kms_cursor_legacy:1651) CRITICAL: Test assertion failure function two_screens_flip_vs_cursor, file kms_cursor_legacy.c:1018:
(kms_cursor_legacy:1651) CRITICAL: Failed assertion: get_vblank(display->drm_fd, pipe, 0) == vblank_start
(kms_cursor_legacy:1651) CRITICAL: Last errno: 9, Bad file descriptor
(kms_cursor_legacy:1651) CRITICAL: error: 18392 != 18391
****  END  ****
Subtest 2x-nonblocking-modeset-vs-cursor-atomic: FAIL (0.192s)

# intel-gpu-tools/tests/kms_cursor_legacy --run-subtest=2x-long-nonblocking-modeset-vs-cursor-atomic
IGT-Version: 1.18-gb087257 (x86_64) (Linux: 4.12.0-rc4+ x86_64)
(kms_cursor_legacy:1656) CRITICAL: Test assertion failure function two_screens_flip_vs_cursor, file kms_cursor_legacy.c:1018:
(kms_cursor_legacy:1656) CRITICAL: Failed assertion: get_vblank(display->drm_fd, pipe, 0) == vblank_start
(kms_cursor_legacy:1656) CRITICAL: Last errno: 9, Bad file descriptor
(kms_cursor_legacy:1656) CRITICAL: error: 20183 != 20182
Stack trace:
  #0 [__igt_fail_assert+0x101]
  #1 [two_screens_flip_vs_cursor+0x6cd]
  #2 [<unknown>+0x6cd]
Subtest 2x-long-nonblocking-modeset-vs-cursor-atomic failed.
**** DEBUG ****
    populating plane data: A.0, fb 71
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     src = (0, 0) 1920 x 1080 dst = (0, 0) 1920 x 1080
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     populating plane data: A.1, fb 0
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     populating plane data: A.2, fb 0
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     populating plane data: A.3, fb 91
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     src = (0, 0) 64 x 64 dst = (0, 0) 64 x 64
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     B: Setting mode 1920x1200 from DP-2
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     populating plane data: B.0, fb 89
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     src = (0, 0) 1920 x 1200 dst = (0, 0) 1920 x 1200
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     populating plane data: B.1, fb 0
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     populating plane data: B.2, fb 0
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     populating plane data: B.3, fb 91
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     src = (0, 0) 64 x 64 dst = (0, 0) 64 x 64
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     C: Setting NULL mode
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     populating plane data: C.0, fb 0
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     populating plane data: C.1, fb 0
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     populating plane data: C.2, fb 0
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     eDP-1: preparing atomic, pipe: A
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     DP-1: preparing atomic, pipe: None
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     DP-2: preparing atomic, pipe: B
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     HDMI-A-1: preparing atomic, pipe: None
(kms_cursor_legacy:1656) igt-kms-DEBUG: display: }
(kms_cursor_legacy:1656) igt-kms-DEBUG: display: commit {
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     A: Setting mode 1920x1080 from eDP-1
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     populating plane data: A.0, fb 71
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     src = (0, 0) 1920 x 1080 dst = (0, 0) 1920 x 1080
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     populating plane data: A.1, fb 0
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     populating plane data: A.2, fb 0
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     populating plane data: A.3, fb 91
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     src = (0, 0) 64 x 64 dst = (0, 0) 64 x 64
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     B: Setting mode 1920x1200 from DP-2
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     populating plane data: B.0, fb 89
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     src = (0, 0) 1920 x 1200 dst = (0, 0) 1920 x 1200
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     populating plane data: B.1, fb 0
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     populating plane data: B.2, fb 0
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     populating plane data: B.3, fb 91
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     src = (0, 0) 64 x 64 dst = (0, 0) 64 x 64
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     C: Setting NULL mode
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     populating plane data: C.0, fb 0
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     populating plane data: C.1, fb 0
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     populating plane data: C.2, fb 0
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     eDP-1: preparing atomic, pipe: A
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     DP-1: preparing atomic, pipe: None
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     DP-2: preparing atomic, pipe: B
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     HDMI-A-1: preparing atomic, pipe: None
(kms_cursor_legacy:1656) igt-kms-DEBUG: display: }
(kms_cursor_legacy:1656) igt-kms-DEBUG: display: commit {
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     A: Setting mode 1920x1080 from eDP-1
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     populating plane data: A.0, fb 71
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     populating plane data: A.1, fb 0
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     populating plane data: A.2, fb 0
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     populating plane data: A.3, fb 91
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     B: Setting mode 1920x1200 from DP-2
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     populating plane data: B.0, fb 89
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     populating plane data: B.1, fb 0
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     populating plane data: B.2, fb 0
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     populating plane data: B.3, fb 91
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     C: Setting NULL mode
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     populating plane data: C.0, fb 0
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     populating plane data: C.1, fb 0
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     populating plane data: C.2, fb 0
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     eDP-1: preparing atomic, pipe: A
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     DP-1: preparing atomic, pipe: None
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     DP-2: preparing atomic, pipe: B
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     HDMI-A-1: preparing atomic, pipe: None
(kms_cursor_legacy:1656) igt-kms-DEBUG: display: }
(kms_cursor_legacy:1656) igt-kms-DEBUG: display: A.0: plane_set_fb(71)
(kms_cursor_legacy:1656) igt-kms-DEBUG: display: DP-2: set_pipe(any)
(kms_cursor_legacy:1656) igt-kms-DEBUG: display: commit {
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     populating plane data: A.0, fb 71
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     src = (0, 0) 1920 x 1080 dst = (0, 0) 1920 x 1080
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     populating plane data: A.1, fb 0
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     populating plane data: A.2, fb 0
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     populating plane data: A.3, fb 91
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     B: Setting NULL mode
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     populating plane data: B.0, fb 89
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     populating plane data: B.1, fb 0
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     populating plane data: B.2, fb 0
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     populating plane data: B.3, fb 91
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     populating plane data: C.0, fb 0
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     populating plane data: C.1, fb 0
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     populating plane data: C.2, fb 0
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     eDP-1: preparing atomic, pipe: A
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     DP-1: preparing atomic, pipe: None
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     DP-2: preparing atomic, pipe: None
(kms_cursor_legacy:1656) igt-kms-DEBUG: display:     HDMI-A-1: preparing atomic, pipe: None
(kms_cursor_legacy:1656) igt-kms-DEBUG: display: }
(kms_cursor_legacy:1656) CRITICAL: Test assertion failure function two_screens_flip_vs_cursor, file kms_cursor_legacy.c:1018:
(kms_cursor_legacy:1656) CRITICAL: Failed assertion: get_vblank(display->drm_fd, pipe, 0) == vblank_start
(kms_cursor_legacy:1656) CRITICAL: Last errno: 9, Bad file descriptor
(kms_cursor_legacy:1656) CRITICAL: error: 20183 != 20182
****  END  ****
Subtest 2x-long-nonblocking-modeset-vs-cursor-atomic: FAIL (0.180s)

Comment 10 Ricardo 2017-06-09 19:06:56 UTC

Please Luis help us to retest this bug

Comment 11 Maarten Lankhorst 2017-06-12 08:00:30 UTC

Excellent, I would like some more extended testing since it affects all platforms with backlight support, but if that happens I'll send the patches to the ML.

Comment 12 Maarten Lankhorst 2017-06-12 14:02:01 UTC

pm_backlight.basic-brightness seems to be run by nightly, so all our infrastructure is testing it. :)

Comment 13 Maarten Lankhorst 2017-06-12 14:27:37 UTC

Seems CI is testing pm_backlight, so tests have run..

Fixed as of

commit 7d025e0804f2cbeafeba2f5b8effa6361d7db8e4
Author: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Date:   Mon Jun 12 12:21:15 2017 +0200

    drm/i915: Pass atomic state to backlight enable/disable/set callbacks.

and the 2 commits before it.

Comment 14 Ricardo Madrigal 2017-07-05 19:29:25 UTC

Works fine with the following configuration on BXT, GLK, KBL, SKL, BDW, BSW, HSW IVB and BYT.

This is my Configuration:

======================================
                 Kernel
======================================
commit df0182c2c95385492772c6e4ace76b463298b8ca
Author:     Jani Nikula <jani.nikula@intel.com>
AuthorDate: Mon Jul 3 16:20:53 2017 +0300
Commit:     Jani Nikula <jani.nikula@intel.com>
CommitDate: Mon Jul 3 16:20:53 2017 +0300

drm-tip: 2017y-07m-03d-13h-20m-24s UTC integration manifest


======================================
        Graphic drivers
======================================
Component: drm
    tag: libdrm-2.4.81-24-g3095cc8
    commit: 3095cc8eaba1aa87ad38c04ae2b1eabe30f7e16c

Component: cairo
    tag: 1.15.6-2-g57b4050
    commit: 57b40507dda3f58dfc8635548d606b86dc7bcf51

Component: intel-gpu-tools
    tag: intel-gpu-tools-1.19-57-g6fcc8e8
    commit: 6fcc8e8b247661c7950b998e0b95141ffbd6b833

Component: piglit
    tag: piglit-v1
    commit: c8f4fd9eeb298a2ef0855927f22634f794ef3eff
==========================================

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.