Bug 100221

Summary: [SKL] Resume from suspend to disk fails - bisected
Product: DRI Reporter: Damian Martinez Dreyer <le.trmr>
Component: DRM/IntelAssignee: Intel GFX Bugs mailing list <intel-gfx-bugs>
Status: CLOSED FIXED QA Contact: Intel GFX Bugs mailing list <intel-gfx-bugs>
Severity: critical    
Priority: highest CC: intel-gfx-bugs, le.trmr, rafael.ristovski
Version: XOrg gitKeywords: bisected, regression
Hardware: x86-64 (AMD64)   
OS: Linux (All)   
Whiteboard: ReadyForDev
i915 platform: SKL i915 features: GEM/execlists
Attachments:
Description Flags
System info
none
bisect history
none
intel-reg dump pre-suspend
none
intel-reg dump post-suspend
none
dmesg pre-suspend
none
dmesg post-suspend none

Description Damian Martinez Dreyer 2017-03-15 21:50:38 UTC
Created attachment 130240 [details]
System info

Description: I have bisected Kernel 4.9.9 and determined the following to be the cause:

commit f2a0409a08502d64fbe3990354dff5902b08d2fb
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Wed Sep 21 14:51:08 2016 +0100

    drm/i915/execlists: Reset RING registers upon resume
    
    commit bafb2f7d4755bf1571bd5e9a03b97f3fc4fe69ae upstream.

Kernel 4.10 does show the same behaviour.

Please also see the bisect history on github [1] and this forum thread [2].
[1] https://github.com/kxv/linux49.9
[2] https://forum.manjaro.org/t/linux-4-9-9-breaks-hibernation-4-9-8-works/17499


Expected behaviour: Resuming from suspend to disk normally by displaying lock screen.

Actual behaviour: System powers on but resumes to a black screen.
Comment 1 Damian Martinez Dreyer 2017-03-15 21:52:37 UTC
Created attachment 130241 [details]
bisect history
Comment 2 Damian Martinez Dreyer 2017-03-15 22:46:36 UTC
Created attachment 130242 [details]
intel-reg dump pre-suspend
Comment 3 Damian Martinez Dreyer 2017-03-15 22:47:06 UTC
Created attachment 130243 [details]
intel-reg dump post-suspend
Comment 4 Damian Martinez Dreyer 2017-03-15 22:48:55 UTC
Created attachment 130244 [details]
dmesg pre-suspend
Comment 5 Damian Martinez Dreyer 2017-03-15 22:50:00 UTC
Created attachment 130245 [details]
dmesg post-suspend
Comment 6 Chris Wilson 2017-03-20 08:24:30 UTC
This was not my my backport.
Comment 7 Jani Nikula 2017-03-20 14:40:21 UTC
(In reply to Damian Martinez Dreyer from comment #0)
>     commit bafb2f7d4755bf1571bd5e9a03b97f3fc4fe69ae upstream.
> 
> Kernel 4.10 does show the same behaviour.

Can you check commits bafb2f7d4755bf1571bd5e9a03b97f3fc4fe69ae and bafb2f7d4755bf1571bd5e9a03b97f3fc4fe69ae^ please, to see if the problem was introduced by the upstream commit in v4.10 for you.
Comment 8 Rafael Ristovski 2017-04-15 08:54:43 UTC
I am having the same issue in linux-next but the mentioned commits make no sense as I started experiencing this starting from next-20170407. For reference, everything was fine with next-20170324. 

Symptoms are exactly the same, system resumes to a black screen.
I can tell the display is receiving power as it changes to solid black (vs weird reflective black caused by unpowered LCD). Backlight is powered off as well.
I tried looking at all possible logs but there are no errors/warnings anywhere.

HW: 
Haswell Intel i7-4500U with HD 4400
Comment 9 Ricardo 2017-05-09 16:46:23 UTC
Adding tag into "Whiteboard" field - ReadyForDev
The bug still active
*Status is correct
*Platform is included
*Feature is included
*Priority and Severity correctly set
*Logs included
Comment 10 Jani Nikula 2017-05-30 11:58:18 UTC
(In reply to Damian Martinez Dreyer from comment #0)
> Description: I have bisected Kernel 4.9.9 and determined the following to be
> the cause:
> 
> commit f2a0409a08502d64fbe3990354dff5902b08d2fb
> Author: Chris Wilson <chris@chris-wilson.co.uk>
> Date:   Wed Sep 21 14:51:08 2016 +0100
> 
>     drm/i915/execlists: Reset RING registers upon resume
>     
>     commit bafb2f7d4755bf1571bd5e9a03b97f3fc4fe69ae upstream.

The stable backport has been reverted in v4.9.23 by

commit 0ee72d8f9b8e17b8e4ccfebc7a25cbc2d395cd6a
Author: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date:   Wed Apr 12 15:49:39 2017 +0200

    Revert "drm/i915/execlists: Reset RING registers upon resume"
    
    This reverts commit f2a0409a08502d64fbe3990354dff5902b08d2fb which is
    commit bafb2f7d4755bf1571bd5e9a03b97f3fc4fe69ae upstream.
    
    It was reported to have problems.
    
    Cc: Jani Nikula <jani.nikula@linux.intel.com>
    Cc: Chris Wilson <chris@chris-wilson.co.uk>
    Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
    Cc: Eric Blau <eblau1@gmail.com>
    Signed-off-by: Greg Kroah-Hartman gregkh@linuxfoundation.org

Thread http://mid.mail-archive.com/1489443835.5568.7.camel@mailbox.org has the details.

Damian, so you see the problem with v4.10 as well? Can you try bisecting between v4.9 and v4.10? (i.e. the main releases, not the point releases.) Alternatively, is this still an issue with v4.11 or v4.12-rc3?
Comment 11 Jani Nikula 2017-05-30 12:03:08 UTC
(In reply to Jani Nikula from comment #10)
> Damian, so you see the problem with v4.10 as well? Can you try bisecting
> between v4.9 and v4.10? (i.e. the main releases, not the point releases.)
> Alternatively, is this still an issue with v4.11 or v4.12-rc3?

The fast check would be to check the commits mentioned in comment #7.

Rafael, I'd still like to know if the commits make sense for Damian, i.e. did bafb2f7d4755 ("drm/i915/execlists: Reset RING registers upon resume") regress upstream. The backport of that caused the issue in v4.9.9.
Comment 12 Jani Nikula 2017-06-28 09:02:34 UTC
Timeout, closing.

The regressing commit has been reverted from stable. If the problem persists with upstream kernels, please file new bugs for them.
Comment 13 Damian Martinez Dreyer 2017-07-03 07:29:14 UTC
This did regress in 4.10 and 4.11.
Although 12 has shown no signs of the problem so far.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.