Bug 10033

Summary: DBus specification says that protocol version is 0, but it is 1
Product: dbus Reporter: Magnus Henoch <magnus.henoch+bfdo>
Component: coreAssignee: Havoc Pennington <hp>
Status: RESOLVED FIXED QA Contact: John (J5) Palmieri <johnp>
Severity: normal    
Priority: medium    
Version: unspecified   
Hardware: Other   
OS: NetBSD   
Whiteboard:
i915 platform: i915 features:
Attachments: Updates specification to say protocol version 1 instead of 0

Description Magnus Henoch 2007-02-19 14:51:16 UTC
The DBus specification in the CVS repository says that the protocol version field (the fourth byte of every DBus message) must be 0, but as far as I can see the code really expects it to be 1.
Comment 1 Kristoffer Lundén 2007-03-05 03:09:05 UTC
Created attachment 8979 [details] [review]
Updates specification to say protocol version 1 instead of 0

This patch just changes the protocol major version 0 to a 1 in the spec, bringing it in sync with the code.
Comment 2 Havoc Pennington 2007-03-06 11:30:41 UTC
Looks good. You could remove that FIXME too, since we didn't fix it for 1.0 we're sort of stuck with it.
Comment 3 Simon McVittie 2007-06-14 02:52:36 UTC
Applied in CVS HEAD, thanks. Havoc, do you want this merged to the 1.0 branch, or do we only care about the CVS HEAD version of the spec?

(The spec ought to be its own project rather than being part of libdbus, really... perhaps we could split it out before 1.2?)
Comment 4 Havoc Pennington 2007-06-14 07:29:32 UTC
I think HEAD only is fine, that's where I usually run update-dbus-docs.sh

I'd rather not split it out, I think it's easier to keep updated in the same module, and also not worth making distributions build and update a separate RPM for vs. sticking it in the docs package for dbus.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.