Summary: | test-render-to-file.cpp | ||
---|---|---|---|
Product: | poppler | Reporter: | Miroslav Tzonkov <atvservice> |
Component: | general | Assignee: | poppler-bugs <poppler-bugs> |
Status: | RESOLVED INVALID | QA Contact: | |
Severity: | trivial | ||
Priority: | medium | CC: | gwenael |
Version: | unspecified | ||
Hardware: | x86-64 (AMD64) | ||
OS: | Linux (All) | ||
Whiteboard: | |||
i915 platform: | i915 features: | ||
Attachments: | Patch for test-render-to-file.cpp for MacOS compilation |
Description
Miroslav Tzonkov
2017-04-04 11:41:18 UTC
This is still not the correct fix. Hi, I have bee dealing with this bug since a long time and was able to compile successfully on MacOS, replacing +#include <QtWidgets/QApplication> by +#include <QtGui/QApplication> (In reply to Albert Astals Cid from comment #1) > This is still not the correct fix. Sorry, a mistake in my previous answer, in file : qt5/tests/test-render-to-file.cpp : #include <QtCore/QDebug> #include <QtCore/QFile> -#include <QGuiApplication> -#include <QImage> +#include <QtGui/QGuiApplication> +#include <QtGui/QImage> (In reply to gwenael from comment #2) > Hi, > > I have bee dealing with this bug since a long time and was able to compile > successfully on MacOS, replacing > > +#include <QtWidgets/QApplication> > > by > > +#include <QtGui/QApplication> > > > (In reply to Albert Astals Cid from comment #1) > > This is still not the correct fix. Created attachment 134090 [details] [review] Patch for test-render-to-file.cpp for MacOS compilation What part of no, that's not needed and the problem is somewhere else you don't understand? The documentation for QImage *clearly* states that the header is #include <QImage> http://doc.qt.io/qt-5/qimage.html Could you please be a little bit less agressive ! For example in the header poppler-qt5.h we can see : #include <QtCore/QDateTime> and the Qt documentation *clearly* states that the header for QDateTime is #include <QDateTime> So can you please explain that to me, as I am just a fool and you understood everything ? http://doc.qt.io/qt-5/search-results.html?q=QDateTime (In reply to Albert Astals Cid from comment #5) > What part of no, that's not needed and the problem is somewhere else you > don't understand? > > The documentation for QImage *clearly* states that the header is > #include <QImage> > http://doc.qt.io/qt-5/qimage.html A juste thought that this place was a place of exchange and discussions and not a place for "I have understood ! You don't, so shut up !". (In reply to Albert Astals Cid from comment #5) > What part of no, that's not needed and the problem is somewhere else you > don't understand? > > The documentation for QImage *clearly* states that the header is > #include <QImage> > http://doc.qt.io/qt-5/qimage.html (In reply to Gwenaël Cléon from comment #6) > Could you please be a little bit less agressive ! > > For example in the header poppler-qt5.h we can see : > > #include <QtCore/QDateTime> > > and the Qt documentation *clearly* states that the header for QDateTime is > #include <QDateTime> I can change it if it makes you happier. > > So can you please explain that to me, as I am just a fool and you understood > everything ? Maybe? > http://doc.qt.io/qt-5/search-results.html?q=QDateTime Once upon a time Qt recommended to use the Module/Class include, then they realized it was a stupid idea because it mean if they changed Class from ModuleA to ModuleB things would stop compiling so stopped recommending the Module/Class include in favour to just Class include. But both are correct and work, if it doesn't work it means the build system is wrongly set and it needs to be fixed there, but people keep sending the wrong patch, and then they complain because i tell them the patch is wrong. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.