Bug 100579

Summary:	Missing form-factors in sink priorities
Product:	PulseAudio	Reporter:	Christian Kellner <gicmo>
Component:	core	Assignee:	pulseaudio-bugs
Status:	RESOLVED MOVED	QA Contact:	pulseaudio-bugs
Severity:	normal
Priority:	medium	CC:	lennart
Version:	unspecified
Hardware:	All
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	sink: Add portable form factor priority (450) sink: Add missing 'hifi' form factor to priorities

Description Christian Kellner 2017-04-05 12:17:40 UTC

Currently not all form-factors that are defined by bluetooth are taken
into accout when priorities are assigned. Missing are:
 - hansfree
 - portable
 - car
 - hifi
 - phone (might be a source only?)

If they are missing it means they don't get any contribution to the
priority from the form factor and will most likely be rated lower
then anything 'internal'.

Comment 1 Christian Kellner 2017-04-05 12:17:42 UTC

Created attachment 130689 [details] [review]
sink: Add portable form factor priority (450)

The 'portable' form factor was currently missing meaning it is not
getting any form-factor priority at all and it would therefore always
be ranked lower then internal devices (which receive 400 form factor
priority). The priority 450 is smaller then 'speaker', based on the
idea that a portable device might have less quality then a dedicated
'speaker' device (some Yamaha amplifiers announce themselves as such).

Comment 2 Christian Kellner 2017-04-05 12:17:45 UTC

Created attachment 130690 [details] [review]
sink: Add missing 'hifi' form factor to priorities

Assign it a propriety of 600, therefore ranking higher then speaker,
but below headphone.

Comment 3 Tanu Kaskinen 2017-04-19 14:09:59 UTC

Thanks! I applied the patches.

Since there are still some form factors that are not taken into account, I won't close this bug yet.

Comment 4 GitLab Migration User 2018-07-30 09:34:49 UTC

-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/issues/29.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.