Bug 100677

Summary: [SNB] igt@kms_frontbuffer_tracking@fbc-suspend fails fbc_wait_for_compression() assertion
Product: DRI Reporter: krisman
Component: DRM/IntelAssignee: krisman
Status: CLOSED FIXED QA Contact: Intel GFX Bugs mailing list <intel-gfx-bugs>
Severity: normal    
Priority: medium CC: intel-gfx-bugs, krisman
Version: XOrg git   
Hardware: x86-64 (AMD64)   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
test ran with IGT_LOG_LEVEL=debug
none
0001-kms_frontbuffer_tracking-Don-t-poke-compressing-stat.patch none

Description krisman 2017-04-13 21:49:19 UTC
Created attachment 130837 [details]
test ran with IGT_LOG_LEVEL=debug

When running igt@kms_frontbuffer_tracking@fbc-suspend on a i5-2450M with today's drm-intel-nightly kernel, it fails at the following assertion:
                                   
(kms_frontbuffer_tracking:2392) CRITICAL: Failed assertion: fbc_wait_for_compression()
Subtest fbc-suspend: FAIL (3.775s)

It is 100% reproducible on that machine, but on another another i7-2620M it never triggers. 

I am already running with the patch from Bug 100020 but it didn't make a difference.
Comment 1 krisman 2017-04-13 23:46:26 UTC
This seems quite obvious.  debugfs only prints the compressing status if GEN >=7, but igt waits for the compressing status regardless of the cpu generation. The other SNB can't trigger it because it aborts the test early on for not enough stolen memory.

I'll attach the patch submitted to the igt list.
Comment 2 krisman 2017-04-14 04:54:31 UTC
Created attachment 130839 [details] [review]
0001-kms_frontbuffer_tracking-Don-t-poke-compressing-stat.patch
Comment 3 Jani Saarinen 2017-04-24 13:23:29 UTC
This not yet merged?
Comment 5 krisman 2017-05-07 06:04:36 UTC
(In reply to Jani Saarinen from comment #4)
> Now merged
> https://cgit.freedesktop.org/xorg/app/intel-gpu-tools/commit/
> ?id=cbfdc33f772edf13dc55e98477512937af6bec53

With patch applied, test is now SKIP.  Closing.

IGT-Version: 1.18-g1eb8a8d2019c (x86_64) (Linux: 4.11.0-rc8.intel-boxes+ x86_64)
Primary screen: LVDS 1366x768, crtc 0
FBC last action not supported
Can't test PSR: no usable eDP screen.
Sink CRC not supported: primary screen is not eDP
Test requirement not met in function enable_prim_screen_and_wait, file kms_frontbuffer_tracking.c:1779:
Test requirement: !fbc_not_enough_stolen()
Subtest fbc-suspend: SKIP (1.611s)

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.