Bug 100684

Summary:	Filter modules should use "master_sink" and "master_source" as the modarg names
Product:	PulseAudio	Reporter:	Tanu Kaskinen <tanuk>
Component:	modules	Assignee:	pulseaudio-bugs
Status:	RESOLVED WONTFIX	QA Contact:	pulseaudio-bugs
Severity:	normal
Priority:	medium	CC:	lennart
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Bug Depends on:
Bug Blocks:	99067

Description Tanu Kaskinen 2017-04-14 16:23:49 UTC

During the 11.0 release cycle, module-ladspa-sink and module-virtual-surround-sink changed the "master" modarg to "sink_master", because module-filter-apply uses "sink_master". However, if we're unifying the modarg naming, I think "master_sink" (and "master_source") would be a better choice.

I'll mark this as a release blocker, because if this is not fixed before the release, we'll have to have compatibility code for two old versions of the modarg name in module-ladspa-sink and module-virtual-surround-sink instead of just one.

Comment 1 Tanu Kaskinen 2017-04-21 13:10:49 UTC

My intention was to change the modarg names only if there's a consensus that it's a good idea, but Peter was against it[1], so I'm not going to bother. I'll mark this bug as "wontfix", but if someone else feels strongly about this, the discussion can be continued.

[1] https://lists.freedesktop.org/archives/pulseaudio-discuss/2017-April/028013.html

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.