Bug 100710

Problem is the pixmap has no fbo, therefore (_pixmap_priv_)->fbo->width and (_pixmap_priv_)->fbo->height will be a null-pointer dereference in pixmap_priv_get_scale() from glamor_utils.h

p *src_pixmap_priv[0]
$2 = {type = GLAMOR_MEMORY, gl_fbo = GLAMOR_FBO_UNATTACHED, map_access = GLAMOR_ACCESS_RO, fbo = 0x0, box = {x1 = 0, y1 = 0, x2 = 0, y2 = 0}, pbo = 0, prepare_region = {
    extents = {x1 = 0, y1 = 0, x2 = 0, y2 = 0}, data = 0x0}, prepared = 0, image = 0x0, block_w = 0, block_h = 0, block_wcnt = 0, block_hcnt = 0, box_array = 0x0, 
  fbo_array = 0x0}

fbo creation fails with "glamor: Failed to create fbo, incomplete attachment", this is from:

#0  glamor_pixmap_ensure_fb (glamor_priv=glamor_priv@entry=0xd62570, fbo=fbo@entry=0x86ab60) at glamor_fbo.c:89
#1  0x00000000004b6760 in glamor_create_fbo_from_tex (glamor_priv=glamor_priv@entry=0xd62570,
    w=w@entry=1280, h=h@entry=720, format=format@entry=6406, tex=2, flag=flag@entry=0) at glamor_fbo.c:112
#2  0x00000000004b67cd in glamor_create_fbo (glamor_priv=glamor_priv@entry=0xd62570, w=w@entry=1280,
    h=h@entry=720, format=format@entry=6406, flag=flag@entry=0) at glamor_fbo.c:163
#3  0x000000000049d39c in glamor_create_pixmap (screen=screen@entry=0x868970, w=w@entry=1280,
    h=h@entry=720, depth=depth@entry=8, usage=usage@entry=0) at glamor.c:224
#4  0x00000000004b8612 in glamor_xv_put_image (port_priv=0x86ae20, pDrawable=0x10cc200,
    src_x=<optimized out>, src_y=<optimized out>, drw_x=<optimized out>, 
    drw_y=<optimized out>, src_w=1280, src_h=720, drw_w=1280, drw_h=720, id=842094169, 
    buf=0x7fffe90a003c, width=1280, height=720, sync=0, clipBoxes=0x7fffffffddc0) at glamor_xv.c:434
#5  0x00000000004c088d in KdXVPutImage (pDraw=0x10cc200, pPort=0x86bde0, pGC=<optimized out>,
    src_x=<optimized out>, src_y=<optimized out>, src_w=<optimized out>, 
    src_h=720, drw_x=0, drw_y=0, drw_w=1280, drw_h=720, format=0x86bb70, 
    data=0x7fffe90a003c, sync=0, width=1280, height=720) at kxv.c:1413
#6  0x000000000050293b in ProcXvPutImage (client=0xf21c80) at xvdisp.c:865
#7  0x000000000044c1f6 in Dispatch () at dispatch.c:479
#8  0x0000000000450188 in dix_main (argc=5, argv=0x7fffffffe058, envp=<optimized out>) at main.c:276
#9  0x00007ffff37f6401 in __libc_start_main () from /lib64/libc.so.6
#10 0x0000000000432c9a in _start ()

format is 6406 == 0x1906 == GL_ALPHA

format = gl_iformat_for_pixmap(pixmap) which is defined in glamor_utils.h as:

static inline GLenum
gl_iformat_for_pixmap(PixmapPtr pixmap)
{
    glamor_screen_private *glamor_priv =
        glamor_get_screen_private((pixmap)->drawable.pScreen);

    if (glamor_priv->gl_flavor == GLAMOR_GL_DESKTOP &&
        ((pixmap)->drawable.depth == 1 || (pixmap)->drawable.depth == 8)) {
        return glamor_priv->one_channel_format;
    } else {
        return GL_RGBA;
    }
}

(gdb) p glamor_priv->gl_flavor
$2 = GLAMOR_GL_DESKTOP

(gdb) p glamor_priv->one_channel_format
$3 = 6406 == GL_ALPHA

I am not sure GL_ALPHA is valid there (at least everywhere, and stackoverflow seems to concur [1]) and indeed, using GL_RGBA fixes the issue (without noticeable rendering issue).

So, I am not sure how to fix that, it seems some driver are more permissive than others and allow GL_ALPHA as format there, whereas others such a nouveau (on this hardware, dunno if that's the case everywhere) will fail with an GL_FRAMEBUFFER_INCOMPLETE_ATTACHMENT if GL_ALPHA is used...

[1] http://stackoverflow.com/questions/3613889/gl-framebuffer-incomplete-attachment-when-trying-to-attach-texture

https://patchwork.freedesktop.org/series/23309/