| Summary: | gles cts hangs mesa indefinitely | ||
|---|---|---|---|
| Product: | Mesa | Reporter: | Mark Janes <mark.a.janes> |
| Component: | Drivers/DRI/i965 | Assignee: | Samuel Pitoiset <samuel.pitoiset> |
| Status: | RESOLVED FIXED | QA Contact: | Intel 3D Bugs Mailing List <intel-3d-bugs> |
| Severity: | blocker | ||
| Priority: | highest | CC: | nhaehnle, t_arceri |
| Version: | git | ||
| Hardware: | x86-64 (AMD64) | ||
| OS: | Linux (All) | ||
| Whiteboard: | |||
| i915 platform: | i915 features: | ||
| Attachments: | incomplete patch | ||
|
Description
Mark Janes
2017-04-28 17:57:09 UTC
also, over 1000 piglit tests fail, eg: piglit.spec.arb_gpu_shader5.execution.sampler_array_indexing.gs-nonzero-base piglit.spec.arb_gpu_shader5.texturegather.vs-r-0-float-2drect piglit.spec.arb_gpu_shader5.texturegather.vs-rg-1-float-cube piglit.spec.arb_gpu_shader5.texturegather.vs-rg-1-unorm-2darray piglit.spec.arb_gpu_shader5.texturegather.vs-rgb-0-uint-2d piglit.spec.arb_gpu_shader5.texturegather.vs-rgb-1-unorm-2d piglit.spec.arb_gpu_shader5.texturegather.vs-rgba-0-int-2darray piglit.spec.arb_gpu_shader5.texturegather.vs-rgba-0-int-2drect piglit.spec.arb_gpu_shader5.texturegather.vs-rgba-0-unorm-cubearray piglit.spec.arb_gpu_shader5.texturegather.vs-rgba-2-uint-2drect piglit.spec.arb_gpu_shader5.texturegather.vs-rgba-3-unorm-2d piglit.spec.arb_gpu_shader5.texturegatheroffset.vs-r-0-float-2darray-const piglit.spec.arb_gpu_shader5.texturegatheroffset.vs-rg-1-uint-2d-const piglit.spec.arb_gpu_shader5.texturegatheroffset.vs-rgba-0-int-2darray-const piglit.spec.arb_gpu_shader5.texturegatheroffset.vs-rgba-1-unorm-2d-const piglit.spec.arb_gpu_shader5.texturegatheroffset.vs-rgba-2-unorm-2darray-const piglit.spec.arb_gpu_shader5.texturegatheroffsets.vs-rg-0-float-2darray piglit.spec.arb_gpu_shader5.texturegatheroffsets.vs-rgb-1-float-2darray piglit.spec.arb_gpu_shader5.texturegatheroffsets.vs-rgba-0-int-2d piglit.spec.arb_gpu_shader5.texturegatheroffsets.vs-rgba-0-int-2darray piglit.spec.arb_gpu_shader5.texturegatheroffsets.vs-rgba-2-float-2darray piglit.spec.arb_shader_texture_image_samples.texturesamples.gs-usampler2dmsarray-8 piglit.spec.arb_texture_gather.texturegather.vs-r-none-unorm-2darray piglit.spec.arb_texture_gather.texturegather.vs-r-zero-uint-2d piglit.spec.arb_texture_gather.texturegather.vs-r-zero-uint-cubearray piglit.spec.arb_texture_gather.texturegather.vs-rg-green-float-cubearray piglit.spec.arb_texture_gather.texturegather.vs-rg-zero-uint-cube piglit.spec.arb_texture_gather.texturegather.vs-rgb-blue-float-2darray piglit.spec.arb_texture_gather.texturegather.vs-rgb-blue-uint-cube piglit.spec.arb_texture_gather.texturegather.vs-rgb-blue-unorm-2darray piglit.spec.arb_texture_gather.texturegather.vs-rgb-blue-unorm-cube piglit.spec.arb_texture_gather.texturegather.vs-rgb-green-unorm-cube piglit.spec.arb_texture_gather.texturegather.vs-rgb-none-int-cube piglit.spec.arb_texture_gather.texturegather.vs-rgb-red-float-2d piglit.spec.arb_texture_gather.texturegather.vs-rgba-zero-unorm-cube piglit.spec.arb_texture_gather.texturegather.vs-rgba-zero-unorm-cubearray piglit.spec.arb_texture_gather.texturegatheroffset.vs-r-zero-int-2d piglit.spec.arb_texture_gather.texturegatheroffset.vs-rg-one-float-2d piglit.spec.arb_texture_gather.texturegatheroffset.vs-rg-one-float-2darray piglit.spec.arb_texture_gather.texturegatheroffset.vs-rgb-green-float-2darray piglit.spec.arb_texture_gather.texturegatheroffset.vs-rgba-alpha-uint-2darray piglit.spec.arb_texture_gather.texturegatheroffset.vs-rgba-green-uint-2d piglit.spec.arb_texture_multisample.texelfetch.6-vs-sampler2dmsarray piglit.spec.arb_texture_multisample.texturesize.gs-texturesize-isampler2dmsarray piglit.spec.glsl-1_30.execution.texelfetch.vs-texelfetch-isampler1darray piglit.spec.glsl-1_30.execution.texelfetch.vs-texelfetch-isampler2darray-swizzle piglit.spec.glsl-1_30.execution.texelfetchoffset.vs-texelfetch-isampler2d piglit.spec.glsl-1_30.execution.texturesize.vs-texturesize-usampler2d piglit.spec.glsl-1_50.execution.texelfetch.gs-texelfetch-isampler3d piglit.spec.glsl-1_50.execution.texturesize.gs-texturesize-sampler1dshadow piglit.spec.glsl-1_50.execution.texturesize.gs-texturesize-sampler2d /tmp/build_root/m64/lib/piglit/bin/textureGather vs rgb blue unorm 2DArray -auto -fbo piglit: debug: Requested an OpenGL 3.1 Forward-Compatible Core Context, and received a matching 4.5 context Standard Error *** Error in `/tmp/build_root/m64/lib/piglit/bin/textureGather': malloc(): memory corruption: 0x000055be72bde0a0 *** Created attachment 131146 [details] [review] incomplete patch I hoped this patch would be enough, but it is not. I still get failures in src/mesa/drivers/dri/i965/gen6_constant_state.c:152: for (i = 0; i < prog_data->nr_params; i++) { param[i] = *prog_data->param[i]; } (In reply to Matt Turner from comment #2) > Created attachment 131146 [details] [review] [review] > incomplete patch > > I hoped this patch would be enough, but it is not. I still get failures in > > src/mesa/drivers/dri/i965/gen6_constant_state.c:152: > > for (i = 0; i < prog_data->nr_params; i++) { > param[i] = *prog_data->param[i]; > } Are you able to provide an example of a test that is hitting this? (In reply to Matt Turner from comment #2) > Created attachment 131146 [details] [review] [review] > incomplete patch > > I hoped this patch would be enough, but it is not. I still get failures in > > src/mesa/drivers/dri/i965/gen6_constant_state.c:152: > > for (i = 0; i < prog_data->nr_params; i++) { > param[i] = *prog_data->param[i]; > } Hi Matt, The problem with the patch is that it is skipping uniforms all members of a uniform struct if it the struct contains a sampler. I'm running a slightly different patch in jenkins and will send it out shortly if everything comes out ok. Fix sent to the list, I liked Matts commit message so I reused it :) https://patchwork.freedesktop.org/patch/153798/ Should be fixed by: commit de8e01698fb745e6f91c22470393777093c2c2ee Author: Timothy Arceri <tarceri@itsqueeze.com> Date: Sun Apr 30 12:12:35 2017 +1000 i965: Don't allocate uniform space for samplers Samplers are encoded into the instruction word, so there's no need to make space in the uniform file. Previously matrix_columns and vector_elements were set to 0, making this else case a no-op. Commit 75a31a20af26 changed that, causing malloc corruption in thousands of tests on i965. Fixes: 75a31a20af26 ("glsl: set vector_elements to 1 for samplers") Reviewed-by: Jason Ekstrand <jason@jlekstrand.net> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=100871 |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.