Bug 101022

This is due to the pre-rc1 back merge and is of course not due to any of our code.

Yes, this is during the nvme rescan.. I'll mark this as not our bug for now, and ping Keith Busch once I confirm this is not already fixed in linux-next.

Thanks.

(In reply to krisman from comment #2)
> Yes, this is during the nvme rescan.. I'll mark this as not our bug for now,
> and ping Keith Busch once I confirm this is not already fixed in linux-next.
> 
> Thanks.

Any news on this?

(In reply to Martin Peres from comment #3)
> (In reply to krisman from comment #2)
> > Yes, this is during the nvme rescan.. I'll mark this as not our bug for now,
> > and ping Keith Busch once I confirm this is not already fixed in linux-next.
> > 
> > Thanks.
> 
> Any news on this?

Hmm. forgot to get back to it once the merge window closed.

So, I started a discussion in linux-nvme reporting the problem and looking for suggestions.  I'm also looking for a box with NVMe card so I can at least bisect the issue.

(In reply to krisman from comment #4)
> (In reply to Martin Peres from comment #3)
> > (In reply to krisman from comment #2)
> > > Yes, this is during the nvme rescan.. I'll mark this as not our bug for now,
> > > and ping Keith Busch once I confirm this is not already fixed in linux-next.
> > > 
> > > Thanks.
> > 
> > Any news on this?
> 
> Hmm. forgot to get back to it once the merge window closed.
> 
> So, I started a discussion in linux-nvme reporting the problem and looking
> for suggestions.  I'm also looking for a box with NVMe card so I can at
> least bisect the issue.

Keith suggested the following patch 

 diff --git a/block/blk-mq.c b/block/blk-mq.c
 index f2224ffd..1bccced 100644
 --- a/block/blk-mq.c
 +++ b/block/blk-mq.c
 @@ -2641,7 +2641,8 @@ int blk_mq_update_nr_requests(struct request_queue *q, unsigned int nr)
         return ret;
  }

 -void blk_mq_update_nr_hw_queues(struct blk_mq_tag_set *set, int nr_hw_queues)
 +static void __blk_mq_update_nr_hw_queues(struct blk_mq_tag_set *set,
 +                                                       int nr_hw_queues)
  {
         struct request_queue *q;

 @@ -2665,6 +2666,13 @@ void blk_mq_update_nr_hw_queues(struct blk_mq_tag_set *set, int nr_hw_queues)
         list_for_each_entry(q, &set->tag_list, tag_set_list)
                 blk_mq_unfreeze_queue(q);
  }
 +
 +void blk_mq_update_nr_hw_queues(struct blk_mq_tag_set *set, int nr_hw_queues)
 +{
 +       mutex_lock(&set->tag_list_lock);
 +       __blk_mq_update_nr_hw_queues(set, nr_hw_queues);
 +       mutex_unlock(&set->tag_list_lock);
 +}
  EXPORT_SYMBOL_GPL(blk_mq_update_nr_hw_queues);

  /* Enable polling stats and return whether they were already enabled. */


If I send it to intel-gfx, will it be grabbed by the CI and tested or is there other process in place, since it is outside drivers/gpu/drm?

(In reply to krisman from comment #5)
> (In reply to krisman from comment #4)
> > (In reply to Martin Peres from comment #3)
> > > (In reply to krisman from comment #2)
> > > > Yes, this is during the nvme rescan.. I'll mark this as not our bug for now,
> > > > and ping Keith Busch once I confirm this is not already fixed in linux-next.
> > > > 
> > > > Thanks.
> > > 
> > > Any news on this?
> > 
> > Hmm. forgot to get back to it once the merge window closed.
> > 
> > So, I started a discussion in linux-nvme reporting the problem and looking
> > for suggestions.  I'm also looking for a box with NVMe card so I can at
> > least bisect the issue.
> 
> Keith suggested the following patch 

After running on the CI, I confirmed the patch fixes the issue.  It has been queued in Jen's tree for the next -rc:

https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git/commit/?h=for-linus&id=e4dc2b32df5573b077f6723e01cf761d236d5113

The CI run:

https://intel-gfx-ci.01.org/CI/Trybot_861/fi-kbl-7500u/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html

(In reply to krisman from comment #6)
> (In reply to krisman from comment #5)
> > Keith suggested the following patch 
> 
> After running on the CI, I confirmed the patch fixes the issue.  It has been
> queued in Jen's tree for the next -rc:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git/commit/
> ?h=for-linus&id=e4dc2b32df5573b077f6723e01cf761d236d5113
> 
> The CI run:
> 
> https://intel-gfx-ci.01.org/CI/Trybot_861/fi-kbl-7500u/
> igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html

You rock! We can merge it into the for-CI branch, so as we don't have to wait for the backmerge to get it back :)

(In reply to Martin Peres from comment #7)
> (In reply to krisman from comment #6)
> > (In reply to krisman from comment #5)
> > > Keith suggested the following patch 
> > 
> > After running on the CI, I confirmed the patch fixes the issue.  It has been
> > queued in Jen's tree for the next -rc:
> > 
> > https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git/commit/
> > ?h=for-linus&id=e4dc2b32df5573b077f6723e01cf761d236d5113
> > 
> > The CI run:
> > 
> > https://intel-gfx-ci.01.org/CI/Trybot_861/fi-kbl-7500u/
> > igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
> 
> You rock! We can merge it into the for-CI branch, so as we don't have to
> wait for the backmerge to get it back :)

What is the process for that? Is there a different list for submitting it?

(In reply to krisman from comment #8)
> (In reply to Martin Peres from comment #7)
> > (In reply to krisman from comment #6)
> > > (In reply to krisman from comment #5)
> > > > Keith suggested the following patch 
> > > 
> > > After running on the CI, I confirmed the patch fixes the issue.  It has been
> > > queued in Jen's tree for the next -rc:
> > > 
> > > https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git/commit/
> > > ?h=for-linus&id=e4dc2b32df5573b077f6723e01cf761d236d5113
> > > 
> > > The CI run:
> > > 
> > > https://intel-gfx-ci.01.org/CI/Trybot_861/fi-kbl-7500u/
> > > igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
> > 
> > You rock! We can merge it into the for-CI branch, so as we don't have to
> > wait for the backmerge to get it back :)
> 
> What is the process for that? Is there a different list for submitting it?

Danvet wanted Marta and I to have commits right to manage this branch but I have not yet accepted this :p In the mean time, send it to linux-gfx and state that this patch is queued for inclusion and that we want it in the for-CI branch.

patch passed try-bot: https://patchwork.freedesktop.org/series/25054/

And passes those tests (no dmesg warning) that used to have issues.

(In reply to Jani Saarinen from comment #11)
> And passes those tests (no dmesg warning) that used to have issues.

The patch has been merged in 4.12-rc4. Wasn't Imre supposed to push the patch to core-for-CI?

Otherwise, we will need to wait for the backmerge.