Summary: | Elantech touchpad double Tap Time too short on ASUS Zenbook UX410UQ | ||
---|---|---|---|
Product: | Wayland | Reporter: | mhbugreport |
Component: | libinput | Assignee: | Wayland bug list <wayland-bugs> |
Status: | RESOLVED MOVED | QA Contact: | |
Severity: | normal | ||
Priority: | medium | CC: | peter.hutterer |
Version: | unspecified | ||
Hardware: | Other | ||
OS: | All | ||
Whiteboard: | |||
i915 platform: | i915 features: | ||
Attachments: | Screenshot of TouchpadTapSpeed-distance.gnuplot |
Description
mhbugreport
2017-05-22 23:03:12 UTC
Record yourself tapping a few times with evemu-record, then grab the input-data-analysis and run this script please: https://github.com/whot/input-data-analysis/blob/master/touchpad-tap-speed/touchpad-tap-speed.py (You'll need to set up PYTHONPATH to point at the repository root) That produces a bunch of gnuplot files with data, have a look at those and see what times you're using for tapping. doh, this was suppoed to be NEEDINFO, not resolved... (In reply to Peter Hutterer from comment #1) > Record yourself tapping a few times with evemu-record, then grab the > input-data-analysis and run this script please: > https://github.com/whot/input-data-analysis/blob/master/touchpad-tap-speed/ > touchpad-tap-speed.py > > (You'll need to set up PYTHONPATH to point at the repository root) > > That produces a bunch of gnuplot files with data, have a look at those and > see what times you're using for tapping. I have cloned the git repository, and tried running touchpad-tap-speed.py, after having recorded some tap events using evemu-record : sudo evemu-record > touchpad-doubletap.txt ... python touchpad-tap-speed.py Outputs : Traceback (most recent call last): File "touchpad-tap-speed.py", line 11, in <module> from shared import * File "../shared/__init__.py", line 6, in <module> import evemu ModuleNotFoundError: No module named 'evemu' Which is weird since I have evemu installed, and already run evemu-record. Where is the problem ? looks like you're missing the python bindings for evemu. On Fedora, they're in the evemu-devel package, I guess Manjaro has a similar package. (In reply to Peter Hutterer from comment #4) > looks like you're missing the python bindings for evemu. On Fedora, they're > in the evemu-devel package, I guess Manjaro has a similar package. Okay, I ran the script with python2 instead of python, seems that it was the problem. I have attached the screenshot of TouchpadTapSpeed-times.gnuplot. Does it have enough information ? It seems to me that this plot only contains information about the time for press-release for a single tap, not the time that separates the two taps of a double-tap. Am I wrong ? Created attachment 131516 [details]
Screenshot of TouchpadTapSpeed-distance.gnuplot
Thanks, much appreciated. And now I'm face-palming a bit - yes, this one does not handle doubletaps. Sorry about that. I'll get a debugging script sorted for that asap. ok, finally have something in place to measure this. It's not perfect yet so my apologies for making you play guinea pig. https://github.com/whot/libinput/tree/wip/touchpad-measure-doubletap Build it, then run libinput-measure-touchpad-tap --tap-count=2 (directly in the builddir) and look at the statistics. That should tell us a few things already, otherwise run with --format=dat and attach the output here. (In reply to Peter Hutterer from comment #8) > ok, finally have something in place to measure this. It's not perfect yet so > my apologies for making you play guinea pig. > > https://github.com/whot/libinput/tree/wip/touchpad-measure-doubletap > > Build it, then run libinput-measure-touchpad-tap --tap-count=2 (directly in > the builddir) and look at the statistics. That should tell us a few things > already, otherwise run with --format=dat and attach the output here. Hi. Sorry for the late answer. The issue is that libinput is already installed, so I am wondering whether building from your repository will mess up my already existing installation. In other words is there a way for the two libinputs to coexist. If so then I will perform your suggested test. Cheers ! you don't need to install libinput to run that tool you can run it directly from the git build directory. (In reply to Peter Hutterer from comment #10) > you don't need to install libinput to run that tool you can run it directly > from the git build directory. Thanks for your answer. So I build libinput locally using : $> git clone https://github.com/whot/libinput.git $> cd libinput $> meson --prefix=$HOME/libinput/libinput_build builddir/ $> ninja -C builddir/ $> sudo ninja -C builddir/ install then $> cd $HOME/libinput/libinput_build/libexec/libinput $> sudo ./libinput-measure-touchpad-tap --tap-count=2 --format=dat An I get ./libinput-measure-touchpad-tap: unrecognized option '--tap-count=2' Usage: libinput measure touchpad-tap [--help] [/dev/input/event0] Did I do something wrong ? sorry for the delay, I was on holidays. Looks like you didn't check out the right branch, you need a 'git checkout -b wip/touchpad-measure-doubletap'. Also, as mentioned above, you can skip the ninja install step. Having said that, I have plans of rewriting that bit in python to make it easier to maintain. Should get to this over the next few days, it might be worth waiting. (In reply to Peter Hutterer from comment #12) > sorry for the delay, I was on holidays. Looks like you didn't check out the > right branch, you need a 'git checkout -b wip/touchpad-measure-doubletap'. > Also, as mentioned above, you can skip the ninja install step. Having said > that, I have plans of rewriting that bit in python to make it easier to > maintain. Should get to this over the next few days, it might be worth > waiting. Okay, I'll wait ! Cheers. (In reply to Peter Hutterer from comment #12) > sorry for the delay, I was on holidays. Looks like you didn't check out the > right branch, you need a 'git checkout -b wip/touchpad-measure-doubletap'. > Also, as mentioned above, you can skip the ninja install step. Having said > that, I have plans of rewriting that bit in python to make it easier to > maintain. Should get to this over the next few days, it might be worth > waiting. Any news on the touchpad-measure-doubletap tool ? sorry, completely swamped. I just sent the patch for replacing the tool with a python version to the list. It doesn't do double-tap yet though. https://lists.freedesktop.org/archives/wayland-devel/2017-November/035843.html The patch above was pushed as fca003d30, any help with adding the bits to measure doubletap timeouts would be appreciated. It's python now which makes things a lot easier fwiw, I'm looking for help with the double tap time measure tool, I don't seem to have enough time for anything these days -- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/libinput/libinput/issues/8. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.