Bug 101174

Summary:	nicesrc may be disposed while still in playing state
Product:	Farstream	Reporter:	Fabrice Bellet <fabrice>
Component:	RTP Plugin	Assignee:	Olivier Crête <olivier.crete>
Status:	RESOLVED NOTOURBUG	QA Contact:
Severity:	normal
Priority:	medium
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	nice-transmitter: fix nicesrc locking state before unlink

Description Fabrice Bellet 2017-05-24 20:06:15 UTC

Created attachment 131488 [details] [review]
nice-transmitter: fix nicesrc locking state before unlink

The last rare bug of this series: I noticed sometimes the nicesrc element being disposed, while still in playing state. This was surprising, because the element was properly set in the null state in fs_nice_transmitter_free_gst_stream(), but before being unlinked, unref()ed, and disposed, it appears that some higher level element (the conference element IIRC) was put in playing state, causing all the underlying elements to follow the same transition, including the nicesrc.

A possible fix to prevent that situation may be to put the nicesrc element in a locked state, just like we do with nicesinks[] ?

Comment 1 Olivier Crête 2017-06-05 23:23:08 UTC

This bug was introduced by some other patch you have, the sources are first removed from the pipeline, so that any error messages don't get propagated. Then they are stopped.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.