Summary: | [IGT] gem_workarounds@basic-read Test assertion failure | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | DRI | Reporter: | Humberto Israel Perez Rodriguez <humberto.i.perez.rodriguez> | ||||||||||||||
Component: | DRM/Intel | Assignee: | Intel GFX Bugs mailing list <intel-gfx-bugs> | ||||||||||||||
Status: | CLOSED FIXED | QA Contact: | Intel GFX Bugs mailing list <intel-gfx-bugs> | ||||||||||||||
Severity: | critical | ||||||||||||||||
Priority: | highest | CC: | armando.antoniox.mora.reos, intel-gfx-bugs, krisman, ricardo.vega | ||||||||||||||
Version: | DRI git | ||||||||||||||||
Hardware: | x86-64 (AMD64) | ||||||||||||||||
OS: | Linux (All) | ||||||||||||||||
Whiteboard: | ReadyForDev | ||||||||||||||||
i915 platform: | BXT | i915 features: | GEM/Other | ||||||||||||||
Attachments: |
|
Description
Humberto Israel Perez Rodriguez
2017-05-24 20:10:18 UTC
Created attachment 131490 [details]
dmesg.log
Created attachment 131491 [details]
kern.log
Created attachment 131492 [details]
cairo__config.log
Created attachment 131493 [details]
drm__config.log
Created attachment 131494 [details]
intel-gpu-tools__config.log
*** Bug 101175 has been marked as a duplicate of this bug. *** (In reply to Humberto Israel Perez Rodriguez from comment #0) > Subtest basic-read failed. > **** DEBUG **** > (gem_workarounds:1478) drmtest-DEBUG: Test requirement passed: !(fd<0) > (gem_workarounds:1478) igt-debugfs-DEBUG: Opening debugfs directory > '/sys/kernel/debug/dri/0' > (gem_workarounds:1478) DEBUG: Address val mask read > result > (gem_workarounds:1478) DEBUG: 0x0E4F0 0x81008100 0x00008100 > 0x00000000 FAIL Looks like all the failed workarounds where read as zero by intel_register_read. Not sure if that is notable though. (In reply to krisman from comment #7) > (In reply to Humberto Israel Perez Rodriguez from comment #0) > > > Subtest basic-read failed. > > **** DEBUG **** > > (gem_workarounds:1478) drmtest-DEBUG: Test requirement passed: !(fd<0) > > (gem_workarounds:1478) igt-debugfs-DEBUG: Opening debugfs directory > > '/sys/kernel/debug/dri/0' > > (gem_workarounds:1478) DEBUG: Address val mask read > > result > > (gem_workarounds:1478) DEBUG: 0x0E4F0 0x81008100 0x00008100 > > 0x00000000 FAIL > > Looks like all the failed workarounds where read as zero by > intel_register_read. Not sure if that is notable though. I'm not sure if it helps but can you boot with intel_iommu=igfx_off and retest? Humberto please retest with option provided (In reply to krisman from comment #8) > (In reply to krisman from comment #7) > > (In reply to Humberto Israel Perez Rodriguez from comment #0) > > > > > Subtest basic-read failed. > > > **** DEBUG **** > > > (gem_workarounds:1478) drmtest-DEBUG: Test requirement passed: !(fd<0) > > > (gem_workarounds:1478) igt-debugfs-DEBUG: Opening debugfs directory > > > '/sys/kernel/debug/dri/0' > > > (gem_workarounds:1478) DEBUG: Address val mask read > > > result > > > (gem_workarounds:1478) DEBUG: 0x0E4F0 0x81008100 0x00008100 > > > 0x00000000 FAIL > > > > Looks like all the failed workarounds where read as zero by > > intel_register_read. Not sure if that is notable though. > > I'm not sure if it helps but can you boot with intel_iommu=igfx_off and > retest? Hi Krisman, i've tried with the option intel_iommu=igfx_off in the grub as you mentioned, but this i think is not a real failure because for the following reason : gem_workarounds:1418) CRITICAL: Test assertion failure function check_workarounds, file gem_workarounds.c:103: (gem_workarounds:1418) CRITICAL: Failed assertion: workaround_fail_count() == 0 (gem_workarounds:1418) CRITICAL: Last errno: 2, No such file or directory (gem_workarounds:1418) CRITICAL: error: 5 != 0 the test is trying to access to a file but there is not in igt folder. (In reply to Humberto Israel Perez Rodriguez from comment #10) > (In reply to krisman from comment #8) > > (In reply to krisman from comment #7) > > > (In reply to Humberto Israel Perez Rodriguez from comment #0) > > > > > > > Subtest basic-read failed. > > > > **** DEBUG **** > > > > (gem_workarounds:1478) drmtest-DEBUG: Test requirement passed: !(fd<0) > > > > (gem_workarounds:1478) igt-debugfs-DEBUG: Opening debugfs directory > > > > '/sys/kernel/debug/dri/0' > > > > (gem_workarounds:1478) DEBUG: Address val mask read > > > > result > > > > (gem_workarounds:1478) DEBUG: 0x0E4F0 0x81008100 0x00008100 > > > > 0x00000000 FAIL > > > > > > Looks like all the failed workarounds where read as zero by > > > intel_register_read. Not sure if that is notable though. > > > > I'm not sure if it helps but can you boot with intel_iommu=igfx_off and > > retest? > > Hi Krisman, i've tried with the option intel_iommu=igfx_off in the grub as > you mentioned, but this i think is not a real failure because for the > following reason : > > > gem_workarounds:1418) CRITICAL: Test assertion failure function > check_workarounds, file gem_workarounds.c:103: > (gem_workarounds:1418) CRITICAL: Failed assertion: workaround_fail_count() > == 0 > (gem_workarounds:1418) CRITICAL: Last errno: 2, No such file or directory > (gem_workarounds:1418) CRITICAL: error: 5 != 0 > > > the test is trying to access to a file but there is not in igt folder. the igt_assertion will print the last errno regardless of its relation to the failed assertion. That is why it shows -ENOENT here. My understanding is it is not related to this issue. So, my understanding is that you ran with that parameter and it still fails, can you please provide the entire log for confirmation? Thanks! Humberto bug need your attention Can you try with: diff --git a/tests/gem_workarounds.c b/tests/gem_workarounds.c index c7286d86..c09512cb 100644 --- a/tests/gem_workarounds.c +++ b/tests/gem_workarounds.c @@ -45,11 +45,11 @@ struct intel_wa_reg { static struct intel_wa_reg *wa_regs; static int num_wa_regs; -static void wait_gpu(void) +static int open_and_wake_gpu(void) { int fd = drm_open_driver(DRIVER_INTEL); gem_quiescent_gpu(fd); - close(fd); + return fd; } static void test_hang_gpu(void) @@ -67,13 +67,13 @@ static void test_suspend_resume(void) static int workaround_fail_count(void) { - int i, fail_count = 0; + int i, fd, fail_count = 0; /* There is a small delay after coming ot of rc6 to the correct render context values will get loaded by hardware (bdw,chv). This here ensures that we have the correct context loaded before we start to read values */ - wait_gpu(); + fd = open_and_wake_gpu(); igt_debug("Address\tval\t\tmask\t\tread\t\tresult\n"); @@ -95,6 +95,8 @@ static int workaround_fail_count(void) } } + close(fd); + return fail_count; } I can't reproduce with 00:02.0 0300: 8086:0412 (rev 06) (In reply to Mika Kuoppala from comment #13) > Can you try with: > > diff --git a/tests/gem_workarounds.c b/tests/gem_workarounds.c > index c7286d86..c09512cb 100644 > --- a/tests/gem_workarounds.c > +++ b/tests/gem_workarounds.c > @@ -45,11 +45,11 @@ struct intel_wa_reg { > static struct intel_wa_reg *wa_regs; > static int num_wa_regs; > > -static void wait_gpu(void) > +static int open_and_wake_gpu(void) > { > int fd = drm_open_driver(DRIVER_INTEL); > gem_quiescent_gpu(fd); > - close(fd); > + return fd; > } > > static void test_hang_gpu(void) > @@ -67,13 +67,13 @@ static void test_suspend_resume(void) > > static int workaround_fail_count(void) > { > - int i, fail_count = 0; > + int i, fd, fail_count = 0; > > /* There is a small delay after coming ot of rc6 to the correct > render context values will get loaded by hardware (bdw,chv). > This here ensures that we have the correct context loaded before > we start to read values */ > - wait_gpu(); > + fd = open_and_wake_gpu(); > > igt_debug("Address\tval\t\tmask\t\tread\t\tresult\n"); > > @@ -95,6 +95,8 @@ static int workaround_fail_count(void) > } > } > > + close(fd); > + > return fail_count; > } i cant apply the path, git show me the following error fatal: corrupt patch at line 43 the command that i am using is the following git apply --stat --verbose file.patch Created attachment 132795 [details] [review] Mika's debug patch. (In reply to Humberto Israel Perez Rodriguez from comment #15) > (In reply to Mika Kuoppala from comment #13) > > i cant apply the path, git show me the following error > > fatal: corrupt patch at line 43 Take the attached version instead. It's the exact same patch from Mika. (In reply to krisman from comment #16) > Created attachment 132795 [details] [review] [review] > Mika's debug patch. > > (In reply to Humberto Israel Perez Rodriguez from comment #15) > > (In reply to Mika Kuoppala from comment #13) > > > > i cant apply the path, git show me the following error > > > > fatal: corrupt patch at line 43 > > Take the attached version instead. It's the exact same patch from Mika. Hi Krisman, is the same failure with the patch applied Still no changes with kernel: commit ad6ab9f96437f0cb1f4d8a7840fd9eeb894eb12e Author: Gustavo Padovan <gustavo.padovan@collabora.com> AuthorDate: Fri Aug 18 15:26:42 2017 -0300 Commit: Gustavo Padovan <gustavo.padovan@collabora.com> CommitDate: Fri Aug 18 15:26:42 2017 -0300 drm-tip: 2017y-08m-18d-18h-21m-46s UTC integration manifest No patches applied. I added new platforms, moving this bug to APL instead of BXT. (In reply to Elizabeth from comment #18) > Still no changes with kernel: > > commit ad6ab9f96437f0cb1f4d8a7840fd9eeb894eb12e > Author: Gustavo Padovan <gustavo.padovan@collabora.com> > AuthorDate: Fri Aug 18 15:26:42 2017 -0300 > Commit: Gustavo Padovan <gustavo.padovan@collabora.com> > CommitDate: Fri Aug 18 15:26:42 2017 -0300 > > drm-tip: 2017y-08m-18d-18h-21m-46s UTC integration manifest > > No patches applied. Hardware Information ====================================== motherboard model : NUC6CAYS motherboard id : NUC6CAYB form factor : Desktop manufacturer : Intelcorporation cpu family : Celeron cpu family id : 6 cpu information : Intel(R) Celeron(R) CPU J3455 @ 1.50GHz gpu card : Intel Corporation Device 5a85 (rev 0b) (prog-if 00 [VGA controller]) memory ram : 15.54 GB max memory ram : 32 GB display resolution : 3840x1080 cpu thread : 4 cpu core : 4 cpu model : 92 cpu stepping : 9 socket : Other signature : Type 0, Family 6, Model 92, Stepping 9 hard drive : 74GiB (80GB) current cd clock frequency : 288000 kHz maximum cd clock frequency : 624000 kHz displays connected : DP-1 DP-2 *** Bug 102134 has been marked as a duplicate of this bug. *** igt commit 790a066fe990d1cf85bb2d39f6d8f78400b08e03 Author: Chris Wilson <chris@chris-wilson.co.uk> Date: Tue Sep 26 22:09:26 2017 +0100 igt/gem_workarounds: Read the workaround registers from the active context The workarounds are only valid whilst the GPU is active. To be sure we are reading the registers in the right state, issue the reads from the GPU. v2: Show ignored write-only failures as debug. v3: PAGE_ALIGN. Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com> Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com> |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.