Bug 101279

Summary:	[PATCH] add support for short help switch
Product:	libmbim	Reporter:	Jaroslav Stepanek <xstej70>
Component:	General	Assignee:	Aleksander Morgado <aleksander>
Status:	RESOLVED FIXED	QA Contact:
Severity:	enhancement
Priority:	medium
Version:	unspecified
Hardware:	All
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	patch v1 help_git.patch

Description Jaroslav Stepanek 2017-06-02 13:03:55 UTC

Created attachment 131677 [details] [review]
patch v1

This patch adds support for the mbim-network script for alternate short version of help. It enables displaying help like "mbim-network -h", which is the version many users will use first instead of --help (including myself).

Comment 1 Aleksander Morgado 2017-06-02 13:09:56 UTC

Comment on attachment 131677 [details] [review]
patch v1

LGTM; but could you send a git patch instead of a diff? note the mbim-network program in the git repository is "mbim-network.in"

Comment 2 Jaroslav Stepanek 2017-06-05 09:45:28 UTC

Created attachment 131706 [details] [review]
help_git.patch

Does this work? Sorry for such lame questions, I am new to this...

Comment 3 Aleksander Morgado 2017-06-05 11:52:31 UTC

(In reply to Jaroslav Stepanek from comment #2)
> Created attachment 131706 [details] [review] [review]
> help_git.patch
> 
> Does this work? Sorry for such lame questions, I am new to this...

Well, at least it is something I can git-apply. Ideally you would create a proper git patch generated with "git format-patch" that includes a full commit message and all that. I had to manually do that in the diff you sent.

Merged to git master now, thanks!

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.