Bug 101363

Summary:	ASSERTION FAILED: sel.hasDoubleType() in beignet 1.3
Product:	Beignet	Reporter:	Manfred Lotz <manfred.lotz>
Component:	Beignet	Assignee:	Xiuli Pan <xiuli.pan>
Status:	RESOLVED MOVED	QA Contact:
Severity:	normal
Priority:	medium
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	Contains debug information for assertion failed problem

Description Manfred Lotz 2017-06-09 18:28:30 UTC

Having installed beignet1.3.0 in Fedora 25 clinfo still works fine.

But when starting AfterShot3X64 then it crashes because of:

ASSERTION FAILED: sel.hasDoubleType()
  at file /builddir/build/BUILD/Beignet-1.3.0-Source/backend/src/backend/gen_insn_selection.cpp, function void gbe::ConvertInstructionPattern::convertBetweenFloatDouble(gbe::Selection::Opaque&, const gbe::ir::ConvertInstruction&, bool&) const, line 6148


I have no idea if this is a bug in the Aftershot Pro 3 software or in beignet.

Comment 1 Xiuli Pan 2017-06-14 02:25:29 UTC

Hi，

Could you provide the log with environment variable:
export OCL_OUTPUT_KERNEL_SOURCE=1
export OCL_OUTPUT_GEN_IR=1
export OCL_OUTPUT_SEL_IR=1

With these we can know which part has problem.

Thanks
Xiuli

Comment 2 Manfred Lotz 2017-06-14 02:57:50 UTC

Created attachment 131942 [details]
Contains debug information for assertion failed problem

Setting env vars:
export OCL_OUTPUT_KERNEL_SOURCE=1
export OCL_OUTPUT_GEN_IR=1
export OCL_OUTPUT_SEL_IR=1

and starting After Shot Pro 3 software yielded the attached output.

Comment 3 Xiuli Pan 2017-06-15 02:44:37 UTC

Hi,

I have check the log and find that it is a AfterShot problem:

	lumaBlur = lumaBlur * 0.01;

It used 0.01 in opencl kernel, but the clang will treat all float constant as double float and cause the llvm to promote other float to double thus we do not support well now. If you can change the code you can try to add suffix f all of the float constant to fix it.

Thanks
Xiuli

Comment 4 Manfred Lotz 2017-06-15 09:08:59 UTC

Thanks a lot for checking. I have to report the bug to Corel.

Comment 5 GitLab Migration User 2018-10-12 21:23:54 UTC

-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/beignet/beignet/issues/22.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.