Bug 101433

Summary: occasional undesired scrolling from palm on touchpad
Product: Wayland Reporter: Christian Hergert <christian>
Component: libinputAssignee: Wayland bug list <wayland-bugs>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: medium CC: peter.hutterer
Version: unspecified   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments: evemu recording
0001-touchpad-increase-palm-edge-zones-to-8.patch

Description Christian Hergert 2017-06-15 02:17:28 UTC
Created attachment 131966 [details]
evemu recording

Okay, we know this is always going to be device and, to some degree, human specific.

I have an Gen3 X1 Carbon. While typing in $EDITOR my cursor occasionally jumps around to to scroll events while typing. It appears to be due to my resting palm interaction with the touchpad.

I'd say it happens anywhere from 10-20x a day. Generally I just undo and work around it.

Attached is a recording from evemu-record. I just played around with the keyboard typing until i caused some undesired scrolls. So those will be at the end of the log.

Best of luck and let me know if I can record more reproducers to help cancel things out.
Comment 1 Peter Hutterer 2017-06-26 10:25:20 UTC
sorry about the delay. quick grep with current libinput shows that *most* touches are detected correctly as palm. There are two touches in this one that trigger event sequence B as shown in the graphic here:
https://wayland.freedesktop.org/libinput/doc/latest/palm_detection.html
There are also a few that start outside of the palm detection zones so they don't get detected as palms at all.

I think widening the palm areas is a good idea here but I'm not sure how far, a quick test locally increasing it to 8% each side (which on yours would be ~8mm each side) seems to do the trick for this recording. Might need to do a few more measurements here though.
Comment 2 Christian Hergert 2017-06-26 20:45:21 UTC
(In reply to Peter Hutterer from comment #1)
> sorry about the delay.

No worries!

Is there anything you'd like me to test?
Comment 3 Peter Hutterer 2017-06-26 23:05:29 UTC
Created attachment 132268 [details] [review]
0001-touchpad-increase-palm-edge-zones-to-8.patch

Give this one a try. Simple fix but at least seems to fix it for this recording. There's a lot more complicated stuff we can do, but I wouldn't mind using the simple option here :)
Comment 4 Peter Hutterer 2017-06-28 22:20:16 UTC
Give the branch in Bug 94236 a try too please, it'll help a lot.
Comment 5 Christian Hergert 2017-06-29 06:21:38 UTC
I tried out the libinput branch on github and built/tested git master of mutter/gnome-shell using it.

After about an hour of hacking I only had one misfire. So that is very much improved. I do notice occasionally a wiggle of the mouse (since the cursor will be displayed after being hidden when typing).

It looks like the patch you mentioned in comment 3 was included in that branch, so I didn't try it separately.
Comment 6 Peter Hutterer 2017-07-04 04:37:14 UTC
commit 381cce8ddd07e69bdd68159bd11bd6efef5214a0
Author: Peter Hutterer <peter.hutterer@who-t.net>
Date:   Tue Jun 27 08:59:51 2017 +1000

    touchpad: increase palm edge zones to 8%


and coupled with 

commit 25d54b90db6ac056157a7ad5c807c70b43b23c9b
Author: Peter Hutterer <peter.hutterer@who-t.net>
Date:   Wed Jun 28 13:09:22 2017 +1000

    touchpad: add pressure-base palm detection

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.