Bug 101616

Summary:	Please add check for xmlto in xdg utils
Product:	Portland	Reporter:	cynthia.m.rempel
Component:	xdg-utils	Assignee:	Portland Bugs <portland-bugs>
Status:	RESOLVED MOVED	QA Contact:
Severity:	normal
Priority:	medium
Version:	unspecified
Hardware:	x86-64 (AMD64)
OS:	Linux (All)
Whiteboard:
i915 platform:		i915 features:
Attachments:	Checks for xmlto and errors out if not found Patch that fixes the problem, and doesn't create new one

Description cynthia.m.rempel 2017-06-28 03:15:17 UTC

Ran

./configure --prefix=/home/rfirstaid/xdg-utils/install
make

Got
make[1]: Entering directory '/home/rfirstaid/xdg-utils/scripts'
(cd html;/usr/bin/xmlto html-nochunks ../desc/xdg-desktop-menu.xml)
/bin/sh: 1: /usr/bin/xmlto: not found
Makefile:111: recipe for target 'html/xdg-desktop-menu.html' failed
make[1]: *** [html/xdg-desktop-menu.html] Error 127
make[1]: Leaving directory '/home/rfirstaid/xdg-utils/scripts'
Makefile:25: recipe for target 'scripts' failed
make: *** [scripts] Error 2

Please add check to configure.ac like:

# Check for xmlto (for html documentation, needed only for development)
AC_CHECK_PROGS([XMLTO], [$XMLTO xmlto], [:])
if test "$XMLTO" = ":"; then
  AC_MSG_WARN([xmlto not found, html documentation will not be rebuilt.])
fi

Then only build html target if there is xmlto...

Thanks!
Cindy

Comment 1 cynthia.m.rempel 2017-06-29 03:21:57 UTC

Created attachment 132329 [details] [review]
Checks for xmlto and errors out if not found

Checks for xmlto.

Comment 2 cynthia.m.rempel 2017-06-29 03:38:03 UTC

Created attachment 132330 [details] [review]
Patch that fixes the problem, and doesn't create new one

Comment 3 GitLab Migration User 2019-02-16 13:39:03 UTC

-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/xdg/xdg-utils/issues/110.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.