Bug 101811

internal DCTStream is unmaintained, but there's not really a need to add a patch that breaks it either, please either fix your patch or just stop using unmaintained code and use the DCTStream that uses libjpeg

The clean-up is meant to pacify the compiler complaining about unused or even uninitialized variables in the code given the configuration.

Just to understand what you are saying and to be productive: Where exactly breaks your code, since mine works well under my configuration?

Probably a good idea to make the *compiler* throw either an information or an error that the internal DCTStream is unmaintained and have the dev use the alternative code.

(In reply to Jannick from comment #2)
> The clean-up is meant to pacify the compiler complaining about unused or
> even uninitialized variables in the code given the configuration.
> 
> Just to understand what you are saying and to be productive: Where exactly
> breaks your code, since mine works well under my configuration?

You removed the calls to read16 so the stream is not advanced and thus any subsequent read is wrong. 

> 
> Probably a good idea to make the *compiler* throw either an information or
> an error that the internal DCTStream is unmaintained and have the dev use
> the alternative code.

Which version are you using? You have to explicitly say you want the unmaintained code on configure / cmake time.

-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/poppler/poppler/issues/263.