Bug 101818

Summary:	[PATCH] ./configure --disable-fixedpoint actually enables fixedpoint support
Product:	poppler	Reporter:	Roland Hieber <r.hieber>
Component:	general	Assignee:	poppler-bugs <poppler-bugs>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium
Version:	unspecified
Hardware:	ARM
OS:	Linux (All)
Whiteboard:
i915 platform:		i915 features:
Attachments:	configure.ac: fix --disable-FEATURE actually enabling the feature configure.ac: fix --disable-FEATURE actually enabling the feature [v2]

Description Roland Hieber 2017-07-17 10:30:43 UTC

Created attachment 132731 [details] [review]
configure.ac: fix --disable-FEATURE actually enabling the feature

I'm currently packaging poppler for PTXdist, and I noticed that configure.ac suffers from a frequently seen antipattern, which is to use

  AC_ARG_ENABLE(feature, help, action-if-given, action-if-not-given)

as

  AC_ARG_ENABLE(feature, help, action-if-enabled, action-if-disabled).

However, action-if-given is also evaluated for --disable-FEATURE (with enableval=no), which results in --disable-FEATURE and --enable-FEATURE doing the same in this case.

This patch rewrites this behaviour for the --disable-single-precision, --disable-fixedpoint and --disable-cmyk arguments accordingly, so users are not confused if they want to be explicit about disabling those options.

Comment 1 Roland Hieber 2017-07-17 12:12:54 UTC

Created attachment 132732 [details] [review]
configure.ac: fix --disable-FEATURE actually enabling the feature [v2]

Sorry, that first patch contained a typo, which led to a syntax error in ./configure.

Comment 2 Albert Astals Cid 2017-07-31 17:46:10 UTC

Pushed

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.