|Summary:||autotools: wayland-protocols used even if not found|
|Product:||Mesa||Reporter:||Dylan Baker <baker.dylan.c>|
|Status:||RESOLVED WONTFIX||QA Contact:||mesa-dev|
|i915 platform:||i915 features:|
Description Dylan Baker 2017-07-26 17:42:58 UTC
currently configure.ac will set WAYLAND_PROTOCOLS_DATADIR, and then rely on that variable being set, even if wayland-protocols is not installed, causing the variable to be set to nothing. This causes build failures in src/egl/Makefile.am, since WL_DMABUF_XML will be set to /unstable/... This can be replicated by uninstalling wayland-protocols and running `make distcheck`
Comment 1 Martin Peres 2017-07-26 18:55:00 UTC
Indeed, we stumbled on this yesterday but got distracted with something else. Thanks for reporting the issue Dylan!
Comment 2 Emil Velikov 2017-07-27 12:16:40 UTC
There should be no issue with WL_DMABUF_XML=/unstable/... since it should not be used in said case. Dylan, can you elaborate exactly what you're doing? What kind of error does it trigger? The `make distcheck' failure is expected, although I'll see if I can add more meaningful/timely error message.
Comment 3 Dylan Baker 2017-07-27 17:01:16 UTC
Here's the output from make: make: Entering directory '/home/dylan/source/mesa/distcheck/src/egl' make: *** No rule to make target '/unstable/linux-dmabuf/linux-dmabuf-unstable-v1.xml', needed by 'drivers/dri2/linux-dmabuf-unstable-v1-protocol.c'. Stop. make: Leaving directory '/home/dylan/source/mesa/distcheck/src/egl' make: *** [Makefile:947: distdir] Error 1 make: Leaving directory '/home/dylan/source/mesa/distcheck/src' make: *** [Makefile:752: distdir] Error 1 make: Leaving directory '/home/dylan/source/mesa/distcheck' make: *** [Makefile:850: dist] Error 2 It would be nice to have an error message about a missing dependency rather than make exploding trying to build a target that couldn't possibly exist.
Comment 4 Eric Engestrom 2019-05-01 14:12:58 UTC
Closing this autotools issue, as autotools has now been deleted (see https://gitlab.freedesktop.org/mesa/mesa/merge_requests/601). If you think I may have made a mistake and this issue still needs fixing, feel free to reopen it :)