Bug 1020

Summary: Build failure in libSM on AIX (missing function declaration)
Product: xorg Reporter: Dan McNichol <mcnichol>
Component: Lib/otherAssignee: Xorg Project Team <xorg-team>
Status: RESOLVED FIXED QA Contact:
Severity: blocker    
Priority: high CC: kem, roland.mainz
Version: git   
Hardware: All   
OS: AIX   
Whiteboard:
i915 platform: i915 features:
Bug Depends on:    
Bug Blocks: 351    

Description Dan McNichol 2004-08-09 09:49:03 UTC 
Here is the compiler message:


        xlc -c -O -D__STR31__ -DNDEBUG      -I../.. -I../../exports/include   -
DSYSV -DAIXV3 -DAIXV4 -DAIXV5 -D_ALL_SOURCE       -I../../lib/xtrans -
DTCPCONN -DUNIXCONN   -DHAS_STICKY_DIR_BIT -DHAS_FCHOWN -DIPv6 -DICE_t  -
DSHAREDCODE -bM\:SRE sm_manager.c
"sm_manager.c", line 174.12: 1506-068 (S) Operation between types "char*" 
and "int" is not allowed.
make: The error code from the last command is 1.




Here is a possible patch:

*** xc/lib/SM/sm_manager.c.orig Mon May 24 14:06:58 2004
--- xc/lib/SM/sm_manager.c      Mon Aug  9 10:26:29 2004
***************
*** 164,178 ****
  }
  
  
  

  char *
  SmsClientHostName (smsConn)
  
  SmsConn smsConn;
  
  {
!     return (_IceTransGetPeerNetworkId (smsConn->iceConn->trans_conn));
  }
  
  
  

--- 164,181 ----
  }
  
  
  

+ /* Using private API from libICE. */
+ extern char *_IceGetPeerName (IceConn /* iceConn */);
+ 
  char *
  SmsClientHostName (smsConn)
  
  SmsConn smsConn;
  
  {
!     return (_IceGetPeerName (smsConn->iceConn));
  }
Comment 1 Dan McNichol 2004-08-11 09:24:19 UTC 
A quick note...

This may seem like a minor warning, but on 64-bit systems, these types of bugs
usually result in a crash because the pointer gets truncated.
Comment 2 Dan McNichol 2004-08-13 09:29:50 UTC 
Updating to blocker after feedback from release wranglers call.
Comment 3 Kevin E. Martin 2004-08-18 11:42:02 UTC 
Patch applied.
Closing.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.