| Summary: |
Valgrind error in XStoreColors |
| Product: |
xorg
|
Reporter: |
Ryan C. Gordon <icculus> |
| Component: |
Lib/Xlib | Assignee: |
Xorg Project Team <xorg-team> |
| Status: |
RESOLVED
FIXED
|
QA Contact: |
Xorg Project Team <xorg-team> |
| Severity: |
normal
|
|
|
| Priority: |
medium
|
CC: |
finn.bcd
|
| Version: |
git | |
|
| Hardware: |
All | |
|
| OS: |
All | |
|
| Whiteboard: |
|
|
i915 platform:
|
|
i915 features:
|
|
|---|
| Attachments: |
|
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.
Created attachment 133189 [details] Patch to fix Valgrind bug xColorItem contains a "pad" field that is not initialized by XStoreColor and XStoreColors, so when this struct is written to the Display's send buffer, Valgrind gets upset. This probably _isn't_ a massive information leak sent to a remote server, so it's largely harmless, but Valgrind is correct to mark it as a bug. The more serious concern (for me, at least), is that every SDL-based program that creates a window on an X server triggers this, and those bug reports keep coming to me, so here's a patch to fix it in libx11. :) --ryan.