Bug 102188

Summary:	[PATCH] Clean up Arthur transformation handling
Product:	poppler	Reporter:	oliver.sander
Component:	arthur backend	Assignee:	poppler-bugs <poppler-bugs>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium	CC:	oliver.sander
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	Patch cleaning up the Arthur coordinate transformation handling

Description oliver.sander 2017-08-12 19:45:26 UTC

Created attachment 133460 [details] [review]
Patch cleaning up the Arthur coordinate transformation handling

The handling of coordinate transformations is rather clumsy in the Arthur backend.  Currently, the code does not touch the QPainter world transformation matrix at all.  Rather, there are ad hoc coordinate transformations
scattered throughout the code, which make the code longer than necessary, and more difficult to understand.  This patch does a cleanup: the QPainter transformation matrix is set properly, and the hand-coded transformations are removed.  This should not affect the rendering output, but it makes the current code simpler to read, and future code simpler to write.

Comment 1 Albert Astals Cid 2017-08-13 10:38:41 UTC

Pushed

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.