Bug 10222

Summary:	Add icon-naming-utils-uninstalled.pc file to aid Solaris build environment
Product:	tango	Reporter:	Damien Carbery <damien.carbery>
Component:	icon theme	Assignee:	Rodney Dawes <dobey.pwns>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	medium
Version:	CVS
Hardware:	All
OS:	Solaris
Whiteboard:
i915 platform:		i915 features:
Attachments:	Add uninstalled.pc file to icon-naming-utils and update configure.ac.

Description Damien Carbery 2007-03-08 05:00:10 UTC

As described in bugzilla 9837, on Solaris we group multiple modules into one package. WRT this bug, SUNWgnome-themes includes icon-naming-utils, tango-icon-theme and 8 other modules.

During tango-icon-theme's 'make install' step it calls icon-name-mapping. It gets the path to that script via a pkg-config call.
The attached patch adds an uninstalled.pc file to allow for the finding of the script before icon-naming-utils has been installed.

Comment 1 Damien Carbery 2007-03-08 05:01:36 UTC

Created attachment 9037 [details] [review]
Add uninstalled.pc file to icon-naming-utils and update configure.ac.

Comment 2 Damien Carbery 2007-03-08 05:03:09 UTC

Aside: I hope that this is the write Product/Component for this bug.
I tried to follow the directions at tango.freedesktop.org:
"You can file bugs against the Tango icon library, icon style guideline, and the Icon Naming Specification in freedesktop.org's bugzilla."

Comment 3 Jakub Steiner 2007-03-08 12:24:25 UTC

Assigning to rodney.

Comment 4 Rodney Dawes 2007-08-13 14:03:16 UTC

Fixed in CVS.

Comment 5 Martin Costabel 2007-08-18 02:58:40 UTC

This may fix the Solaris build process, but it breaks other programs that use the *installed* icon-name-mapping.

The file icon-naming-utils-uninstalled.pc should never get installed alongside icon-naming-pc, because now the variable program_name points to ${pcfiledir} which is the directory where icon-naming-pc is installed, and which is not the same as the directory where the icon-name-mapping executable is installed.

Adding icon-naming-utils-uninstalled.pc.in to pkgconfig_in_files in Makefile.am is wrong, because this puts it on the list of files to install, which should not happen. Aren't the other parts of the fix sufficient to make the Solaris build succeed?

Comment 6 Rodney Dawes 2007-08-18 05:25:19 UTC

Doh. Right. Fixed that in CVS.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.