Bug 10226

Summary: "find -not" not portable
Product: cairo Reporter: Thomas Klausner <tk>
Component: generalAssignee: Carl Worth <cworth>
Status: RESOLVED FIXED QA Contact: cairo-bugs mailing list <cairo-bugs>
Severity: normal    
Priority: medium    
Version: 1.4.0   
Hardware: x86-64 (AMD64)   
OS: NetBSD   
i915 platform: i915 features:
Attachments: Patch for RELEASING
Patch for src/check-headers.sh

Description Thomas Klausner 2007-03-08 13:32:49 UTC
cairo-1.4.0 uses "find -not".
The man page for GNU find says:
       -not expr
              Same as ! expr, but not POSIX compliant.

And actually, on e.g. NetBSD, "-not" is not supported.
Please use "!" instead.
I'll attach patches.
Comment 1 Thomas Klausner 2007-03-08 13:33:42 UTC
Created attachment 9045 [details] [review]
Comment 2 Thomas Klausner 2007-03-08 13:34:17 UTC
Created attachment 9046 [details] [review]
Patch for src/check-headers.sh
Comment 3 Carl Worth 2007-03-16 09:24:27 UTC
Thanks for the report, and the fix. This is pushed now into cairo 1.4.1, (and soon to appear in the 1.4.2 release). See here:



Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.