Bug 102391

Summary: x11-libs/libdrm-2.4.83: fatal error: uve_ib.h: No such file or directory
Product: DRI Reporter: Kobboi <freedesktop>
Component: DRM/AMDgpuAssignee: Boyuan Zhang <boyuan.zhang>
Status: RESOLVED FIXED QA Contact: Default DRI bug account <dri-devel>
Severity: normal    
Priority: medium CC: alexdeucher, ckoenig.leichtzumerken, EoD, pmenzel+bugs.freedesktop.org
Version: unspecified   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments:
Description Flags
build.log none

Description Kobboi 2017-08-24 15:16:58 UTC 
Created attachment 133754 [details]
build.log

WIth the source tarball from https://dri.freedesktop.org/libdrm/${P}.tar.bz2, I get, on a Gentoo system:

(...)
Making all in radeon
libtool: link: x86_64-pc-linux-gnu-gcc -Wall -Wextra -Wsign-compare -Werror-implicit-function-declaration -Wpointer-arith -Wwrite-strings -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wnested-externs -Wpacked -Wswitch-enum -Wmissing-format-attribute -Wstrict-aliasing=2 -Winit-self -Wdeclaration-after-statement -Wold-style-definition -Wno-unused-parameter -Wno-attributes -Wno-long-long -Winline -Wshadow -Wno-missing-field-initializers -I /var/tmp/portage/x11-libs/libdrm-2.4.83/work/libdrm-2.4.83/include/drm -I /var/tmp/portage/x11-libs/libdrm-2.4.83/work/libdrm-2.4.83 -O2 -march=native -pipe -fomit-frame-pointer -Wl,-O1 -o .libs/radeon_ttm rbo.o radeon_ttm.o  -Wl,--as-needed ../../.libs/libdrm.so -lm
Making all in amdgpu
/var/tmp/portage/x11-libs/libdrm-2.4.83/work/libdrm-2.4.83/tests/amdgpu/basic_tests.c: In function ‘amdgpu_userptr_test’:
/var/tmp/portage/x11-libs/libdrm-2.4.83/work/libdrm-2.4.83/tests/amdgpu/basic_tests.c:1369:2: warning: ignoring return value of ‘posix_memalign’, declared with attribute warn_unused_result [-Wunused-result]
  posix_memalign(&ptr, sysconf(_SC_PAGE_SIZE), BUFFER_SIZE);
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/var/tmp/portage/x11-libs/libdrm-2.4.83/work/libdrm-2.4.83/tests/amdgpu/uvd_enc_tests.c:39:20: fatal error: uve_ib.h: No such file or directory
 #include "uve_ib.h"
                    ^
compilation terminated.
make[3]: *** [amdgpu_test-uvd_enc_tests.o] Error 1
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [all-recursive] Error 1
make[1]: *** [all-recursive] Error 1

Full build log in attachment
Comment 1 Matt Turner 2017-08-30 02:22:06 UTC 
This is because the headers added in

commit 9d133dd08720d80dfc8ce098bf0972ebd05c454d
Author: Boyuan Zhang <boyuan.zhang@amd.com>
Date:   Tue Aug 15 11:33:43 2017 -0400

    tests/amdgpu: add uvd encode unit tests

were not added to the relevant _SOURCES variable, so they were not included in the tarball by make dist.

It wasn't caught by make distcheck because of the "automagic" dependency on cunit. The tests are silently disabled if cunit is not found.
Comment 2 Matt Turner 2017-09-01 19:16:02 UTC 
Looks like Alex committed a fix but forgot to close this bug.

commit 05a830d382382905d87b55af90aa109fb76e4c16
Author: Alex Deucher <alexander.deucher@amd.com>
Date:   Wed Aug 30 14:00:18 2017 -0400

    tests/amdgpu: add missing header to SOURCES
    
    Fixes the tarball generation.
    
    fixes: 9d133dd08720d80dfc8ce098bf0972 (tests/amdgpu: add uvd encode unit tests)
    bug: https://bugs.freedesktop.org/show_bug.cgi?id=102391
    Reviewed-by: Christian König <christian.koenig@amd.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Comment 3 Timo Aaltonen 2017-09-06 06:59:24 UTC 
needs a new tarball now
Comment 4 EoD 2017-10-06 18:21:38 UTC 
(In reply to Timo Aaltonen from comment #3)
> needs a new tarball now

Is there going to be a new tarball for libdrm-2.4.83?

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.