Bug 102395

Summary:	[patch]Add support for trinity in xdg-utils
Product:	Portland	Reporter:	wofgdkncxojef
Component:	xdg-utils	Assignee:	Portland Bugs <portland-bugs>
Status:	RESOLVED MOVED	QA Contact:
Severity:	normal
Priority:	medium
Version:	1.1.0
Hardware:	All
OS:	All
Whiteboard:
i915 platform:		i915 features:
Attachments:	compatibility patch for trinity desktop fixed patch ... probably

Description wofgdkncxojef 2017-08-24 17:47:17 UTC

Like the title sais.
trinity is KDE3 that is still been maintained.
It's like MATE.

The code is alredy in there, it's the code for KDE3.
Simply changing line 384 from "KDE)" to "KDE|Trinity)"

and in function "kfmclient_fix_exit_code()"
add
"if [ "$XDG_CURRENT_DESKTOP" = KDE ]; then fi"

around the block of code, excluding the "return 0"

and it's done.

Comment 1 wofgdkncxojef 2017-08-25 14:32:55 UTC

actually, all xdg-utils are structured the same way.
The above modification will probably make all of them compatible with trinity

Comment 2 wofgdkncxojef 2017-08-30 14:59:40 UTC

Created attachment 133886 [details] [review]
compatibility patch for trinity desktop

forget the above.

Here's a proposed patch.
It's against the current 1.1.3
It patches open, email, settings, mime, screensaver.

(warning, i never send a patch before)

Comment 3 Rex Dieter 2017-11-29 20:13:25 UTC

Thanks for the patch, but I can't apply it:

$ patch -p1 < attachment.cgi\?id\=133886 
patch: **** Only garbage was found in the patch input.

Mind regenerating it, and as a unified diff this time?  use diff -ur

Comment 4 wofgdkncxojef 2017-11-30 01:30:47 UTC

Created attachment 135825 [details] [review]
fixed patch ... probably

i used this command now(1.1.3):
"diff -ur xdg-utils.new/ xdg-utils.orig/ > xdg-trinity-0.2.patch"

Hey...i'm just a script kiddie :D

Comment 5 GitLab Migration User 2019-02-16 13:39:24 UTC

-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/xdg/xdg-utils/issues/115.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.