Bug 102425

Summary: Old-Hungarian layout patch
Product: xkeyboard-config Reporter: Kovács Viktor <kovacs.viktor.dev>
Component: GeneralAssignee: Kovács Viktor <kovacs.viktor.dev>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: highest CC: kovacs.viktor.dev, socialonyourdesktop, svu
Version: unspecifiedKeywords: patch
Hardware: Other   
OS: All   
See Also: https://bugs.freedesktop.org/show_bug.cgi?id=107496
Whiteboard:
i915 platform: i915 features:
Attachments: hu file extended with "oldhu" variant, named "Szekely-Hungarian"
Old Hungarian layout patch
Old Hungarian font
Old Hungarian patch again
Old Hungarian patch final
Old Hungarian layout (it works under xubuntu)
Old Hungarian Patch
Old Hungarian Layout

Description Kovács Viktor 2017-08-27 09:39:44 UTC
Created attachment 133810 [details]
hu file extended with "oldhu" variant, named "Szekely-Hungarian"

There are not exist Old Hungarian (Or Szekely-Hungarian) keyboard layout yet.
I grant an implementation of that in base hu file. Short name is oldhun, description (full name) is "Szekely-Hungarian".
It required for writing UNICODE Old Hungarian script.
Hu file attached.
Comment 1 Sergey V. Udaltsov 2017-08-27 09:43:17 UTC
Could you please also make a patch (not the full file!) for base.extras.xml.in?
Thank you
Comment 2 Kovács Viktor 2017-08-27 09:51:29 UTC
<variant>
          <configItem>
            <name>oldhun</name>
            <description>Szekely-Hungarian</description>
          </configItem>
        </variant>
Comment 3 Kovács Viktor 2017-08-27 09:51:56 UTC
It is enought?
Comment 4 Kovács Viktor 2017-08-27 11:53:48 UTC
Really I beginner, so I don't know, how must to make patch you required.
Comment 5 Socialdarwinist 2017-08-27 17:12:39 UTC
You do it preferably with git. That’s the software wherewith programmers work on different versions of their programs. So you have to have git installed (likely there is a package with this name in your distribution’s repository).

If you have git, you go to some folder, open a terminal at that folder and type in the terminal: ”git clone git://anongit.freedesktop.org/git/xkeyboard-config”
Therewith you get a copy of the keyboard layouts and all stuff you need. Thereafter you cd into the new folder, the cloned repository of xkeyboard-config, (cd ./xkeyboard-config) write “git checkout -b oldhungarian” to create a new branch where you develop called “oldhungarian”, i.e. whereafter you manipulate the symbols/hu file. What Sergey V. Udaltsov wants and is necessary for your layout being visible is that you also manipulate the rules/base.extras.xml.in file.
As I do not see any Hungarian layout there, you probably have to add


    <layout>
       <configItem>
        <name>hu</name>
        <_shortDescription>hu</_shortDescription>
        <_description>Hungarian</_description>
       </configItem>
      <variantList>
        <variant>
         <configItem>
            <name>oldhun</name>
            <_shortDescription>hu</_shortDescription>
            <_description>Szekely Hungarian</_description>
         </configItem>
        </variant>
      </variantList>
    </layout>

Please take care that the indentation of your changes is orderly and coherent with the other contents of the files. Right now your layout looks messy. Please make it appear more “table-like”, so the eyes of people looking into the file have it easier to see what’s on each level.

If it’s your first time using git, you should save your name and e-mail in git:
git config --global user.name "Kovács Viktor"
git config --global user.email an-email@example.com

If you do not use the “--global” flag, it will set the name and e-mail for the single cloned repository only.

When you are done, you add your changes to your local commit history by writing in the terminal: git commit -m "Added Old Hungarian keyboard layout" -a.

Thereof you can create your patch. Put into the terminal: git format-patch master --stdout > oldhungarian.patch.
You will have a patch file called oldhungarian.patch created by the difference from the branch you have developed to the thitherto official branch that you can upload here. Sergey can add your changes with a single command in his own copy of xkeyboard-config. Swell. Now your name will be eternal in the commit history of xkeyboard-config.

Sergey V. Udaltsov: Is it feasible to use UTF-8 in layout names? I could imagine him writing “Székely Hungarian” instead of “Szekely Hungarian”.

Viktor Kovács: Coincidentally, I have just yesterday read about the Old Hungarian alphabet that has been added in 2015 to Unicode. I am affected by glee that somebody has made a keyboard layout for it. What fonts are useable for displaying Old Hungarian glyphs?
Comment 6 Kovács Viktor 2017-08-28 06:52:06 UTC
Created attachment 133825 [details] [review]
Old Hungarian layout patch

Sergey V. Udaltsov: there is a Old Hungarian layout patch.
I hope, I did not any mistake.
Comment 7 Kovács Viktor 2017-08-28 06:58:59 UTC
Created attachment 133826 [details]
Old Hungarian font

There is an Old-Hungarian font developed myself.
It has a small mistake: Old Hungarian Oee and oee has not perfectly correct.
Comment 8 Socialdarwinist 2017-08-28 09:08:15 UTC
As for errors, you have written
<_shortDescription>hu<_shortDescription> – missing a slash in the end tag

Additionally, the indentation is ugly.

You should probably tell us too what the point of the other changes in your patch is, like changing QWERTZ for qwertz and “no dead keys” to “eliminate dead keys”.

If you want to fix your commit, you can either work from a new branch again or you for example reset the history of your new branch with “git reset --soft 8824e4e17bed27f160c15a519fc09b7856443d05” (the hash being the last official commit). You can see commits by doing for example “git log -4” to see the last four commits.
Comment 9 Kovács Viktor 2017-08-28 12:43:01 UTC
Created attachment 133837 [details] [review]
Old Hungarian patch again

Because I did something wrong, I started all from the begin.
I yust add oldhun layout.
QWERTZ means, that in the original Hungarian typewriter standard z and y place is different with international standards, and the main Hungarian keyboard standard adopted it.

I hope, it hasn't got any mistake.
Comment 10 Kovács Viktor 2017-08-28 23:05:53 UTC
Socialdarwinist: Need I anithing to do?
Comment 11 Kovács Viktor 2017-08-28 23:21:49 UTC
We must to rename Székely-Hungarian to Old Hungarian, because of the politics.
Comment 12 Kovács Viktor 2017-08-28 23:40:05 UTC
Comment on attachment 133837 [details] [review]
Old Hungarian patch again

>From 815029fc6f3d270a6b03888b20810e7663a4ba32 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Viktor=20Kov=C3=A1cs?= <kovacs.viktor.dev@gmail.com>
>Date: Mon, 28 Aug 2017 14:27:37 +0200
>Subject: [PATCH] Added Old Hungarian keyboard layout
>
>---
> rules/base.extras.xml.in |  17 +++++++
> symbols/hu               | 113 ++++++++++++++++++++++++++++++++++++++++++++++-
> 2 files changed, 129 insertions(+), 1 deletion(-)
>
>diff --git a/rules/base.extras.xml.in b/rules/base.extras.xml.in
>index d64d79b..441b053 100644
>--- a/rules/base.extras.xml.in
>+++ b/rules/base.extras.xml.in
>@@ -994,6 +994,23 @@
>         </variant>
>       </variantList>
>     </layout>
>+<layout>
>+       <configItem>
>+        <name>hu</name>
>+        <_shortDescription>hu</_shortDescription>
>+        <_description>Hungarian</_description>
>+       </configItem>
>+      <variantList>
>+        <variant>
>+         <configItem>
>+            <name>oldhun</name>
>+            <_shortDescription>hu</_shortDescription>
>+            <_description>Székely-Hungarian</_description>
>+         </configItem>
>+        </variant>
>+      </variantList>
>+    </layout>
>+
>   </layoutList>
>   <optionList>
>       <group allowMultipleSelection="true">
>diff --git a/symbols/hu b/symbols/hu
>index 677a5b6..05cbf43 100644
>--- a/symbols/hu
>+++ b/symbols/hu
>@@ -4,7 +4,8 @@
> //
> // (C) 2002-2004 Soós Péter <sp@osb.hu>
> // (C) 2010 Andras Timar <timar@fsf.hu>
>-//
>+// (C) 2013 András Tisza
>+// (C) 2017 Viktor Kovács <kovacs.viktor.dev@gmail.com>
> // Permission is granted to anyone to use, distribute and modify
> // this file in any way, provided that the above copyright notice
> // is left intact and the author of the modification summarizes
>@@ -22,6 +23,9 @@
> //             - Added rightdoublequotemark
> //             - Added endash
> //  2010-05-13 - Added ellipsis
>+// 2017-08-28 -Added oldhun layout by plans of András Tisza
>+//            -Added Right-to-left mark to oldhun
>+//	      -Added Left-to-right mark to oldhun
> 
> 
> // Default layout
>@@ -430,3 +434,110 @@ xkb_symbols "def_common" {
>     key <AB10>  { [        minus,   underscore,          asterisk                  ] };
> 
> };
>+
>+
>+partial alphanumeric_keys
>+xkb_symbols "oldhun"{
>+name[Group1]="Székely-Hungarian";
>+include "capslock(capslock)"
>+include "level3(ralt_switch)"
>+key.type="FOUR_LEVEL_SEMIALPHABETIC";
>+    key <AE01> {[U10CFA,         apostrophe,1,asciitilde    ]};
>+    
>+    key <AE02> {[                 U10CFB   ,	U201E,2, U201F]};
>+    
>+    key <AE03> {[                 U10CFC,plus,3,	asciicircum]};
>+    
>+    key <AE04> {[       U10CFD,	exclam,	4,	U2E2E]};
>+    
>+    key <AE05> {[       U10CFE,	percent,5,	degree]};
>+    
>+    key <AE06> {[       U10CFF,	slash, 6,   backslash]};
>+ 
>+    key <AE07> {[U10CC6,	U10C86,	7,	equal]};
>+    
>+    key <AE08> {[ U10CDA,	U10C9A,	8,	parenleft]};
>+    
>+    key <AE09> {[U10CE8,	U10CA8,	9,	parenright]};
>+    
>+    key <AE10> {[     U10CDE,     U10C9E,    U10CDD,       U10C9D          ]};
>+    
>+    key <AE11> {[U10CED,         U10CAD,	NoSymbol,	NoSymbol]};
>+    
>+    key <AE12> {[U10CDC,         U10C9C,	NoSymbol,	NoSymbol ]};
>+    
>+    key <AD01> {[U10CCE,         U10C8E,	backslash,	NoSymbol    ]};
>+    
>+    key <AD02> {[U10CF0,         U10CB0,	NoSymbol,	NoSymbol     ]};
>+    
>+    key <AD03> {[U10CC9,         U10C89,       U10CCA,         U10C8A ]};
>+    
>+    key <AD04> {[U10CE2,         U10CA2,       U10CE3,         U10CA3 ]};
>+    
>+    key <AD05> {[     U10CE6,         U10CA6,       U10CF1,         U10CB1 ]};
>+    
>+    key <AD06> {[U10CEF,         U10CAF,	NoSymbol,	NoSymbol ]};
>+    
>+    key <AD07> {[U10CEA,         U10CAA,       U10CF2,         U10CB2 ]};
>+    
>+    key <AD08> {[U10CD0,         U10C90,	NoSymbol,	NoSymbol        ]};
>+    
>+    key <AD09> {[U10CDB,         U10C9B,	NoSymbol,	NoSymbol                                 ]};
>+    
>+    key <AD10> {[U10CE0,         U10CA0,	NoSymbol,	NoSymbol        ]};
>+    
>+    key <AD11> {[U10CDF,         U10C9F,	NoSymbol,	NoSymbol]};
>+    
>+    key <AD12> {[     U10CEB,         U10CAB,        U10CD5,         U10C95]};
>+   
>+    key <AC01> {[ U10CC0  ,       U10C80,       U10CC3,         U10C83 ]};
>+    
>+    key <AC02> {[U10CE4,         U10CA4,       U10CE1,         U10CA1 ]};
>+    
>+    key <AC03> {[     U10CC7,         U10C87,       U10CE7,         U10CA7 ]};
>+    
>+    
>+    key <AC07> {[      U10CD2,         U10C92,       backslash,        NoSymbol ]};
>+    
>+    key <AC08> {[U10CD3,         U10C93,       U10CD4,         U10C94 ]};
>+    
>+    key <AC09> {[U10CD6,         U10C96,	NoSymbol,	NoSymbol]};
>+    
>+    key <AC10> {[U10CCB,         U10C8B,	NoSymbol,	NoSymbol]};
>+    
>+    key <AC11> {[U10CC1,         U10C81 ,	U10CC8,	U10C88]};
>+	
>+	
>+     
>+    key <BKSL> {[U10CEC,         U10CAC,	NoSymbol,	NoSymbol]};
>+    
>+    key <AB01> {[ U10CD7,         U10C97,	greater, 	NoSymbol ]};
>+    
>+    key <AB02> {[ U10CE5,         U10CA5,	numbersign ,	NoSymbol]};
>+    
>+    key <AB03> {[     U10CC4,         U10C84,       U10CC5,         U10C85 ]};
>+    
>+    key <AB04> {[U10CEE,         U10CAE,	at,	copyright]};
>+    
>+    key <AB05> {[U10CC2,         U10C82,	braceleft,	NoSymbol       ]};
>+    
>+    key <AB06> { [       U10CD9,         U10C99  ,	braceright,	NoSymbol     ]};
>+    
>+    key <AB07> {[     U10CD8,         U10C98 ,	less,	NoSymbol]};
>+    
>+    key <AB08> {[U2E41,     U2E2E,         U204F   ,	NoSymbol               ]};
>+    
>+    key <AB09> {[period,        colon, 	greater,	NoSymbol                    ]};
>+    
>+    key <AB10> {[minus,   underscore,          asterisk               ,	NoSymbol   ]};
>+    
>+	key <LSGT> {[U10CD1,         U10C91,	less,	NoSymbol]};
>+	
>+	key <TLDE> {[	section,	U200F,	0,	U200E]};
>+
>+key <AC04> {[U10CCC,         U10C8C,	bracketleft,	NoSymbol]};
>+    
>+    key <AC05> {[     U10CCD,         U10C8D,       bracketright,	NoSymbol ]};
>+    
>+    key <AC06> {[     U10CCF,         U10C8F,       U10CE9,         U10CA9 ]};
>+    };
>-- 
>2.7.4
>
Comment 13 Kovács Viktor 2017-08-29 00:38:39 UTC
Comment on attachment 133837 [details] [review]
Old Hungarian patch again

>From 815029fc6f3d270a6b03888b20810e7663a4ba32 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Viktor=20Kov=C3=A1cs?= <kovacs.viktor.dev@gmail.com>
>Date: Mon, 28 Aug 2017 14:27:37 +0200
>Subject: [PATCH] Added Old Hungarian keyboard layout
>
>---
> rules/base.extras.xml.in |  17 +++++++
> symbols/hu               | 113 ++++++++++++++++++++++++++++++++++++++++++++++-
> 2 files changed, 129 insertions(+), 1 deletion(-)
>
>diff --git a/rules/base.extras.xml.in b/rules/base.extras.xml.in
>index d64d79b..441b053 100644
>--- a/rules/base.extras.xml.in
>+++ b/rules/base.extras.xml.in
>@@ -994,6 +994,23 @@
>         </variant>
>       </variantList>
>     </layout>
>+<layout>
>+       <configItem>
>+        <name>hu</name>
>+        <_shortDescription>hu</_shortDescription>
>+        <_description>Hungarian</_description>
>+       </configItem>
>+      <variantList>
>+        <variant>
>+         <configItem>
>+            <name>oldhun</name>
>+            <_shortDescription>hu</_shortDescription>
>+            <_description>Old Hungarian</_description>
>+         </configItem>
>+        </variant>
>+      </variantList>
>+    </layout>
>+
>   </layoutList>
>   <optionList>
>       <group allowMultipleSelection="true">
>diff --git a/symbols/hu b/symbols/hu
>index 677a5b6..05cbf43 100644
>--- a/symbols/hu
>+++ b/symbols/hu
>@@ -4,7 +4,8 @@
> //
> // (C) 2002-2004 Soós Péter <sp@osb.hu>
> // (C) 2010 Andras Timar <timar@fsf.hu>
>-//
>+// (C) 2013 András Tisza
>+// (C) 2017 Viktor Kovács <kovacs.viktor.dev@gmail.com>
> // Permission is granted to anyone to use, distribute and modify
> // this file in any way, provided that the above copyright notice
> // is left intact and the author of the modification summarizes
>@@ -22,6 +23,9 @@
> //             - Added rightdoublequotemark
> //             - Added endash
> //  2010-05-13 - Added ellipsis
>+// 2017-08-28 -Added oldhun layout by plans of Andrá.s Tisza
>+//            -Added Right-to-left mark to oldhun
>+//	      -Added Left-to-right mark to oldhun
> 
> 
> // Default layout
>@@ -430,3 +434,110 @@ xkb_symbols "def_common" {
>     key <AB10>  { [        minus,   underscore,          asterisk                  ] };
> 
> };
>+
>+
>+partial alphanumeric_keys
>+xkb_symbols "oldhun"{
>+name[Group1]"Old Hungarian";
>+include "capslock(capslock)"
>+include "level3(ralt_switch)"
>+key.type="FOUR_LEVEL_SEMIALPHABETIC";
>+    key <AE01> {[U10CFA,         apostrophe,1,asciitilde    ]};
>+    
>+    key <AE02> {[                 U10CFB   ,	U201E,2, U201F]};
>+    
>+    key <AE03> {[                 U10CFC,plus,3,	asciicircum]};
>+    
>+    key <AE04> {[       U10CFD,	exclam,	4,	U2E2E]};
>+    
>+    key <AE05> {[       U10CFE,	percent,5,	degree]};
>+    
>+    key <AE06> {[       U10CFF,	slash, 6,   backslash]};
>+ 
>+    key <AE07> {[U10CC6,	U10C86,	7,	equal]};
>+    
>+    key <AE08> {[ U10CDA,	U10C9A,	8,	parenleft]};
>+    
>+    key <AE09> {[U10CE8,	U10CA8,	9,	parenright]};
>+    
>+    key <AE10> {[     U10CDE,     U10C9E,    U10CDD,       U10C9D          ]};
>+    
>+    key <AE11> {[U10CED,         U10CAD,	NoSymbol,	NoSymbol]};
>+    
>+    key <AE12> {[U10CDC,         U10C9C,	NoSymbol,	NoSymbol ]};
>+    
>+    key <AD01> {[U10CCE,         U10C8E,	backslash,	NoSymbol    ]};
>+    
>+    key <AD02> {[U10CF0,         U10CB0,	NoSymbol,	NoSymbol     ]};
>+    
>+    key <AD03> {[U10CC9,         U10C89,       U10CCA,         U10C8A ]};
>+    
>+    key <AD04> {[U10CE2,         U10CA2,       U10CE3,         U10CA3 ]};
>+    
>+    key <AD05> {[     U10CE6,         U10CA6,       U10CF1,         U10CB1 ]};
>+    
>+    key <AD06> {[U10CEF,         U10CAF,	NoSymbol,	NoSymbol ]};
>+    
>+    key <AD07> {[U10CEA,         U10CAA,       U10CF2,         U10CB2 ]};
>+    
>+    key <AD08> {[U10CD0,         U10C90,	NoSymbol,	NoSymbol        ]};
>+    
>+    key <AD09> {[U10CDB,         U10C9B,	NoSymbol,	NoSymbol                                 ]};
>+    
>+    key <AD10> {[U10CE0,         U10CA0,	NoSymbol,	NoSymbol        ]};
>+    
>+    key <AD11> {[U10CDF,         U10C9F,	NoSymbol,	NoSymbol]};
>+    
>+    key <AD12> {[     U10CEB,         U10CAB,        U10CD5,         U10C95]};
>+   
>+    key <AC01> {[ U10CC0  ,       U10C80,       U10CC3,         U10C83 ]};
>+    
>+    key <AC02> {[U10CE4,         U10CA4,       U10CE1,         U10CA1 ]};
>+    
>+    key <AC03> {[     U10CC7,         U10C87,       U10CE7,         U10CA7 ]};
>+    
>+    
>+    key <AC07> {[      U10CD2,         U10C92,       backslash,        NoSymbol ]};
>+    
>+    key <AC08> {[U10CD3,         U10C93,       U10CD4,         U10C94 ]};
>+    
>+    key <AC09> {[U10CD6,         U10C96,	NoSymbol,	NoSymbol]};
>+    
>+    key <AC10> {[U10CCB,         U10C8B,	NoSymbol,	NoSymbol]};
>+    
>+    key <AC11> {[U10CC1,         U10C81 ,	U10CC8,	U10C88]};
>+	
>+	
>+     
>+    key <BKSL> {[U10CEC,         U10CAC,	NoSymbol,	NoSymbol]};
>+    
>+    key <AB01> {[ U10CD7,         U10C97,	greater, 	NoSymbol ]};
>+    
>+    key <AB02> {[ U10CE5,         U10CA5,	numbersign ,	NoSymbol]};
>+    
>+    key <AB03> {[     U10CC4,         U10C84,       U10CC5,         U10C85 ]};
>+    
>+    key <AB04> {[U10CEE,         U10CAE,	at,	copyright]};
>+    
>+    key <AB05> {[U10CC2,         U10C82,	braceleft,	NoSymbol       ]};
>+    
>+    key <AB06> { [       U10CD9,         U10C99  ,	braceright,	NoSymbol     ]};
>+    
>+    key <AB07> {[     U10CD8,         U10C98 ,	less,	NoSymbol]};
>+    
>+    key <AB08> {[U2E41,     U2E2E,         U204F   ,	NoSymbol               ]};
>+    
>+    key <AB09> {[period,        colon, 	greater,	NoSymbol                    ]};
>+    
>+    key <AB10> {[minus,   underscore,          asterisk               ,	NoSymbol   ]};
>+    
>+	key <LSGT> {[U10CD1,         U10C91,	less,	NoSymbol]};
>+	
>+	key <TLDE> {[	section,	U200F,	0,	U200E]};
>+
>+key <AC04> {[U10CCC,         U10C8C,	bracketleft,	NoSymbol]};
>+    
>+    key <AC05> {[     U10CCD,         U10C8D,       bracketright,	NoSymbol ]};
>+    
>+    key <AC06> {[     U10CCF,         U10C8F,       U10CE9,         U10CA9 ]};
>+    };
>-- 
>2.7.4
>
Comment 14 Kovács Viktor 2017-08-29 04:34:13 UTC
(In reply to Socialdarwinist from comment #8)
> As for errors, you have written
> <_shortDescription>hu<_shortDescription> – missing a slash in the end tag
> 
> Additionally, the indentation is ugly.
> 
> You should probably tell us too what the point of the other changes in your
> patch is, like changing QWERTZ for qwertz and “no dead keys” to “eliminate
> dead keys”.
> 
> If you want to fix your commit, you can either work from a new branch again
> or you for example reset the history of your new branch with “git reset
> --soft 8824e4e17bed27f160c15a519fc09b7856443d05” (the hash being the last
> official commit). You can see commits by doing for example “git log -4” to
> see the last four commits.

I starded from the begining. I added a new patch.
Comment 15 Kixi 2017-09-03 02:09:00 UTC
(In reply to Socialdarwinist from comment #8)
> As for errors, you have written
> <_shortDescription>hu<_shortDescription> – missing a slash in the end tag
> 
> Additionally, the indentation is ugly.
> 
> You should probably tell us too what the point of the other changes in your
> patch is, like changing QWERTZ for qwertz and “no dead keys” to “eliminate
> dead keys”.
> 
> If you want to fix your commit, you can either work from a new branch again
> or you for example reset the history of your new branch with “git reset
> --soft 8824e4e17bed27f160c15a519fc09b7856443d05” (the hash being the last
> official commit). You can see commits by doing for example “git log -4” to
> see the last four commits.

I have a stupid question. This layout adopted?
Comment 16 Kixi 2017-09-03 04:40:47 UTC
It is adopted?
Comment 17 Socialdarwinist 2017-09-07 16:44:14 UTC
No, the change is not adopted, see the commit log https://cgit.freedesktop.org/xkeyboard-config/log/, and I think that the reason of it is the OP having set the status to “fixed” which causes the maintainers to ignore issues – note that I do not maintain xkeyboard-config, I have only explained how to use git and that there are differences in indentation pulchritude.
Comment 18 Kixi 2017-09-08 07:11:06 UTC
I asked because it in that form will not work. I tested it, therre are problems because hu language have a non utf codepage too.
Comment 19 Kixi 2017-09-08 10:32:42 UTC
Sergey V Udaltsov! Old Hugarian layout does not work with hun identification, because Hungarian language have a non unicode character codepage too. It supported by Linux kernel, thats true, kernel grant a converter routine too. I am thinkig what we should to do.
Comment 20 Socialdarwinist 2017-09-08 17:18:57 UTC
Kiwi! One cannot understand what you are talking about. Codepages and the Linux kernel have no specific relevance here. What does it mean that the “Hungarian language has a non-unicode character codepage”? Languages do not “have” codepages. Codepages are used for writing down various characters on a computer, and so far I see only UTF-8.
Comment 21 Kixi 2017-09-08 18:29:16 UTC
I am talk about iso-8859-2. Look at comment 12.! What do you think, why got a mistake word Székely? Because originally was an utf text, but the text editor tried to save with iso-8859-2 code. Viktor tried correct himself, but forgot the word "Székely". Older hungarian homepages had used that codepage frequently. When I made first homepage, I had more problems about it!
Comment 22 Kixi 2017-09-08 18:55:51 UTC
Microsoft Windows have almost every ui function in two variant: utf-16, and "Ascii". The 2nd one means, that use as "one national character just only one byte" philosophy. The additional info is the language. Iso-8859-2 codepage uses the same philosophy.
Comment 23 Kixi 2017-09-08 22:51:17 UTC
Socialdarvin,
my question is the following: how can I test the newest patches? 

Ps.: I not understand enough Linux kernel, but the codepages bug exist, it can be that not in the kernel.
Comment 24 Socialdarwinist 2017-09-09 10:57:38 UTC
One way to test the patch is: Copy it into your local clone of xkeyboard-config (git clone git://anongit.freedesktop.org/git/xkeyboard-config), git checkout -b oldhungarian to go to a throwaway branch of the repository, and write git am < oldhungarian.patch to apply it to the branch of your repository you have made. Then you take the resulting symbols/hu file and replace the /usr/share/X11/xkb/symbols/hu file with it (do a backup of this first).

The recent version of his patch seems to be in comment 13 which does not exhibit the bug in the encoding because it does not use the word “Székely”. And that seems to be okay because the script is rarely called “Székely Hungarian” in English. Also Sergey V. Udaltsov still has to answer if an e with acute causes technical problems. I tend to assume not because it is XML and specifies UTF-8 at its beginning, but there are quite some programs through the localization up to the display of the layout names.

But I deny that the encoding in the patch of comment 12 is wrong. First Bugzilla sends the text file https://bugs.freedesktop.org/attachment.cgi?id=133837 without specifying an encoding in the HTTPS header: “Content-Type: text/plain; name="oldhungarian.patch"; charset=” (sic!) – it is arguable if Bugzilla should specify the encoding of text files as UTF-8.

Then Firefox interprets the signs as CP-1252. That’s a bug in Firefox. If you manually set the encoding to UTF-8, all looks good. Here you have another recent complaint about it: https://superuser.com/questions/1215064/change-firefox-default-encoding-for-text-files/1247739 Related: https://bugzilla.mozilla.org/show_bug.cgi?id=1338797 https://bugzilla.mozilla.org/show_bug.cgi?id=1224239
Vivaldi and Midori do the same. I have even tested it on Internet Explorer Mobile where the concrete fallback codepage apparently depends on the locale. The browsers are bugged. But the patches are in UTF-8.
Comment 25 Kixi 2017-09-09 12:18:02 UTC
Thanks!
Comment 26 Kixi 2017-09-10 20:35:02 UTC
How can I undo modifications? It seems, that one is only on my computer, but I found mistakes on my work!
Comment 27 Socialdarwinist 2017-09-11 01:07:06 UTC
If you mean the system keyboard layout files, I told you to make a backup of /usr/share/X11/xkb/symbols/hu. Analogously with the base.extras.xml.in and evdev.extras.xml.in. If you can’t just copy your backup onto it, you can reinstall the xkeyboard-config package.

If you mean how to undo changes in your git repository, just git checkout master, git branch -d oldhungarian and the branch is gone (it will tell you to use a capital D to really delete). Then you can again create a branch oldhungarian. Another method is just to do git reset --hard master in your oldhungarian branch. (git reset --soft and git reset --mixed only resets the commit history but leaves the files unchanged. You can also reset to specific commits instead of to the state of your local master, or to the state of the remote repository origin/master, which should be identical in your case). If you have messed up with uncommitted changes, there are many ways to fix it https://stackoverflow.com/questions/14075581/git-undo-all-uncommitted-changes, personally I use git stash save.
Comment 28 Kixi 2017-09-12 14:33:48 UTC
I did something wrong. However I started from the beginings, it makes zero-size patch file.
git clone ... (etc. , it works)
cd xkeyboard-config (...it works)
git checkout -b oldhungarian (...no error messages)
..I do the modifications in files, save its.
git format-patch master --stdout > oldhungarian.patch
Comment 29 Kovács Viktor 2017-09-13 07:39:13 UTC
Created attachment 134192 [details] [review]
Old Hungarian patch final

Final patch of Old Hungarian layout.
Comment 30 Kovács Viktor 2017-09-13 07:41:33 UTC
What will be the next step?
Comment 31 Kovács Viktor 2017-09-16 14:04:08 UTC
Created attachment 134273 [details] [review]
Old Hungarian layout (it works under xubuntu)

Previous patch has got mistakes.
It I tested perfectly.
Comment 32 Kovács Viktor 2017-09-17 05:49:48 UTC
(In reply to Sergey V. Udaltsov from comment #1)
> Could you please also make a patch (not the full file!) for
> base.extras.xml.in?
> Thank you

There are the patch without mistakes (on xubuntu)
Thanks,
Kovács Viktor
Comment 33 Kovács Viktor 2017-09-18 00:37:38 UTC
I am sorry, licence text missing. I come back again...
Comment 34 Kovács Viktor 2017-09-18 07:48:37 UTC
Created attachment 134312 [details] [review]
Old Hungarian Patch

Added layout to hung file (because of conflicts in latin based hu file)
Added missing licence information
Added comments of layout's UNICODE symbols
Renamed default layout to Old Hungarian(default)
Prepared errors of buttons' codes
Fixed base.xml.in

I tested it on xubuntu, it works.
Comment 35 Kovács Viktor 2017-09-18 07:52:36 UTC
Oh no! I wrote year 2003, instead of 2013
Comment 36 Kovács Viktor 2017-09-18 08:20:32 UTC
Created attachment 134313 [details] [review]
Old Hungarian Layout

Date fixed
Comment 37 Kovács Viktor 2017-09-20 19:05:09 UTC
I think, this should be the last version.
Comment 38 Kovács Viktor 2017-09-23 17:46:48 UTC
Socialdarwinist:This bug must be (re)opened, or fixed for adopt it? Sorry, my English is bad.
Comment 39 Sergey V. Udaltsov 2017-09-24 22:23:35 UTC
Committed to git, thanks!
Comment 40 Sergey V. Udaltsov 2017-10-04 10:27:56 UTC
Actually the latest version is a mess - you created new file symbols/hung (unneeded) and patched base.xml.in. I have to fix it manually.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.