Summary: | library should provide methods with error handling | ||
---|---|---|---|
Product: | accountsservice | Reporter: | Jan Tojnar <jtojnar> |
Component: | general | Assignee: | Matthias Clasen <mclasen> |
Status: | RESOLVED MOVED | QA Contact: | |
Severity: | normal | ||
Priority: | medium | CC: | marius.vollmer, rstrode, stefw |
Version: | unspecified | ||
Hardware: | Other | ||
OS: | All | ||
Whiteboard: | |||
i915 platform: | i915 features: |
Description
Jan Tojnar
2017-10-01 14:20:21 UTC
Which API calls have this problem? (In reply to Robert Ancell from comment #2) > Which API calls have this problem? Each of the following methods on interface `org.freedesktop.Accounts.User` can fail with either `org.freedesktop.Accounts.Error.PermissionDenied` or `org.freedesktop.Accounts.Error.Failed`. - `SetUserName` - `SetRealName` - `SetEmail` - `SetLanguage` - `SetXSession` - `SetLocation` - `SetHomeDirectory` - `SetShell` - `SetIconFile` - `SetLocked` - `SetAccountType` - `SetPasswordMode` - `SetPassword` - `SetPasswordHint` - `SetAutomaticLogin` However, the libaccountsservice functions for those do methods intentionally discard the errors – just grep for “Note this function is synchronous and ignores errors.” - act_user_get_login_history - act_user_set_email - act_user_set_language - act_user_set_x_session - act_user_set_location - act_user_set_user_name - act_user_set_real_name - act_user_set_icon_file - act_user_set_account_type - act_user_set_password - act_uset_set_password_hint // there is a typo in the doc comment btw - act_user_set_password_mode - act_user_set_locked - act_user_set_automatic_login honestly, at this point rather than improve the library api, i'd like to deprecate it, and encourage gdbuscodegen instead. we should probably improve the daemon implementation to export objectmanager interface too (In reply to Ray Strode [halfline] from comment #4) > honestly, at this point rather than improve the library api, i'd like to > deprecate it, and encourage gdbuscodegen instead. Is there an issue for that? -- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/accountsservice/accountsservice/issues/7. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.