Bug 103140

Summary: [OpenGL CTS] KHR-GL45.enhanced_layouts.varying_location_aliasing_* fails
Product: Mesa Reporter: Kenneth Graunke <kenneth>
Component: glsl-compilerAssignee: mesa-dev
Status: RESOLVED FIXED QA Contact: Intel 3D Bugs Mailing List <intel-3d-bugs>
Severity: normal    
Priority: medium    
Version: git   
Hardware: Other   
OS: All   
Whiteboard:
i915 platform: i915 features:
Bug Depends on:    
Bug Blocks: 102590    

Description Kenneth Graunke 2017-10-07 20:53:03 UTC
KHR-GL45.enhanced_layouts.varying_location_aliasing_with_mixed_types
KHR-GL45.enhanced_layouts.varying_location_aliasing_with_mixed_interpolation
KHR-GL45.enhanced_layouts.varying_location_aliasing_with_mixed_auxiliary_storage

all fail, at least on i965.  Ilia wrote a fix:

https://patchwork.freedesktop.org/patch/175959/

but Tim had a bunch of review feedback that needs to be addressed, and Ilia's out of time to work on this.  Someone else may want to pick it up.
Comment 1 Karol Herbst 2017-10-08 16:52:16 UTC
(In reply to Kenneth Graunke from comment #0)
> KHR-GL45.enhanced_layouts.varying_location_aliasing_with_mixed_types
> KHR-GL45.enhanced_layouts.varying_location_aliasing_with_mixed_interpolation
> KHR-GL45.enhanced_layouts.varying_location_aliasing_with_mixed_auxiliary_storage
> 
> all fail, at least on i965.  Ilia wrote a fix:
> 
> https://patchwork.freedesktop.org/patch/175959/
> 
> but Tim had a bunch of review feedback that needs to be addressed, and
> Ilia's out of time to work on this.  Someone else may want to pick it up.

all three tests also fail on Nouveau. So it could be, that I will work on this sooner or later. Will add it to my todo list with no guarantee when I can actually start to work on it. At some point next month or later, depending on whatever comes up and how much time I will have for CTS stuff.
Comment 2 Kenneth Graunke 2017-11-02 03:10:34 UTC
Seem to be passing, probably fixed by

commit ab40acb45341d8cea011ba7330626ffc6e3238ad
Author: Iago Toral Quiroga <itoral@igalia.com>
Date:   Thu Oct 19 16:33:49 2017 +0200

    glsl/linker: outputs in the same location must share auxiliary storage
    
    From ARB_enhanced_layouts:
    
    "[...]when location aliasing, the aliases sharing the location
      must have the same underlying numerical type (floating-point or
      integer) and the same auxiliary storage and
      interpolation qualification.[...]"
    
    Add code to the linker to validate that aliased locations do
    have the same aux storage.
    
    Fixes:
    KHR-GL45.enhanced_layouts.varying_location_aliasing_with_mixed_auxiliary_storage
    
    Reviewed-by: Timothy Arceri <tarceri@itsqueeze.com>
    Reviewed-by: Ilia Mirkin <imirkin@alum.mit.edu>

commit 0b565f715d24d74d844f0708e3ed17ad1ee14faf
Author: Iago Toral Quiroga <itoral@igalia.com>
Date:   Thu Oct 19 16:13:21 2017 +0200

    glsl/linker: outputs in the same location must share interpolation
    
    From ARB_enhanced_layouts:
    
    "[...]when location aliasing, the aliases sharing the location
     must have the same underlying numerical type (floating-point or
     integer) and the same auxiliary storage and
     interpolation qualification.[...]"
    
    Add code to the linker to validate that aliased locations do
    have the same interpolation.
    
    Fixes:
    KHR-GL45.enhanced_layouts.varying_location_aliasing_with_mixed_interpolation
    
    Reviewed-by: Timothy Arceri <tarceri@itsqueeze.com>

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.