Summary: | DOTA2 Vulkan render change with "anv: enable multiple planes per image/imageView" | ||
---|---|---|---|
Product: | Mesa | Reporter: | Eero Tamminen <eero.t.tamminen> |
Component: | Drivers/DRI/i965 | Assignee: | Lionel Landwerlin <lionel.g.landwerlin> |
Status: | RESOLVED FIXED | QA Contact: | Intel 3D Bugs Mailing List <intel-3d-bugs> |
Severity: | normal | ||
Priority: | medium | CC: | mark.a.janes, martin.peres |
Version: | git | ||
Hardware: | Other | ||
OS: | All | ||
Whiteboard: | |||
i915 platform: | i915 features: | ||
Attachments: |
Screenshot from commit
Screenshot before commit |
Description
Eero Tamminen
2017-10-10 13:21:32 UTC
Created attachment 134778 [details]
Screenshot before commit
Fixed by a07f7b26198ce0f5c8799481a673754968ac5daf anv/cmd_buffer: Take bo_offset into account in fast clear state addresses. Because this regression affected a popular commercial software title, and because it was NOT detected by automated tests, I think it should remain open until a test exists which prevents future regressions. Lionel, can you write a crucible test to exercise your code path and demonstrates this regression? I've written a test that uses the fast clear but with a07f7b26198ce0f5c8799481a673754968ac5daf reverted, I can't get this test to fail... The bug must be a bit more complicated than what I understood. Anyway the old trace can be provided? Anybody fancy reviewing the crucible patch in the previous comment? Or should I just land it? Please land the test with or without review. Done. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.