Bug 103199

Betting on:

commit 3fb7add738bb05b617dfbcb14ee59ded000be969 (HEAD, upstream/master)
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Wed Oct 11 01:13:28 2017 +0100

    igt/drv_hangman: Convert from local recursive batch to igt_spin_t

Didn't work for:
https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_1/fi-ilk-650/igt@drv_missed_irq.html

https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_93/fi-icl-u/igt@drv_missed_irq.html

(drv_missed_irq:1510) CRITICAL: Test assertion failure function __real_main96, file ../tests/drv_missed_irq.c:159:
(drv_missed_irq:1510) CRITICAL: Failed assertion: missed_rings == expect_rings
(drv_missed_irq:1510) CRITICAL: Last errno: 9, Bad file descriptor
(drv_missed_irq:1510) CRITICAL: error: 0 != 0x57
Test drv_missed_irq failed.

(In reply to Martin Peres from comment #3)
> https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_93/fi-icl-u/
> igt@drv_missed_irq.html
> 
> (drv_missed_irq:1510) CRITICAL: Test assertion failure function
> __real_main96, file ../tests/drv_missed_irq.c:159:
> (drv_missed_irq:1510) CRITICAL: Failed assertion: missed_rings ==
> expect_rings
> (drv_missed_irq:1510) CRITICAL: Last errno: 9, Bad file descriptor
> (drv_missed_irq:1510) CRITICAL: error: 0 != 0x57
> Test drv_missed_irq failed.

icl is a different class of bug -- icl can't fake missed interrupts at all.

(In reply to Chris Wilson from comment #4)
> (In reply to Martin Peres from comment #3)
> > https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_93/fi-icl-u/
> > igt@drv_missed_irq.html
> > 
> > (drv_missed_irq:1510) CRITICAL: Test assertion failure function
> > __real_main96, file ../tests/drv_missed_irq.c:159:
> > (drv_missed_irq:1510) CRITICAL: Failed assertion: missed_rings ==
> > expect_rings
> > (drv_missed_irq:1510) CRITICAL: Last errno: 9, Bad file descriptor
> > (drv_missed_irq:1510) CRITICAL: error: 0 != 0x57
> > Test drv_missed_irq failed.
> 
> icl is a different class of bug -- icl can't fake missed interrupts at all.

commit 5f521722a2a2391d693afccdf6e12be2754382d8 (HEAD -> drm-intel-next-queued, drm-intel/drm-intel-next-queued)
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Fri Sep 7 12:28:51 2018 +0100

    drm/i915: Missed interrupt simulation is no more, tell the world
    
    Using the guc, we cannot disable the user interrupt generation as we use
    it for driving submission. And from Icelake, we no longer have the
    ability to individually mask interrupt generation from each engine,
    disabling our ability to fake missed interrupts.
    
    In both cases, report back to userspace that the missed interrupt
    generator is no longer available.
    
    Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
    Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
    Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
    Link: https://patchwork.freedesktop.org/patch/msgid/20180907112856.28242-1-chris@chris-wilson.co.uk

(In reply to Chris Wilson from comment #5)
> (In reply to Chris Wilson from comment #4)
> > (In reply to Martin Peres from comment #3)
> > > https://intel-gfx-ci.01.org/tree/drm-tip/drmtip_93/fi-icl-u/
> > > igt@drv_missed_irq.html
> > > 
> > > (drv_missed_irq:1510) CRITICAL: Test assertion failure function
> > > __real_main96, file ../tests/drv_missed_irq.c:159:
> > > (drv_missed_irq:1510) CRITICAL: Failed assertion: missed_rings ==
> > > expect_rings
> > > (drv_missed_irq:1510) CRITICAL: Last errno: 9, Bad file descriptor
> > > (drv_missed_irq:1510) CRITICAL: error: 0 != 0x57
> > > Test drv_missed_irq failed.
> > 
> > icl is a different class of bug -- icl can't fake missed interrupts at all.
> 
> commit 5f521722a2a2391d693afccdf6e12be2754382d8 (HEAD ->
> drm-intel-next-queued, drm-intel/drm-intel-next-queued)
> Author: Chris Wilson <chris@chris-wilson.co.uk>
> Date:   Fri Sep 7 12:28:51 2018 +0100
> 
>     drm/i915: Missed interrupt simulation is no more, tell the world
>     
>     Using the guc, we cannot disable the user interrupt generation as we use
>     it for driving submission. And from Icelake, we no longer have the
>     ability to individually mask interrupt generation from each engine,
>     disabling our ability to fake missed interrupts.
>     
>     In both cases, report back to userspace that the missed interrupt
>     generator is no longer available.
>     
>     Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>     Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
>     Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
>     Link:
> https://patchwork.freedesktop.org/patch/msgid/20180907112856.28242-1-
> chris@chris-wilson.co.uk

Do you think it will also fix the ICL bug or should I file another bug?

It should do the trick. My memory of the test says that if we can't open the file we say the engine mask is 0. However, I do have an update to the igt pending review in case it doesn't.

We shall see what happens over the w/e and if we need to open a new bug or not.