Bug 103310

Summary: [CI] igt@gem_madvise@dontneed-before-pwrite - fail
Product: DRI Reporter: Marta Löfstedt <marta.lofstedt>
Component: DRM/IntelAssignee: Intel GFX Bugs mailing list <intel-gfx-bugs>
Status: CLOSED FIXED QA Contact: Intel GFX Bugs mailing list <intel-gfx-bugs>
Severity: normal    
Priority: medium CC: intel-gfx-bugs
Version: DRI git   
Hardware: Other   
OS: All   
Whiteboard: ReadyForDev
i915 platform: BXT, GLK, HSW, KBL, SNB i915 features: GEM/Other

Description Marta Löfstedt 2017-10-17 11:09:45 UTC
On CI_DRM_3248 on all shards
igt@gem_madvise@dontneed-before-pwrite 
fails:
	

(gem_madvise:1668) CRITICAL: Test assertion failure function dontneed_before_pwrite, file gem_madvise.c:122:
(gem_madvise:1668) CRITICAL: Failed assertion: __gem_write(fd, handle, 0, &bbe, sizeof(bbe)) == -14
(gem_madvise:1668) CRITICAL: error: 0 != -14
Subtest dontneed-before-pwrite failed.


https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3248/shard-apl2/igt@gem_madvise@dontneed-before-pwrite.html
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3248/shard-hsw6/igt@gem_madvise@dontneed-before-pwrite.html
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3248/shard-kbl1/igt@gem_madvise@dontneed-before-pwrite.html
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3248/shard-snb2/igt@gem_madvise@dontneed-before-pwrite.html
Comment 1 Chris Wilson 2017-10-17 11:14:34 UTC
https://patchwork.freedesktop.org/series/32066/
Comment 2 Chris Wilson 2017-10-17 13:12:15 UTC
commit a6d65e451cc4e7127698384868a4447ee7be7d16
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Mon Oct 16 21:27:32 2017 +0100

    drm/i915: Report -EFAULT before pwrite fast path into shmemfs
    
    When pwriting into shmemfs, the fast path pagecache_write does not
    notice when it is writing to beyond the end of the truncated shmemfs
    inode. Report -EFAULT directly when we try to use pwrite into the
    !I915_MADV_WILLNEED object.
    
    Fixes: 7c55e2c5772d ("drm/i915: Use pagecache write to prepopulate shmemfs from pwrite-ioctl")
Comment 3 Marta Löfstedt 2017-10-18 10:33:13 UTC
Also, GLK-shards:	

(gem_madvise:1498) CRITICAL: Test assertion failure function dontneed_before_pwrite, file gem_madvise.c:122:
(gem_madvise:1498) CRITICAL: Failed assertion: __gem_write(fd, handle, 0, &bbe, sizeof(bbe)) == -14
(gem_madvise:1498) CRITICAL: error: 0 != -14
Subtest dontneed-before-pwrite failed.

https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3253/shard-glkb4/igt@gem_madvise@dontneed-before-pwrite.html
Comment 4 Marta Löfstedt 2017-10-18 13:35:57 UTC
From CI_DRM_3254 this issue is no longer reproducible.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.