Bug 10343

Summary:	Should include its own keybindings for GNOME
Product:	xorg	Reporter:	Bastien Nocera <bugzilla>
Component:	App/compiz	Assignee:	David Reveman <reveman>
Status:	RESOLVED INVALID	QA Contact:	Xorg Project Team <xorg-team>
Severity:	normal
Priority:	medium	CC:	krh
Version:	unspecified
Hardware:	Other
OS:	All
Whiteboard:
i915 platform:		i915 features:

Description Bastien Nocera 2007-03-19 07:28:10 UTC

In the past, keybindings integration with GNOME was done by patching the GNOME keybindings capplet.

Now that the keybindings capplet can load keybindings definitions from XML files, compiz should include its own configuration files.

Such a configuration file is available at:
http://bugzilla.gnome.org/show_bug.cgi?id=376045#c5

You'd need to add package=@GETTEXT_PACKAGE@ in the .xml file, and install it in $(datadir)/control-center-2.0/keybindings/

Let me know if you have any questions.

Comment 1 David Reveman 2007-04-11 09:38:39 UTC

I've included the configuration files and made compiz install them in $(datadir)/gnome-control-center/keybindings/ as that seemed to be where the keybinding capplet is looking for them. Let me know if that's not correct.

This however requires that compiz is using the same datadir as gnome-control-center. It would be better if gnome-control-center installed a pkg-config file which allowed compiz to check what datadir gnome-control-center is using.

Thanks.

Comment 2 Bastien Nocera 2007-04-11 10:00:46 UTC

(In reply to comment #1)
> I've included the configuration files and made compiz install them in
> $(datadir)/gnome-control-center/keybindings/ as that seemed to be where the
> keybinding capplet is looking for them. Let me know if that's not correct.
> 
> This however requires that compiz is using the same datadir as
> gnome-control-center. It would be better if gnome-control-center installed a
> pkg-config file which allowed compiz to check what datadir gnome-control-center
> is using.

If you think it's really required, I can certainly work on that for the gnome-control-center. Just seems a bit overkill to me...

Comment 3 David Reveman 2007-04-13 12:16:12 UTC

(In reply to comment #2)
> (In reply to comment #1)
> > This however requires that compiz is using the same datadir as
> > gnome-control-center. It would be better if gnome-control-center installed a
> > pkg-config file which allowed compiz to check what datadir gnome-control-center
> > is using.
> 
> If you think it's really required, I can certainly work on that for the
> gnome-control-center. Just seems a bit overkill to me...
> 

It's up to you but it think it's a good idea as whoever is building compiz/metacity will otherwise have to manually make sure it's installed in the correct location.

Comment 4 Bastien Nocera 2007-04-30 06:29:23 UTC

(In reply to comment #3)
> It's up to you but it think it's a good idea as whoever is building
> compiz/metacity will otherwise have to manually make sure it's installed in the
> correct location.

Upstream bug:
http://bugzilla.gnome.org/show_bug.cgi?id=434591

Comment 5 Bastien Nocera 2007-04-30 09:12:54 UTC

Upstream bug is fixed. This is an example (for gnome-launch-box) of checking for control-center's ability to handle custom keybindings:
http://bugzilla.gnome.org/attachment.cgi?id=87269&action=view

Comment 6 Adam Jackson 2018-06-12 19:10:05 UTC

Mass closure: This bug has been untouched for more than six years, and is not
obviously still valid. Please reopen this bug or file a new report if you continue to experience issues with current releases.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.