Bug 103456

So, you see a failure when you run the test manually?  If so, the run_concurrent=False change isn't relative then.

What happens without -fbo?

Concurrent implies -fbo...

Passes without fbo:

> /tmp/build_root/m64/lib/piglit/bin/copy-pixels -auto -fbo
Probe at (0,88)
  Expected: 0.000000 0.000000 1.000000 1.000000
  Observed: 1.000000 0.000000 0.000000 1.000000
PIGLIT: {"result": "fail" }

> /tmp/build_root/m64/lib/piglit/bin/copy-pixels -auto 
PIGLIT: {"result": "pass" }

If you run with -auto -fbo -png you'll get a png image of the rendering.  I suggest looking at that and comparing to results without -fbo.

Created attachment 135043 [details]
fbo copy pixels image

Created attachment 135044 [details]
copy pixels image

Created attachment 135045 [details]
diff of images

Generated with:

 > compare fbo-copy-pixels000.png copy-pixels000.png -compose src diff.png

I couldn't see the image difference visually, but the file sizes are different and `compare` shows a significant difference.

Looks like an i965 bug - it passes with llvmpipe at least.

The differences are actually significant - just flip between them and it'll be obvious.

oops! I was looking at the wrong copy and needed to `M-x revert-buffer`

Yes the differences are obvious.

Assigning to mesa.

I'll try and fix this, the blitter path doesn't account for Y-flips.  I'm amazed we never ran into this before.

Hi. I found out that this test doesn't fail since first 18.2.0-rc1, so I decided to bisect, to provide commit with a fix.
Definitely it is:
[7fd962093f71d83ffc74962a8f7572b493d9030f] i965: Use meta for pixel ops on gen6+
...
Then - the most confusing part for me :( After bisecting I checked intel CI config file, with a list of "known bugs", and found out this test in section https://github.com/janesma/mesa_jenkins/blob/master/piglit-test/kbl.conf

[fixed-tests]
piglit.spec.!opengl 1_4.copy-pixels = mesa 7fd962093f71d83ffc74962a8f7572b493d9030f

Based on this, I close the ticket as fixed

Sorry for the confusion.  We have no good way to trace bugs to our CI configurations, and we often fail to close bugs when tests are fixed.

You can often find bisected commits in the CI configuration files, as a shortcut to bisecting a test yourself.

Watch our XDC presentation on the upcoming public i965 CI interface, which should make it easier to see our status for any bug.