Bug 10352

Summary:

undefined BUILDDEBUG causes build failure with --enable-debug

Product:

xorg

Reporter:

caglar

Component:

Server/General

Assignee:

Xorg Project Team <xorg-team>

Status:

RESOLVED FIXED

QA Contact:

Xorg Project Team <xorg-team>

Severity:

normal

Priority:

medium

CC:

mmokrejs

Version:

git

Hardware:

Other

OS:

All

Whiteboard:

i915 platform:

i915 features:

Attachments:

Description	Flags
debug.patch	none
define BUILDDEBUG if the option --enable-debug is used.	none

Description caglar 2007-03-20 04:29:44 UTC

Compiling xorg-server with --enable-debug ends with (xorg-server-1.2.99.902 and also with git-HEAD) error;

/xf86Debug.o
xf86Debug.c:167: error: expected ')' before '*' token
xf86Debug.c:178: error: expected ')' before '*' token

the problem caused by #ifdef BUILDDEBUG lines but grepping BUILDDEBUG on source gaves nothing but following;

[caglar@zangetsu][~/buildbox/xorg/xorg-server-1.2.99.902]> grep "BUILDDEBUG" 
* -r
hw/xfree86/common/xf86.h:#ifdef BUILDDEBUG
hw/xfree86/common/xf86.h:#ifdef BUILDDEBUG
hw/xfree86/common/xf86str.h:#ifdef BUILDDEBUG
hw/xfree86/loader/xf86sym.c:#ifdef BUILDDEBUG
hw/xfree86/loader/xf86sym.c:#ifdef BUILDDEBUG

so attached patch converts these "#ifdef BUILDDEBUG" lines into "#ifdef 
DEBUG", BUILDDEBUG seems left from old host.def days, if i'm not missing 
something.

Comment 1 caglar 2007-03-20 04:30:06 UTC

Created attachment 9234 [details] [review]
debug.patch

Comment 2 Simon Guinot 2007-05-15 10:22:07 UTC

Created attachment 9973 [details] [review]
define BUILDDEBUG if the option --enable-debug is used.

Comment 3 caglar 2007-05-15 11:55:34 UTC

(In reply to comment #2)
> Created an attachment (id=9973) [details]
> define BUILDDEBUG if the option --enable-debug is used.

Is it really neccesary to introduce a new define (BUILDDEBUG) instead of using defined one (DEBUG) :) ?

Comment 4 Jesse Adkins 2010-08-03 19:51:07 UTC

commit d0de5ea96d084fc5da87d8f323ddfc08fe9c03ba (Daniel Stone, Jun 25 2008) to xserver removed the last of BUILDDEBUG.
I just now rebuilt the latest xorg (7e0575baf14ec4a89492fd2780f9ab5b9244afbd at Jul 27 2010) with --enable-debug and there were no problems.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.