Bug 103539

Summary:	Windows build breaks if 'sh' is not available
Product:	Mesa	Reporter:	Charles Huber <genpfault>
Component:	Mesa core	Assignee:	mesa-dev
Status:	RESOLVED INVALID	QA Contact:	mesa-dev
Severity:	major
Priority:	medium
Version:	17.2
Hardware:	x86 (IA32)
OS:	Windows (All)
Whiteboard:
i915 platform:		i915 features:

Description Charles Huber 2017-11-01 20:52:46 UTC

3fd425aed7 switched write_git_sha1_h_file() in src/SConscript from Popen()ing 'git' directly to using a sh script.  Since sh isn't available on Windows the function fails to create the git_sha1.h file and eventually breaks the build when things like src\mesa\main\version.c try to #include it.

I'm using the mesa-17.2.4 tag (a4b72e2643) with the VS2015 toolchain.

Comment 1 Charles Huber 2017-11-01 21:08:02 UTC

Reverting write_git_sha1_h_file() to the pre-3fd425aed7 code fixes the build for me.

Comment 2 Brian Paul 2017-11-01 21:29:22 UTC

Please try the latest code.  This was fixed back in August.  Re-open this bug if you still have trouble.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.