Bug 103578

Summary: Broken paths in pkg-config files
Product: poppler Reporter: Jakub Wilk <jwilk>
Component: generalAssignee: poppler-bugs <poppler-bugs>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: medium CC: ats-fd, evangelos, jwilk, pochu27
Version: unspecified   
Hardware: All   
OS: All   
Whiteboard:
i915 platform: i915 features:
Attachments: Patch for incorrect .pc files

Description Jakub Wilk 2017-11-05 11:14:27 UTC
I built Poppler 0.61.0 with -DCMAKE_INSTALL_PREFIX="$HOME/opt/poppler".
The installed poppler.pc file looks like this:

> prefix=/home/jwilk/opt/poppler
> libdir=lib
> includedir=include
> 
> Name: poppler
> Description: PDF rendering library
> Version: 0.61.0
> 
> Libs: -L${libdir} -lpoppler
> Cflags: -I${includedir}/poppler

Note that libdir and includedir don't contain the full paths.
Comment 1 Albert Astals Cid 2017-11-05 11:22:18 UTC
Emilio, can you have a look? I'm guessing your patch broke this? 

P.s: I'll be traveling next week so may not have time to answer timely
Comment 2 Adam Sampson 2017-11-05 11:47:46 UTC
Created attachment 135246 [details] [review]
Patch for incorrect .pc files
Comment 3 Jakub Wilk 2017-11-05 12:02:48 UTC
Thanks, Adam. I confirm that your patch fixes the bug for me.
Comment 4 Emilio Pozuelo Monfort 2017-11-05 14:34:11 UTC
That indeed looks broken from my patch, sorry for not noticing that and thanks for the fix!
Comment 5 Albert Astals Cid 2017-11-09 08:34:34 UTC
Pushed, thanks. I will probably release 0.61.1 tomorrow to get this fixed.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.