Summary: | evince crashed with SIGSEGV in poppler_attachment_save_to_callback() | ||
---|---|---|---|
Product: | poppler | Reporter: | Sebastien Bacher <seb128> |
Component: | general | Assignee: | poppler-bugs <poppler-bugs> |
Status: | RESOLVED FIXED | QA Contact: | |
Severity: | normal | ||
Priority: | medium | ||
Version: | unspecified | ||
Hardware: | Other | ||
OS: | All | ||
Whiteboard: | |||
i915 platform: | i915 features: |
Description
Sebastien Bacher
2007-03-23 06:15:04 UTC
There is a similar crash on https://bugs.launchpad.net/bugs/419777 example: http://launchpadlibrarian.net/31038402/Wiley.OpenSolaris.Bible.Feb.2009.pdf the issue is there using 0.11.3 too I think they are different issues. The first one was a bug in evince that we already fixed some time ago. The second looks like a broken pdf file, it contains a FileSpec object with an empty EF dictionary: 4205 0 obj <</UF(C1.jpg)/F(C1.jpg)/EF<<>>/Desc()/Type/Filespec>> endobj I'd say this is wrong . . . In any case we shouldn't crash when EmbFile contains a null stream. Albert, does this make qt frontend crash too? or do I mark this bug as glib only? should this bug be closed if the issue was a fixed evince one and a new one opened about the new crash? Crashes too on the Qt frontend, the question is, should we "stop" reporting the Embedded file from the core when we realize it's not a valid one or still report it and fail when trying to save it. Adobe does the later, but for us would be easier the first and for the user the result is the same as he can't extract the file. But still i think we should go fixing the frontends, what do you say? An attachment that can't be opened/saved/... is useless, so I think we might just show an error message saying that an invalid embedded file has been found and ignore such attachment. Carlos: At the end Pino and me think that mimicking Adobe's behaviour is the best so i've added a isOk() method to EmbFile in poppler core you should use in the glib frontend to avoid the crash. Ok, fixed in glib too. Thanks! |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.