| Summary: | [CI] igt@* - dmesg-warn - WARNING: possible circular locking dependency detected | ||
|---|---|---|---|
| Product: | DRI | Reporter: | Marta Löfstedt <marta.lofstedt> |
| Component: | DRM/Intel | Assignee: | Intel GFX Bugs mailing list <intel-gfx-bugs> |
| Status: | CLOSED FIXED | QA Contact: | Intel GFX Bugs mailing list <intel-gfx-bugs> |
| Severity: | normal | ||
| Priority: | medium | CC: | intel-gfx-bugs |
| Version: | DRI git | ||
| Hardware: | Other | ||
| OS: | All | ||
| Whiteboard: | ReadyForDev | ||
| i915 platform: | BXT, HSW, SNB | i915 features: | |
|
Description
Marta Löfstedt
2017-11-28 07:10:12 UTC
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3397/shard-hsw3/igt@kms_cursor_crc@cursor-256x256-suspend.html [ 282.801181] Suspending console(s) (use no_console_suspend to debug) [ 282.809347] sd 4:0:0:0: [sda] Synchronizing SCSI cache [ 282.809672] sd 4:0:0:0: [sda] Stopping disk [ 282.921866] ====================================================== [ 282.921867] WARNING: possible circular locking dependency detected [ 282.921868] 4.15.0-rc1-CI-CI_DRM_3397+ #1 Tainted: G U [ 282.921869] ------------------------------------------------------ [ 282.921870] watchdog/1/15 is trying to acquire lock: [ 282.921870] (&cpuctx_mutex){+.+.}, at: [<ffffffff8116071c>] perf_event_ctx_lock_nested+0xbc/0x1d0 [ 282.921875] but now in release context of a crosslock acquired at the following: [ 282.921876] ((completion)&self->parked){+.+.}, at: [<ffffffff8109d69d>] kthread_park+0x3d/0x50 [ 282.921879] which lock already depends on the new lock. [ 282.921879] the existing dependency chain (in reverse order) is: [ 282.921879] -> #3 ((completion)&self->parked){+.+.}: [ 282.921883] wait_for_common+0x54/0x210 [ 282.921884] kthread_park+0x3d/0x50 [ 282.921917] i915_gem_reset_prepare_engine+0x1d/0x90 [i915] [ 282.921940] i915_gem_reset_prepare+0x2c/0x60 [i915] [ 282.921957] i915_reset+0x66/0x230 [i915] [ 282.921974] i915_reset_device+0x1cb/0x230 [i915] [ 282.921991] i915_handle_error+0x2d3/0x430 [i915] [ 282.922011] i915_wedged_set+0x79/0xc0 [i915] [ 282.922013] simple_attr_write+0xab/0xc0 [ 282.922016] full_proxy_write+0x4b/0x70 [ 282.922017] __vfs_write+0x1e/0x130 [ 282.922017] vfs_write+0xc0/0x1b0 [ 282.922018] SyS_write+0x40/0xa0 [ 282.922020] entry_SYSCALL_64_fastpath+0x1c/0x89 [ 282.922020] -> #2 (&dev->struct_mutex){+.+.}: [ 282.922023] __mutex_lock+0x81/0x9b0 [ 282.922044] i915_mutex_lock_interruptible+0x47/0x130 [i915] [ 282.922065] i915_gem_fault+0x201/0x760 [i915] [ 282.922067] __do_fault+0x15/0x70 [ 282.922069] __handle_mm_fault+0x7bf/0xda0 [ 282.922071] handle_mm_fault+0x14f/0x2f0 [ 282.922072] __do_page_fault+0x2d1/0x560 [ 282.922073] page_fault+0x22/0x30 [ 282.922073] -> #1 (&mm->mmap_sem){++++}: [ 282.922076] __might_fault+0x63/0x90 [ 282.922078] _copy_to_user+0x1e/0x70 [ 282.922079] perf_read+0x1aa/0x290 [ 282.922080] __vfs_read+0x1e/0x120 [ 282.922081] vfs_read+0xa1/0x150 [ 282.922082] SyS_read+0x40/0xa0 [ 282.922083] entry_SYSCALL_64_fastpath+0x1c/0x89 [ 282.922083] -> #0 (&cpuctx_mutex){+.+.}: [ 282.922085] perf_event_ctx_lock_nested+0xbc/0x1d0 [ 282.922086] other info that might help us debug this: [ 282.922086] Chain exists of: &cpuctx_mutex --> &dev->struct_mutex --> (completion)&self->parked [ 282.922088] Possible unsafe locking scenario by crosslock: [ 282.922089] CPU0 CPU1 [ 282.922089] ---- ---- [ 282.922089] lock(&dev->struct_mutex); [ 282.922090] lock((completion)&self->parked); [ 282.922091] lock(&cpuctx_mutex); [ 282.922092] unlock((completion)&self->parked); [ 282.922093] *** DEADLOCK *** [ 282.922094] 1 lock held by watchdog/1/15: [ 282.922094] #0: (&x->wait){....}, at: [<ffffffff810c7b03>] complete+0x13/0x50 [ 282.922098] stack backtrace: [ 282.922100] CPU: 1 PID: 15 Comm: watchdog/1 Tainted: G U 4.15.0-rc1-CI-CI_DRM_3397+ #1 [ 282.922100] Hardware name: MSI MS-7924/Z97M-G43(MS-7924), BIOS V1.12 02/15/2016 [ 282.922101] Call Trace: [ 282.922105] dump_stack+0x5f/0x86 [ 282.922108] print_circular_bug+0x230/0x3b0 [ 282.922110] check_prev_add+0x439/0x7b0 [ 282.922112] ? HARDIRQ_verbose+0x10/0x10 [ 282.922115] ? lock_commit_crosslock+0x3e8/0x640 [ 282.922116] lock_commit_crosslock+0x3e8/0x640 [ 282.922118] ? __kthread_parkme+0x39/0x90 [ 282.922120] ? smpboot_thread_fn+0x184/0x270 [ 282.922122] complete+0x1f/0x50 [ 282.922123] ? __kthread_parkme+0x39/0x90 [ 282.922124] __kthread_parkme+0x63/0x90 [ 282.922126] ? smpboot_thread_fn+0x2c/0x270 [ 282.922127] smpboot_thread_fn+0xaa/0x270 [ 282.922128] kthread+0x139/0x170 [ 282.922130] ? sort_range+0x20/0x20 [ 282.922131] ? kthread_create_on_node+0x40/0x40 [ 282.922133] ret_from_fork+0x24/0x30 https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3397/shard-hsw1/igt@pm_rpm@system-suspend-modeset.html [ 82.002286] Suspending console(s) (use no_console_suspend to debug) [ 82.012503] sd 1:0:0:0: [sda] Synchronizing SCSI cache [ 82.021134] sd 1:0:0:0: [sda] Stopping disk [ 82.162690] ====================================================== [ 82.162690] WARNING: possible circular locking dependency detected [ 82.162692] 4.15.0-rc1-CI-CI_DRM_3397+ #1 Tainted: G U [ 82.162692] ------------------------------------------------------ [ 82.162693] watchdog/1/15 is trying to acquire lock: [ 82.162693] (&cpuctx_mutex){+.+.}, at: [<ffffffff8116071c>] perf_event_ctx_lock_nested+0xbc/0x1d0 [ 82.162698] but now in release context of a crosslock acquired at the following: [ 82.162699] ((completion)&self->parked){+.+.}, at: [<ffffffff8109d69d>] kthread_park+0x3d/0x50 [ 82.162702] which lock already depends on the new lock. [ 82.162702] the existing dependency chain (in reverse order) is: [ 82.162702] -> #3 ((completion)&self->parked){+.+.}: [ 82.162707] wait_for_common+0x54/0x210 [ 82.162707] kthread_park+0x3d/0x50 [ 82.162742] i915_gem_reset_prepare_engine+0x1d/0x90 [i915] [ 82.162764] i915_gem_reset_prepare+0x2c/0x60 [i915] [ 82.162780] i915_reset+0x66/0x230 [i915] [ 82.162796] i915_reset_device+0x1cb/0x230 [i915] [ 82.162812] i915_handle_error+0x2d3/0x430 [i915] [ 82.162835] hangcheck_declare_hang+0xc0/0xd0 [i915] [ 82.162857] i915_hangcheck_elapsed+0x275/0x2f0 [i915] [ 82.162859] process_one_work+0x227/0x650 [ 82.162860] worker_thread+0x48/0x3a0 [ 82.162861] kthread+0x139/0x170 [ 82.162862] ret_from_fork+0x24/0x30 [ 82.162863] -> #2 (&dev->struct_mutex){+.+.}: [ 82.162866] __mutex_lock+0x81/0x9b0 [ 82.162886] i915_mutex_lock_interruptible+0x47/0x130 [i915] [ 82.162907] i915_gem_fault+0x201/0x760 [i915] [ 82.162909] __do_fault+0x15/0x70 [ 82.162910] __handle_mm_fault+0x9ab/0xda0 [ 82.162912] handle_mm_fault+0x14f/0x2f0 [ 82.162913] __do_page_fault+0x2d1/0x560 [ 82.162914] page_fault+0x22/0x30 [ 82.162914] -> #1 (&mm->mmap_sem){++++}: [ 82.162917] __might_fault+0x63/0x90 [ 82.162919] _copy_to_user+0x1e/0x70 [ 82.162920] perf_read+0x1aa/0x290 [ 82.162921] __vfs_read+0x1e/0x120 [ 82.162922] vfs_read+0xa1/0x150 [ 82.162923] SyS_read+0x40/0xa0 [ 82.162924] entry_SYSCALL_64_fastpath+0x1c/0x89 [ 82.162924] -> #0 (&cpuctx_mutex){+.+.}: [ 82.162926] perf_event_ctx_lock_nested+0xbc/0x1d0 [ 82.162926] other info that might help us debug this: [ 82.162927] Chain exists of: &cpuctx_mutex --> &dev->struct_mutex --> (completion)&self->parked [ 82.162929] Possible unsafe locking scenario by crosslock: [ 82.162929] CPU0 CPU1 [ 82.162930] ---- ---- [ 82.162930] lock(&dev->struct_mutex); [ 82.162931] lock((completion)&self->parked); [ 82.162932] lock(&cpuctx_mutex); [ 82.162932] unlock((completion)&self->parked); [ 82.162933] *** DEADLOCK *** [ 82.162934] 1 lock held by watchdog/1/15: [ 82.162934] #0: (&x->wait){....}, at: [<ffffffff810c7b03>] complete+0x13/0x50 [ 82.162938] stack backtrace: [ 82.162939] CPU: 1 PID: 15 Comm: watchdog/1 Tainted: G U 4.15.0-rc1-CI-CI_DRM_3397+ #1 [ 82.162940] Hardware name: MSI MS-7924/Z97M-G43(MS-7924), BIOS V1.12 02/15/2016 [ 82.162940] Call Trace: [ 82.162944] dump_stack+0x5f/0x86 [ 82.162947] print_circular_bug+0x230/0x3b0 [ 82.162949] check_prev_add+0x439/0x7b0 [ 82.162951] ? HARDIRQ_verbose+0x10/0x10 [ 82.162954] ? lock_commit_crosslock+0x3e8/0x640 [ 82.162955] lock_commit_crosslock+0x3e8/0x640 [ 82.162956] ? __kthread_parkme+0x39/0x90 [ 82.162958] ? smpboot_thread_fn+0x184/0x270 [ 82.162960] complete+0x1f/0x50 [ 82.162961] ? __kthread_parkme+0x39/0x90 [ 82.162962] __kthread_parkme+0x63/0x90 [ 82.162964] ? smpboot_thread_fn+0x2c/0x270 [ 82.162965] smpboot_thread_fn+0xaa/0x270 [ 82.162966] kthread+0x139/0x170 [ 82.162968] ? sort_range+0x20/0x20 [ 82.162969] ? kthread_create_on_node+0x40/0x40 [ 82.162970] ret_from_fork+0x24/0x30 [ 82.196456] IRQ 31: no longer affine to CPU3 Here is more on HSW: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3397/shard-hsw4/igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-a.html https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3396/shard-hsw1/igt@kms_busy@extended-pageflip-hang-newfb-render-c.html https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3396/shard-hsw5/igt@gem_exec_suspend@basic-s3.html https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3396/shard-hsw2/igt@perf_pmu@busy-check-all-bcs0.html https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3395/shard-hsw4/igt@gem_mmap_gtt@hang.html lockdep also on SNB: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3397/shard-snb3/igt@gem_exec_capture@capture-render.html https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3397/shard-snb7/igt@kms_flip@vblank-vs-modeset-suspend-interruptible.html https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3397/shard-snb1/igt@gem_eio@in-flight-internal.html https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3396/shard-snb7/igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-a.html https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3396/shard-snb3/igt@gem_eio@in-flight-external.html https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3395/shard-snb3/igt@perf_pmu@multi-client-vcs0.html https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3397/shard-hsw6/igt@perf_pmu@all-busy-check-all.html Also, on APL-shards: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3395/shard-apl3/igt@gem_exec_schedule@fifo-blt.html https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3395/shard-apl7/igt@gem_wait@wait-bsd.html https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3395/shard-apl5/igt@gem_mocs_settings@mocs-reset-dirty-render.html https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3395/shard-apl4/igt@gem_exec_capture@capture-render.html https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3396/shard-apl1/igt@pm_rpm@system-suspend-modeset.html https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3397/shard-apl4/igt@perf_pmu@all-busy-check-all.html https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3397/shard-apl1/igt@perf_pmu@idle-vcs0.html https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3397/shard-apl7/igt@perf_pmu@busy-no-semaphores-bcs0.html https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3397/shard-apl5/igt@gem_mocs_settings@mocs-reset-render.html https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3396/shard-apl7/igt@perf_pmu@idle-rcs0.html GLK-shards: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3395/shard-glkb2/igt@drv_hangman@error-state-basic.html https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3397/shard-glkb6/igt@perf_pmu@idle-rcs0.html https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3397/shard-glkb3/igt@perf_pmu@idle-vcs0.html https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3396/shard-glkb6/igt@gem_exec_capture@capture-blt.html https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3396/shard-glkb1/igt@perf_pmu@busy-no-semaphores-bcs0.html https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3395/shard-glkb4/igt@gem_workarounds@reset.html https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3395/shard-glkb3/igt@drv_hangman@error-state-capture-vebox.html KBL-shards lockdep: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3397/shard-kbl5/igt@gem_mocs_settings@mocs-reset-bsd1.html https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3395/shard-kbl6/igt@kms_flip@vblank-vs-dpms-suspend.html https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3395/shard-kbl3/igt@perf_pmu@idle-vcs1.html https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3395/shard-kbl3/igt@perf_pmu@render-node-busy-vcs0.html https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3395/shard-kbl6/igt@gem_eio@in-flight-contexts.html https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4016/shard-snb1/igt@kms_busy@extended-pageflip-hang-newfb-render-a.html https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4016/shard-snb5/igt@kms_busy@extended-modeset-hang-oldfb-render-a.html https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4016/shard-snb6/igt@drv_suspend@debugfs-reader.html https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4016/shard-kbl4/igt@drv_suspend@sysfs-reader.html https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4016/shard-kbl2/igt@perf_pmu@busy-rcs0.html https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4016/shard-hsw4/igt@kms_flip@vblank-vs-hang-interruptible.html https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4016/shard-hsw8/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4016/shard-hsw3/igt@gem_ringfill@basic-default-hang.html https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4016/shard-apl7/igt@gem_eio@execbuf.html https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4016/shard-apl4/igt@pm_rpm@system-suspend.html https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4016/shard-apl2/igt@gem_mocs_settings@mocs-reset-vebox.html https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4016/shard-kbl4/igt@drv_suspend@sysfs-reader.html https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4016/shard-glkb3/igt@perf_pmu@idle-no-semaphores-bcs0.html Some more SNB occurrences from this morning: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3399/shard-snb1/igt@perf_pmu@busy-no-semaphores-vcs0.html https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4017/shard-snb4/igt@kms_busy@extended-pageflip-hang-newfb-render-b.html https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4018/shard-snb4/igt@perf_pmu@frequency.html https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3402/shard-snb6/igt@perf_pmu@busy-no-semaphores-rcs0.html https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3401/shard-snb1/igt@kms_cursor_crc@cursor-64x64-suspend.html https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3400/shard-snb6/igt@kms_fbcon_fbt@fbc-suspend.html https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3400/shard-snb4/igt@perf_pmu@most-busy-check-all-bcs0.html https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4020/shard-hsw3/igt@kms_flip@flip-vs-modeset-vs-hang-interruptible.html https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4020/shard-hsw1/igt@drv_suspend@fence-restore-tiled2untiled.html https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4018/shard-hsw4/igt@pm_rpm@system-suspend-execbuf.html https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3402/shard-hsw5/igt@perf_pmu@idle-no-semaphores-rcs0.html https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3401/shard-hsw3/igt@prime_busy@hang-bsd.html https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3400/shard-hsw7/igt@gem_eio@in-flight.html https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3399/shard-hsw8/igt@perf_pmu@busy-bcs0.html https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4020/shard-hsw8/igt@perf_pmu@idle-no-semaphores-vcs0.html https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3402/shard-hsw4/igt@gem_eio@wait.html https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3401/shard-hsw5/igt@perf_pmu@busy-check-all-vecs0.html https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3400/shard-apl4/igt@perf_pmu@semaphore-wait-bcs0.html https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3402/shard-apl8/igt@gem_sync@basic-all.html https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3402/shard-apl8/igt@perf_pmu@other-read-0.html https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3402/shard-apl5/igt@perf_pmu@semaphore-wait-rcs0.html https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3402/shard-apl4/igt@perf_pmu@semaphore-wait-vecs0.html https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4017/shard-apl8/igt@gem_workarounds@suspend-resume-fd.html https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4017/shard-apl1/igt@kms_flip@vblank-vs-hang.html https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4020/shard-apl2/igt@kms_flip@vblank-vs-dpms-suspend-interruptible.html https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4020/shard-apl1/igt@gem_mocs_settings@mocs-reset-blt.html still hitting CI_DRM_3405: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3405/shard-snb5/igt@drv_hangman@error-state-capture-blt.html https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3405/shard-snb7/igt@kms_busy@extended-modeset-hang-oldfb-render-b.html a fix was integrated to CI_DRM_3411 commit 8f873adc152c899d0e1b9ccaf9caa468955c1fdd Author: Daniel Vetter <daniel.vetter@ffwll.ch> Date: Wed Nov 29 17:29:54 2017 +0100 drm-tip: 2017y-11m-29d-16h-28m-40s UTC integration manifest commit aff78eb7ce76b42d4c94d2f5ce768c1c2c8fb94d Author: Daniel Vetter <daniel.vetter@ffwll.ch> Date: Wed Nov 29 12:29:26 2017 +0100 lockdep: finer-grained completion key for kthread Ideally we'd create the key through a macro at the real callers and pass it all the way down. This would give us better coverage for cases where a bunch of kthreads are created for the same thing. But this gets the job done meanwhile and unblocks our CI. Refining later on is always possible. v2: - make it compile - use the right map (Tvrtko) v3: lockdep insist on a static key, so the cheap way didn't work. Wire 2 keys through all the callers. I didn't extend this up to alloc_workqueue because the lockdep_invariant_state() call should separate the work functions from the workqueue kthread logic and prevent cross-release state from leaking between unrelated work queues that happen to reuse the same kthreads. v4: CI found more compile fail :-/ Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Cc: Marta Lofstedt <marta.lofstedt@intel.com> References: https://bugs.freedesktop.org/show_bug.cgi?id=103950 Acked-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Acked-by: Chris Wilson <chris@chris-wilson.co.uk> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20171129112926.28704-1-daniel.vetter@ffwll.ch commit 281f8d96fa83efe67198608fe0d1792518c91925 Author: Daniel Vetter <daniel.vetter@ffwll.ch> Date: Wed Nov 29 10:46:36 2017 +0100 lockdep: Up MAX_LOCKDEP_CHAINS cross-release ftl From Chris: "Fwiw, this isn't cross-release but us reloading the module many times, creating a whole host of new lockclasses. Even more fun is when the module gets a slightly different address and the new lock address hashes into an old lock... "I did think about a module-hook to revoke the stale lockclasses, but that still leaves all the hashed chains. "This particular nuisance was temporarily pushed back by teaching igt not to reload i915.ko on a whim." Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Cc: Marta Lofstedt <marta.lofstedt@intel.com> References: https://bugs.freedesktop.org/show_bug.cgi?id=103707 Acked-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Acked-by: Chris Wilson <chris@chris-wilson.co.uk> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20171129094636.18638-2-daniel.vetter@ffwll.ch |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.