Summary: | extra straight line when drawing with stylus | ||
---|---|---|---|
Product: | Wayland | Reporter: | Carlo Caione <carlo> |
Component: | libinput | Assignee: | Wayland bug list <wayland-bugs> |
Status: | RESOLVED FIXED | QA Contact: | |
Severity: | normal | ||
Priority: | medium | CC: | peter.hutterer |
Version: | unspecified | ||
Hardware: | Other | ||
OS: | All | ||
Whiteboard: | |||
i915 platform: | i915 features: | ||
Attachments: |
evemu-log
evemu-log-v1.6.3-issue evemu-log-v1.9.3 |
Description
Carlo Caione
2017-12-04 18:44:57 UTC
Please *attach* an evemu recording of a sequence that generates that extra line, thanks. ping? Created attachment 136244 [details] evemu-log Ups, sorry, missed your request. We have discovered that the latest libinput solves the issue and specifically the commit: commit 8c55bc060df837f986f57c8c26ae2f9c58963bcc Author: Peter Hutterer <peter.hutterer@who-t.net> Date: Mon Nov 13 12:19:44 2017 +1000 fallback: change to handle the state at EV_SYN time solves this problem. I'm going to attach anyway a log taken with evemu and a previous release of libinput without the fixing commit. urgh, that's a two or three year old version of evemu and the recordings from that aren't very hujuman-friendly. Any chance you can re-record with something more recent? https://www.freedesktop.org/wiki/Evemu/ That commit shouldn't have fixed the issue because the pen should be handled by the tablet backend, not the mouse/keyboard one. Which indicates something else is amiss here. > That commit shouldn't have fixed the issue because the pen should be handled > by the tablet backend, not the mouse/keyboard one. Which indicates something > else is amiss here. Odd, I bisected down to that commit myself and at least on my setup that commit is fixing the issue I'm seeing. Please note that on this hardware we are forcing ID_INPUT_TOUCHSCREEN=1 with: ENV{ID_BUS}=="usb", ENV{ID_VENDOR_ID}=="22b9", ENV{ID_MODEL_ID}=="0005", ATTR{[dmi/id]product_name}=="EC10IS1", ENV{ID_INPUT}="1", ENV{ID_INPUT_TABLET}="", ENV{ID_INPUT_TOUCHSCREEN}="1" I'm going to attach (in the next messages) the evemu logs obtained when drawing a straight line, lifting the stylus, and drawing a new straight line starting at a different point. When the issue is visible the end of the first line and the start of the second line are connected by a line even though I lifted the stylus. The two logs are obtained: 1) using an old libinput v1.6.3 where the problem is reproducible 2) using the latest libinput v1.9.3 where the commit 8c55bc060df seems to have solved this issue Also please note that Ubuntu is shipping this patch https://lists.freedesktop.org/archives/wayland-devel/2015-September/024171.html that solves the same issue for older versions of libinput (I guess it was merged some time in the past). Created attachment 136274 [details]
evemu-log-v1.6.3-issue
evemu log taken with libinput v1.6.3 where the issue is present
Created attachment 136275 [details]
evemu-log-v1.9.3
evemu log with latest libinput with no issue present
right, the reason why the commit fixed the issue is your udev rule: ENV{ID_INPUT_TABLET}="", ENV{ID_INPUT_TOUCHSCREEN}="1" this removes the tablet bit and sets the touchscreen bit instead. without that, the code that was fixed wouldn't have triggered. |
Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.