Bug 104154

I think there's a CTS bug about spurious INVALID_OPERATION errors, so this may not be our problem.

In the passing version of the test, Mesa logs the following messages:

Mesa: User error: GL_INVALID_VALUE in glGetTextureSubImage(xoffset = -1)
Mesa: User error: GL_INVALID_VALUE in glGetCompressedTextureImage(xoffset = -1)
Mesa: User error: GL_INVALID_VALUE in glGetTextureSubImage(xoffset 2 + width 4 > 2)
Mesa: User error: GL_INVALID_VALUE in glGetCompressedTextureImage(xoffset 4 + width 8 > 4)
Mesa: User error: GL_INVALID_VALUE in glGetTextureSubImage(1D, yoffset = 1)
Mesa: User error: GL_INVALID_VALUE in glGetTextureSubImage(1D, height = 2)
Mesa: User error: GL_INVALID_VALUE in glGetTextureSubImage(zoffset = 1)
Mesa: User error: GL_INVALID_VALUE in glGetTextureSubImage(zoffset = 1)
Mesa: User error: GL_INVALID_VALUE in glGetCompressedTextureImage(zoffset = 1)

In the failing version of the test, Mesa logs the following messages:

Mesa: User error: GL_INVALID_VALUE in glGetTextureSubImage(xoffset = -1)
Mesa: User error: GL_INVALID_VALUE in glGetCompressedTextureImage(xoffset = -1)
Mesa: User error: GL_INVALID_VALUE in glGetTextureSubImage(xoffset 2 + width 4 > 2)
Mesa: User error: GL_INVALID_VALUE in glGetCompressedTextureImage(xoffset 4 + width 8 > 4)
Mesa: User error: GL_INVALID_VALUE in glGetTextureSubImage(1D, yoffset = 1)
Mesa: User error: GL_INVALID_VALUE in glGetTextureSubImage(zoffset = 1)
Mesa: User error: GL_INVALID_VALUE in glGetTextureSubImage(zoffset = 1)
Mesa: User error: GL_INVALID_VALUE in glGetTextureSubImage(zoffset = 1)
Mesa: User error: GL_INVALID_OPERATION in glGetCompressedTextureImage(texture)

Two lines are different.  The last line is different enough that a different error message is generated, but a couple line before that has

Mesa: User error: GL_INVALID_VALUE in glGetTextureSubImage(1D, height = 2)

vs

Mesa: User error: GL_INVALID_VALUE in glGetTextureSubImage(zoffset = 1)

I'm a little suspicious that this could be some sort of meta-related texture namespace pollution.  I fixed a bunch of this a couple years ago, but I don't think I got all of it.  That at least would explain why the bug only occurs after hours (around 10 hours on my BDW with a debug build) of running.

(In reply to Ian Romanick from comment #2)
> I'm a little suspicious that this could be some sort of meta-related texture
> namespace pollution.  I fixed a bunch of this a couple years ago, but I
> don't think I got all of it.  That at least would explain why the bug only
> occurs after hours (around 10 hours on my BDW with a debug build) of running.

It looks like my meta-cannot-use-Gen branch may have some fixes.  I'll see if I can rebase these on almost 2 years of changes (ouch!), and I'll let that run overnight to see if it fixes it...

Texture object namespace pollution does not seem to be the problem.

I added some more debug information to various paths through glGetCompressedTextureImage (note: this is the DSA flavor).  Output of the good:

Mesa: User error: GL_INVALID_OPERATION in glGetTextureParameterfv(texture = 1)
Mesa: User error: GL_INVALID_OPERATION in glGetTextureParameterIiv(texture = 1)
Mesa: User error: GL_INVALID_OPERATION in glGetTextureParameterIuiv(texture = 1)
Mesa: User error: GL_INVALID_OPERATION in glGetTextureParameteriv(texture = 1)
Mesa: User error: GL_INVALID_OPERATION in glGetTextureParameterfv(target)
Mesa: User error: GL_INVALID_OPERATION in glGetTextureParameterIiv(target)
Mesa: User error: GL_INVALID_OPERATION in glGetTextureParameterIuiv(target)
Mesa: User error: GL_INVALID_OPERATION in glGetTextureParameteriv(target)
Mesa: User error: GL_INVALID_OPERATION in glGetTextureSubImage(texture = 103386)
Mesa: User error: GL_INVALID_OPERATION in glGetCompressedTextureImage(texture = 103386)
Mesa: User error: GL_INVALID_OPERATION in glGetTextureSubImage(buffer/multisample texture)
Mesa: User error: GL_INVALID_VALUE in glGetTextureSubImage(xoffset = -1)
Mesa: User error: GL_INVALID_VALUE in glGetCompressedTextureImage(xoffset = -1)
Mesa: User error: GL_INVALID_VALUE in glGetTextureSubImage(xoffset 2 + width 4 > 2)
Mesa: User error: GL_INVALID_VALUE in glGetCompressedTextureImage(xoffset 4 + width 8 > 4)
Mesa: User error: GL_INVALID_VALUE in glGetTextureSubImage(target = GL_TEXTURE_1D, texture = 103380, yoffset = 1)
Mesa: User error: GL_INVALID_VALUE in glGetTextureSubImage(target = GL_TEXTURE_1D, texture = 103380, height = 2)
Mesa: User error: GL_INVALID_VALUE in glGetTextureSubImage(target = GL_TEXTURE_1D_ARRAY, texture = 103381, zoffset = 1)
Mesa: User error: GL_INVALID_VALUE in glGetTextureSubImage(target = GL_TEXTURE_2D, texture = 103382, zoffset = 1)
Mesa: User error: GL_INVALID_VALUE in glGetCompressedTextureImage(target = GL_TEXTURE_2D, texture = 103384, zoffset = 1)
Mesa: User error: GL_INVALID_OPERATION in glGetTextureSubImage(out of bounds access: bufSize (1) is too small)
Mesa: User error: GL_INVALID_OPERATION in glGetCompressedTextureImage(out of bounds access: bufSize (1) is too small)

Output of the bad:

Mesa: User error: GL_INVALID_OPERATION in glGetTextureParameterfv(texture = 1)
Mesa: User error: GL_INVALID_OPERATION in glGetTextureParameterIiv(texture = 1)
Mesa: User error: GL_INVALID_OPERATION in glGetTextureParameterIuiv(texture = 1)
Mesa: User error: GL_INVALID_OPERATION in glGetTextureParameteriv(texture = 1)
Mesa: User error: GL_INVALID_OPERATION in glGetTextureParameterfv(target)
Mesa: User error: GL_INVALID_OPERATION in glGetTextureParameterIiv(target)
Mesa: User error: GL_INVALID_OPERATION in glGetTextureParameterIuiv(target)
Mesa: User error: GL_INVALID_OPERATION in glGetTextureParameteriv(target)
Mesa: User error: GL_INVALID_OPERATION in glGetTextureSubImage(texture = 103384)
Mesa: User error: GL_INVALID_OPERATION in glGetCompressedTextureImage(texture = 103384)
Mesa: User error: GL_INVALID_OPERATION in glGetTextureSubImage(buffer/multisample texture)
Mesa: User error: GL_INVALID_VALUE in glGetTextureSubImage(xoffset = -1)
Mesa: User error: GL_INVALID_VALUE in glGetCompressedTextureImage(xoffset = -1)
Mesa: User error: GL_INVALID_VALUE in glGetTextureSubImage(xoffset 2 + width 4 > 2)
Mesa: User error: GL_INVALID_VALUE in glGetCompressedTextureImage(xoffset 4 + width 8 > 4)
Mesa: User error: GL_INVALID_VALUE in glGetTextureSubImage(target = GL_TEXTURE_1D, texture = 103378, yoffset = 1)
Mesa: User error: GL_INVALID_VALUE in glGetTextureSubImage(target = GL_TEXTURE_2D, texture = 103380, zoffset = 1)
Mesa: User error: GL_INVALID_VALUE in glGetTextureSubImage(target = GL_TEXTURE_RECTANGLE, texture = 103381, zoffset = 1)
Mesa: User error: GL_INVALID_VALUE in glGetTextureSubImage(target = GL_TEXTURE_2D, texture = 103382, zoffset = 1)
Mesa: User error: GL_INVALID_OPERATION in glGetCompressedTextureImage(texture = 103384)
Mesa: User error: GL_INVALID_OPERATION in glGetTextureSubImage(out of bounds access: bufSize (1) is too small)
Mesa: User error: GL_INVALID_OPERATION in glGetCompressedTextureImage(out of bounds access: bufSize (1) is too small)

The 'GL_INVALID_OPERATION in glGetCompressedTextureImage(texture = 103384)' message is from _mesa_lookup_texture_err when it can't find a texture object with the nae 103384.

I notice that some of the texture IDs do not match between the two runs and some of the texture targets do not match.  While it's possible that the test is nondeterministic (picking a random texture target based one the drawable config or something), I doubt it.

This appears to be a bug in the CTS.  I have submitted an issue and a fix to Khronos.  If this turns out to not be the case, I'll reopen this bug.