Bug 104471

Summary: [CI] igt@kms_atomic_transition@1x-modeset-transitions-nonblocking|[-fencing] - Fail - Test assertion failure function igt_display_try_commit_atomic - Failed assertion: !(flags & (0x01 | 0x0200))
Product: DRI Reporter: Marta Löfstedt <marta.lofstedt>
Component: DRM/IntelAssignee: Marta Löfstedt <marta.lofstedt>
Status: CLOSED FIXED QA Contact: Intel GFX Bugs mailing list <intel-gfx-bugs>
Severity: normal    
Priority: medium CC: intel-gfx-bugs
Version: DRI git   
Hardware: Other   
OS: All   
Whiteboard: ReadyForDev
i915 platform: BXT, GLK, HSW, KBL, SNB i915 features: display/atomic

Description Marta Löfstedt 2018-01-03 06:47:58 UTC
Started with CI_DRM_3588 on all shards

https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3588/shard-snb7/igt@kms_atomic_transition@1x-modeset-transitions-nonblocking.html
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3588/shard-hsw2/igt@kms_atomic_transition@1x-modeset-transitions-nonblocking.html
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3588/shard-apl2/igt@kms_atomic_transition@1x-modeset-transitions-nonblocking.html
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3588/shard-kbl6/igt@kms_atomic_transition@1x-modeset-transitions-nonblocking.html
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3588/shard-glkb2/igt@kms_atomic_transition@1x-modeset-transitions-nonblocking.html


https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3588/shard-snb6/igt@kms_atomic_transition@1x-modeset-transitions-nonblocking-fencing.html
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3588/shard-hsw1/igt@kms_atomic_transition@1x-modeset-transitions-nonblocking-fencing.html
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3588/shard-apl4/igt@kms_atomic_transition@1x-modeset-transitions-nonblocking-fencing.html
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3588/shard-kbl2/igt@kms_atomic_transition@1x-modeset-transitions-nonblocking-fencing.html
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_3588/shard-glkb4/igt@kms_atomic_transition@1x-modeset-transitions-nonblocking-fencing.html
also on IGT_4108

Fail:
(kms_atomic_transition:1480) igt-kms-CRITICAL: Test assertion failure function igt_display_try_commit_atomic, file igt_kms.c:3032:
(kms_atomic_transition:1480) igt-kms-CRITICAL: Failed assertion: !(flags & (0x01 | 0x0200))
(kms_atomic_transition:1480) igt-kms-CRITICAL: First commit has to drop all stale events
Subtest 1x-modeset-transitions-nonblocking failed.
Comment 1 Marta Löfstedt 2018-01-03 07:13:43 UTC
This issue is caused by IGT regression:

commit 98c64b33a7935fb334c73bb0fc9e76f416b81069
Author: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Date:   Thu Dec 7 09:21:36 2017 +0100

    lib/igt_kms: Drop all stale events on first commit.
    
    I've been trying to make kms_cursor_legacy work when subtests fail.
    Other subtests will start failing too because of expired events or
    stale pipe crc. The latter can be resolved in the test, but the former
    could affect other tests
    
    Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
    [mlankhorst: Change return status to int, so callers can see how many events are swallowed.]
    Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Comment 2 Maarten Lankhorst 2018-01-03 11:30:06 UTC
commit 58bd37d347d1369ecd272ff778057ee8004d6b15 (HEAD, origin/master, origin/HEAD)
Author: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Date:   Wed Jan 3 10:17:45 2018 +0100

    kms_atomic_transition: Remove skip_on_unsupported_nonblocking_modeset.
Comment 3 Marta Löfstedt 2018-01-03 11:34:12 UTC
I will monitor and close once we have a CI_DRM run with positive results.
Comment 4 Marta Löfstedt 2018-01-03 13:53:38 UTC
the fix is integrated in IGT_4109 the test pass. I will close and archive this bug.

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.