Bug 104504

Summary: [CAIRO] unable to compile with latest commits
Product: cairo Reporter: Humberto Israel Perez Rodriguez <humberto.i.perez.rodriguez>
Component: generalAssignee: Behdad Esfahbod <freedesktop>
Status: CLOSED FIXED QA Contact: cairo-bugs mailing list <cairo-bugs>
Severity: blocker    
Priority: highest CC: freedesktop, hector.edmundox.ramirez.gomez
Version: unspecified   
Hardware: x86-64 (AMD64)   
OS: Linux (All)   
Whiteboard:
i915 platform: i915 features:
Attachments: cairo_make_command_compilation_log

Description Humberto Israel Perez Rodriguez 2018-01-05 18:55:32 UTC
Created attachment 136573 [details]
cairo_make_command_compilation_log

Hi, cairo is not able to compile with latest commit on ubuntu


any help would be grateful here :-)



cairo-png.c: In function ‘read_png’:
cairo-png.c:550:15: warning: variable ‘data’ might be clobbered by
‘longjmp’ or ‘vfork’ [-Wclobbered]
     png_byte *data = NULL;
               ^~~~
cairo-png.c:551:16: warning: variable ‘row_pointers’ might be clobbered
by ‘longjmp’ or ‘vfork’ [-Wclobbered]
     png_byte **row_pointers = NULL;
                ^~~~~~~~~~~~
cairo-ft-font.c: In function ‘_cairo_ft_unscaled_font_init’:
cairo-ft-font.c:460:7: error: implicit declaration of function
‘FT_Get_Var_Design_Coordinates’ [-Werror=implicit-function-declaration]
       FT_Get_Var_Design_Coordinates (face, ft_mm_var->num_axis,
unscaled->variations);
       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cairo-ft-font.c: In function ‘_cairo_ft_has_color_glyphs’:
cairo-ft-font.c:3003:9: warning: ignoring return value of
‘_cairo_ft_unscaled_font_lock_face’, declared with attribute
warn_unused_result [-Wunused-result]
         _cairo_ft_unscaled_font_lock_face (unscaled);
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  CC       cairo-ps-surface.lo
cc1: some warnings being treated as errors
Makefile:2376: recipe for target 'cairo-ft-font.lo' failed
make[3]: *** [cairo-ft-font.lo] Error 1
make[3]: *** Waiting for unfinished jobs....
make[3]: Leaving directory '/home/gfx/cairo/src'
Makefile:1973: recipe for target 'all' failed
make[2]: *** [all] Error 2
make[2]: Leaving directory '/home/gfx/cairo/src'
Makefile:910: recipe for target 'all-recursive' failed
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory '/home/gfx/cairo'
Makefile:759: recipe for target 'all' failed
make: *** [all] Error 2
Comment 1 Behdad Esfahbod 2018-01-16 00:30:00 UTC
commit 5795ac9d90c4927e9826cf49687a9f84628d9974 (HEAD -> master)
Author: Behdad Esfahbod <behdad@behdad.org>
Date:   Mon Jan 15 19:28:56 2018 -0500

    Fix compile with older FreeType without FT_Get_Var_Design_Coordinates
Comment 2 Humberto Israel Perez Rodriguez 2018-01-16 19:58:35 UTC
(In reply to Behdad Esfahbod from comment #1)
> commit 5795ac9d90c4927e9826cf49687a9f84628d9974 (HEAD -> master)
> Author: Behdad Esfahbod <behdad@behdad.org>
> Date:   Mon Jan 15 19:28:56 2018 -0500
> 
>     Fix compile with older FreeType without FT_Get_Var_Design_Coordinates

Hi Behdad:

i am not sure if this is the same issue that i've reported, but the latest cairo commit is not able to compile so far ...

font-variations.c: In function ‘test_variation’:
font-variations.c:53:5: error: unknown type name ‘FT_Face’
     FT_Face ft_face;
     ^
font-variations.c:54:5: error: unknown type name ‘FT_MM_Var’
     FT_MM_Var *ft_mm_var;
     ^
font-variations.c:55:5: error: unknown type name ‘FT_Error’
     FT_Error ret;
     ^
font-variations.c:56:5: error: unknown type name ‘FT_Fixed’
     FT_Fixed coords[20];
     ^
font-variations.c:57:18: warning: unused variable ‘i’ [-Wunused-variable]
     unsigned int i;
                  ^
font-variations.c:56:14: warning: unused variable ‘coords’ [-Wunused-variable]
     FT_Fixed coords[20];
              ^
font-variations.c:55:14: warning: unused variable ‘ret’ [-Wunused-variable]
     FT_Error ret;
              ^
font-variations.c:54:16: warning: unused variable ‘ft_mm_var’ [-Wunused-variable]
     FT_MM_Var *ft_mm_var;
                ^
font-variations.c:53:13: warning: unused variable ‘ft_face’ [-Wunused-variable]
     FT_Face ft_face;
             ^
font-variations.c:51:20: warning: unused variable ‘status’ [-Wunused-variable]
     cairo_status_t status;
                    ^
font-variations.c:50:27: warning: unused variable ‘options’ [-Wunused-variable]
     cairo_font_options_t *options;
                           ^
font-variations.c:49:20: warning: unused variable ‘matrix’ [-Wunused-variable]
     cairo_matrix_t matrix;
                    ^
font-variations.c:48:26: warning: unused variable ‘scaled_font’ [-Wunused-variable]
     cairo_scaled_font_t *scaled_font;
                          ^
font-variations.c:47:24: warning: unused variable ‘font_face’ [-Wunused-variable]
     cairo_font_face_t *font_face;
                        ^
  CC       cairo_test_suite-group-paint.o
Makefile:4370: recipe for target 'cairo_test_suite-font-variations.o' failed
make[4]: *** [cairo_test_suite-font-variations.o] Error 1
make[4]: *** Waiting for unfinished jobs....
  CC       cairo_test_suite-group-state.o
make[4]: Leaving directory '/home/gfx/intel-graphics/cairo/test'
Makefile:8372: recipe for target 'all-recursive' failed
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory '/home/gfx/intel-graphics/cairo/test'
Makefile:1733: recipe for target 'all' failed
make[2]: *** [all] Error 2
make[2]: Leaving directory '/home/gfx/intel-graphics/cairo/test'
Makefile:910: recipe for target 'all-recursive' failed
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory '/home/gfx/intel-graphics/cairo'
Makefile:759: recipe for target 'all' failed
make: *** [all] Error 2
Comment 3 Humberto Israel Perez Rodriguez 2018-01-18 18:33:59 UTC
*** Bug 104584 has been marked as a duplicate of this bug. ***
Comment 4 Behdad Esfahbod 2018-01-19 19:12:53 UTC
Should be fixed in master. Please check.
Comment 5 Humberto Israel Perez Rodriguez 2018-01-22 20:33:01 UTC
(In reply to Behdad Esfahbod from comment #4)
> Should be fixed in master. Please check.

yes, thanks Behdad for you support :)

Closing this bug

Use of freedesktop.org services, including Bugzilla, is subject to our Code of Conduct. How we collect and use information is described in our Privacy Policy.